From jabrown@stimpy.nlanr.net Mon Oct 25 09:03:03 1999
Return-Path: <jabrown@stimpy.nlanr.net>
Received: from stimpy.nlanr.net (stimpy.nlanr.net [192.172.226.108])
	by hub.freebsd.org (Postfix) with ESMTP id 5857D15056
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 25 Oct 1999 09:02:56 -0700 (PDT)
	(envelope-from jabrown@stimpy.nlanr.net)
Received: (from jabrown@localhost)
	by stimpy.nlanr.net (8.9.3/8.9.3) id JAA74501;
	Mon, 25 Oct 1999 09:02:54 -0700 (PDT)
	(envelope-from jabrown)
Message-Id: <199910251602.JAA74501@stimpy.nlanr.net>
Date: Mon, 25 Oct 1999 09:02:54 -0700 (PDT)
From: jabrown@caida.org
Sender: jabrown@stimpy.nlanr.net
Reply-To: jabrown@caida.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] GIMP 1.1.10 fails to save TIFF files.
X-Send-Pr-Version: 3.2

>Number:         14519
>Category:       ports
>Synopsis:       GIMP 1.1.10 fails to save TIFF files.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    erich
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 25 09:10:00 PDT 1999
>Closed-Date:    Sat Jan 1 16:32:32 PST 2000
>Last-Modified:  Sat Jan  1 16:33:49 PST 2000
>Originator:     Jeff Brown
>Release:        FreeBSD 3.3-RELEASE i386
>Organization:
NLANR/MOAT
>Environment:
3.3-R system with a ports tree CVSup'd daily; the gimp1-1.1.10 port as of 
yesterday.  (With GTK 1.2.3 and TIFF 3.5.1).

>Description:
The recently-updated GIMP port will no longer write TIFF images.  It produces
all of the expeced "save" dialogs, but the actual write operation fails 
without an explicit reason, after writing 8bytes or so of the image header.

>How-To-Repeat:
(with GIMP-1.1.10)
File->New image
Save->choose format 'Tiff', enter a name, click 'OK'.
Notice the little dialog saying, "Save failed!"

>Fix:

Apply the following patch.  I have also submitted this patch to the GIMP
maintainers, and Nick Lamb <njl98r@ecs.soton.ac.uk> has confirmed the problem
and that this patch is correct.  This ought to be fixed in v1.1.11; until
then, we may as well apply the patch locally.
	
--- plug-ins/common/tiff.c.orig	Sun Oct 24 01:49:02 1999
+++ plug-ins/common/tiff.c	Sun Oct 24 02:12:44 1999
@@ -238,7 +238,7 @@
   else if (strcmp (name, "file_tiff_save") == 0)
     {
       image = orig_image = param[1].data.d_int32;
-      drawable = param[1].data.d_int32;
+      drawable = param[2].data.d_int32;
 
 /* Do this right this time, if POSSIBLE query for parasites, otherwise
    or if there isn't one, choose the DEFAULT_COMMENT */


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports->erich 
Responsible-Changed-By: mharo 
Responsible-Changed-When: Mon Oct 25 11:38:09 PDT 1999 
Responsible-Changed-Why:  
Over to MAINTAINER 
State-Changed-From-To: open->closed 
State-Changed-By: vanilla 
State-Changed-When: Sat Jan 1 16:32:32 PST 2000 
State-Changed-Why:  
the current version of ports is 1.1.11, 
and i'm looking 1.1.14 now. 
>Unformatted:
