From nobody@FreeBSD.org  Sun Mar 28 17:00:41 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4C0F71065679
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2010 17:00:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A2888FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2010 17:00:41 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2SH0eBZ003815
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2010 17:00:41 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o2SH0esh003814;
	Sun, 28 Mar 2010 17:00:40 GMT
	(envelope-from nobody)
Message-Id: <201003281700.o2SH0esh003814@www.freebsd.org>
Date: Sun, 28 Mar 2010 17:00:40 GMT
From: Andrei Lavreniyuk <andy.lavr@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [ERROR] cannot portupgrade graphics/ming
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         145115
>Category:       ports
>Synopsis:       [ERROR] cannot portupgrade graphics/ming
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 28 17:10:05 UTC 2010
>Closed-Date:    Sun Mar 28 20:36:39 CEST 2010
>Last-Modified:  Sun Mar 28 18:40:04 UTC 2010
>Originator:     Andrei Lavreniyuk
>Release:        FreeBSD 8.0-STABLE
>Organization:
Technica-03, Inc.
>Environment:
FreeBSD datacenter.technica-03.local 8.0-STABLE FreeBSD 8.0-STABLE #0: Thu Mar 25 12:32:37 EET 2010     root@datacenter.technica-03.local:/usr/obj/usr/src/sys/SMP64  amd64
>Description:
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -fPIC -DPIC -I.. -c assembler.c
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -fPIC -DPIC -I.. -c compileaction.c
cc blocklist.o  displaylist.o  fill.o  font_util.o  ming.o  movie.o  movieclip.o  position.o  shape_cubic.o  shape_util.o  text_util.o  gc.o actioncompiler/compile.o  actioncompiler/swf4compiler.tab.o  actioncompiler/lex.swf4.o  actioncompiler/swf5compiler.tab.o  actioncompiler/lex.swf5.o  actioncompiler/compileaction.o  actioncompiler/assembler.o -L. -L.. -L/usr/local/lib -lz -lm -lungif -lpng blocks/*.o -shared -Wl,-soname,libming.so.4 -o libming.so.4
cp libming.so.4 ..
ln -fs libming.so.4 ../libming.so
(cd util && make)
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -I.. -I../src -c action.c
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -I.. -I../src -c blocktypes.c
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -I.. -I../src -c decompile.c -o decompile.o
decompile.c:110:1: warning: "putchar" redefined
In file included from decompile.c:7:
/usr/include/stdio.h:495:1: warning: this is the location of the previous definition
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -I.. -I../src -c main.c
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -I.. -I../src -c parser.c
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -I.. -I../src -c read.c
cc -O2 -pipe -O2 -D_FORTIFY_SOURCE=2 -pipe -march=native -mtune=native -fno-delete-null-pointer-checks -fstack-protector -fno-strict-aliasing -Wformat -Wformat-security -s -I. -I.. -I/usr/local/include -Wall -I. -I.. -I../src -L. -L.. -L/usr/local/lib -L.. -lming -lz -lm -lungif -lpng -DNODECOMPILE action.o blocktypes.o decompile.o main.o parser.o read.o outputtxt.c -o listswf
./libming.so: undefined reference to `png_check_sig'
*** Error code 1

Stop in /usr/ports/graphics/ming/work/ming-0.3.0/util.
*** Error code 1

Stop in /usr/ports/graphics/ming/work/ming-0.3.0.
*** Error code 1

Stop in /usr/ports/graphics/ming/work/ming-0.3.0.
*** Error code 1

Stop in /usr/ports/graphics/ming.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- src/blocks/pngdbl.c.orig	2006-02-08 21:09:27.000000000 +0200
+++ src/blocks/pngdbl.c	2010-03-28 18:39:51.766663825 +0300
@@ -34,7 +34,7 @@
 
 	if(fread(header, 1, 8, fp) != 8)
 		return NULL;
-	if(!png_check_sig(header, 8))
+	if(!png_sig_cmp(header, 0, 8))
 		return NULL;
 	result = png_create_read_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);
 	if(!result)
@@ -54,7 +54,7 @@
 	
 	if(SWFInput_read(input, header, 8) != 8)
 		return NULL;
-	if(!png_check_sig(header, 8))
+	if(!png_sig_cmp(header, 0, 8))
 		return NULL;
 	result = png_create_read_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL);
 	if(!result)


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Sun Mar 28 19:42:55 CEST 2010 
Responsible-Changed-Why:  
I will take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145115 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Sun Mar 28 20:36:04 CEST 2010 
State-Changed-Why:  
committed a modified patch, the return value has chaned too, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145115 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/145115: commit references a PR
Date: Sun, 28 Mar 2010 18:35:53 +0000 (UTC)

 dinoex      2010-03-28 18:35:45 UTC
 
   FreeBSD ports repository
 
   Added files:
     graphics/ming/files  patch-src_blocks_pngdbl.c 
   Log:
   - fix build for png-1.4.1
   PR:             145115
   
   Revision  Changes    Path
   1.1       +20 -0     ports/graphics/ming/files/patch-src_blocks_pngdbl.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
