From nobody@FreeBSD.org  Sun Mar 28 16:37:22 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3321D106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2010 16:37:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 076518FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2010 16:37:22 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2SGbLda075093
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 28 Mar 2010 16:37:21 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o2SGbLDJ075092;
	Sun, 28 Mar 2010 16:37:21 GMT
	(envelope-from nobody)
Message-Id: <201003281637.o2SGbLDJ075092@www.freebsd.org>
Date: Sun, 28 Mar 2010 16:37:21 GMT
From: Pascal Stumpf <Pascal.Stumpf@cubes.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: png update breaks print/dvipdfmx
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         145112
>Category:       ports
>Synopsis:       png update breaks print/dvipdfmx
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 28 16:40:05 UTC 2010
>Closed-Date:    Sun Mar 28 20:50:06 CEST 2010
>Last-Modified:  Sun Mar 28 18:50:08 UTC 2010
>Originator:     Pascal Stumpf
>Release:        8.0-STABLE
>Organization:
-
>Environment:
>Description:
Another port that has been broken by the png update:

cc  -O2 -pipe -fno-strict-aliasing   -L/usr/local/lib -o dvipdfmx dvipdfmx-agl.o
  dvipdfmx-bmpimage.o dvipdfmx-cff.o  dvipdfmx-cff_dict.o dvipdfmx-cid.o  dvipdf
mx-cidtype0.o dvipdfmx-cidtype2.o  dvipdfmx-cmap.o dvipdfmx-cmap_read.o  dvipdfm
x-cmap_write.o dvipdfmx-cs_type2.o  dvipdfmx-dpxconf.o dvipdfmx-dpxcrypt.o  dvip
dfmx-dpxfile.o dvipdfmx-dpxutil.o  dvipdfmx-dvi.o dvipdfmx-dvipdfmx.o  dvipdfmx-
epdf.o dvipdfmx-error.o  dvipdfmx-fontmap.o dvipdfmx-jpegimage.o  dvipdfmx-mem.o
 dvipdfmx-mfileio.o  dvipdfmx-mpost.o dvipdfmx-numbers.o  dvipdfmx-otl_conf.o dv
ipdfmx-otl_opt.o  dvipdfmx-pdfcolor.o dvipdfmx-pdfdev.o  dvipdfmx-pdfdoc.o dvipd
fmx-pdfdraw.o  dvipdfmx-pdfencoding.o dvipdfmx-pdfencrypt.o  dvipdfmx-pdffont.o
dvipdfmx-pdfnames.o  dvipdfmx-pdfobj.o dvipdfmx-pdfparse.o  dvipdfmx-pdfresource
.o dvipdfmx-pdfximage.o  dvipdfmx-pkfont.o dvipdfmx-pngimage.o  dvipdfmx-pst.o d
vipdfmx-pst_obj.o  dvipdfmx-sfnt.o dvipdfmx-spc_color.o  dvipdfmx-spc_dvips.o dv
ipdfmx-spc_html.o  dvipdfmx-spc_misc.o dvipdfmx-spc_pdfm.o  dvipdfmx-spc_tpic.o
dvipdfmx-spc_util.o  dvipdfmx-specials.o dvipdfmx-subfont.o  dvipdfmx-tfm.o dvip
dfmx-tt_aux.o  dvipdfmx-tt_cmap.o dvipdfmx-tt_glyf.o  dvipdfmx-tt_gsub.o dvipdfm
x-tt_post.o  dvipdfmx-tt_table.o dvipdfmx-truetype.o  dvipdfmx-type0.o dvipdfmx-
t1_char.o  dvipdfmx-t1_load.o dvipdfmx-type1.o  dvipdfmx-type1c.o dvipdfmx-unico
de.o  dvipdfmx-vf.o dvipdfmx-xbb.o    -lpng -lm -lz -lpaper -lkpathsea -lkpathse
a
dvipdfmx-pngimage.o(.text+0x222f): In function `check_for_png':
: undefined reference to `png_check_sig'
*** Error code 1

Stop in /usr/ports/print/dvipdfmx/work/dvipdfmx-20090522/src.
*** Error code 1

Stop in /usr/ports/print/dvipdfmx/work/dvipdfmx-20090522.
*** Error code 1

Stop in /usr/ports/print/dvipdfmx/work/dvipdfmx-20090522.
*** Error code 1

Stop in /usr/ports/print/dvipdfmx.

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->matusita 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Mar 28 16:40:34 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145112 

From: "Andrei V. Lavreniyuk" <andy.lavr@reactor-xg.kiev.ua>
To: freebsd-ports-bugs@freebsd.org, bug-followup@freebsd.org,
        Pascal.Stumpf@cubes.de
Cc:  
Subject: Re: ports/145112: png update breaks print/dvipdfmx
Date: Sun, 28 Mar 2010 19:56:50 +0300

 This is a multi-part message in MIME format.
 --------------060402080302020905060704
 Content-Type: text/plain; charset=KOI8-R; format=flowed
 Content-Transfer-Encoding: 8bit
 
 28.03.2010 19:37, Pascal Stumpf :
 
 > dvipdfmx-pngimage.o(.text+0x222f): In function `check_for_png':
 > : undefined reference to `png_check_sig'
 > *** Error code 1
 
 
 
 --- src/pngimage.c.orig 2009-05-11 05:15:26.000000000 +0300
 +++ src/pngimage.c      2010-03-28 19:14:53.218820917 +0300
 @@ -148,7 +148,7 @@
     rewind (png_file);
     if (fread (sigbytes, 1, sizeof(sigbytes), png_file) !=
         sizeof(sigbytes) ||
 -      (!png_check_sig (sigbytes, sizeof(sigbytes))))
 +      (!png_sig_cmp (sigbytes, 0, sizeof(sigbytes))))
       return 0;
     else
       return 1;
 
 
 
 
 
 -- 
   Best regards, Andrei V. Lavreniyuk.
 
 
 --------------060402080302020905060704
 Content-Type: text/plain;
  name="patch-pngimage.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch-pngimage.c.diff"
 
 --- src/pngimage.c.orig	2009-05-11 05:15:26.000000000 +0300
 +++ src/pngimage.c	2010-03-28 19:14:53.218820917 +0300
 @@ -148,7 +148,7 @@
    rewind (png_file);
    if (fread (sigbytes, 1, sizeof(sigbytes), png_file) !=
        sizeof(sigbytes) ||
 -      (!png_check_sig (sigbytes, sizeof(sigbytes))))
 +      (!png_sig_cmp (sigbytes, 0, sizeof(sigbytes))))
      return 0;
    else
      return 1;
 
 --------------060402080302020905060704--
Responsible-Changed-From-To: matusita->dinoex 
Responsible-Changed-By: dinoex 
Responsible-Changed-When: Sun Mar 28 19:14:45 CEST 2010 
Responsible-Changed-Why:  
I will take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145112 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Sun Mar 28 20:48:10 CEST 2010 
State-Changed-Why:  
committed a modified patch, the return value has chaned too, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=145112 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/145112: commit references a PR
Date: Sun, 28 Mar 2010 18:49:55 +0000 (UTC)

 dinoex      2010-03-28 18:49:42 UTC
 
   FreeBSD ports repository
 
   Added files:
     print/dvipdfmx/files patch-src-pngimage.c 
   Log:
   - fix build for png-1.4.1
   PR:             145112
   
   Revision  Changes    Path
   1.1       +11 -0     ports/print/dvipdfmx/files/patch-src-pngimage.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
