From nobody@FreeBSD.org  Wed Mar 24 01:17:57 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D03691065673
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Mar 2010 01:17:57 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id C00CB8FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Mar 2010 01:17:57 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2O1HvTQ023255
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 24 Mar 2010 01:17:57 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o2O1HvIX023254;
	Wed, 24 Mar 2010 01:17:57 GMT
	(envelope-from nobody)
Message-Id: <201003240117.o2O1HvIX023254@www.freebsd.org>
Date: Wed, 24 Mar 2010 01:17:57 GMT
From: Ryan Steinmetz <rpsfa@rit.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Fix net-snmp dependancy for net/ifstat
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: alexey@renatasystems.org

>Number:         144991
>Category:       ports
>Synopsis:       [patch] Fix net-snmp dependancy for net/ifstat
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 24 01:20:02 UTC 2010
>Closed-Date:    Sun Apr 11 11:59:19 UTC 2010
>Last-Modified:  Sun Apr 11 12:00:11 UTC 2010
>Originator:     Ryan Steinmetz
>Release:        7.2-RELEASE
>Organization:
Rochester Institute of Technology
>Environment:
FreeBSD xxx.rit.edu 7.2-RELEASE-p4 FreeBSD 7.2-RELEASE-p4 #7: Wed Feb  3 18:40:17 EST 2010     root@xxx.rit.edu:/usr/obj/usr/src/sys/xxx  i386
>Description:
net/ifstat (when built WITH_SNMP=YES) has an incorrect LIB_DEPEND of netsnmp.10, when it should be netsnmp.16.
>How-To-Repeat:
cd /usr/ports/net-mgmt/net-snmp && make install
cd /usr/ports/net/ifstat && make WITH_SNMP=yes install

>Fix:


Patch attached with submission follows:

diff -urN /tmp/ifstat/Makefile /usr/ports/net/ifstat/Makefile
--- /tmp/ifstat/Makefile	2010-03-23 21:09:01.000000000 -0400
+++ /usr/ports/net/ifstat/Makefile	2010-03-23 21:09:10.000000000 -0400
@@ -26,7 +26,7 @@
 .include <bsd.port.pre.mk>
 
 .if defined(WITH_SNMP)
-LIB_DEPENDS+=	netsnmp.10:${PORTSDIR}/net-mgmt/net-snmp
+LIB_DEPENDS+=	netsnmp.16:${PORTSDIR}/net-mgmt/net-snmp
 .else
 CONFIGURE_ARGS+=	--without-snmp
 .endif


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Mar 24 01:20:17 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144991 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: alexey@renatasystems.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/144991: [patch] Fix net-snmp dependancy for net/ifstat
Date: Wed, 24 Mar 2010 01:20:15 UT

 Maintainer of net/ifstat,
 
 Please note that PR ports/144991 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144991
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Alexey V. Degtyarev" <alexey@renatasystems.org>
To: bug-followup@FreeBSD.org
Cc: Ryan Steinmetz <rpsfa@rit.edu>
Subject: Re: ports/144991: [patch] Fix net-snmp dependancy for net/ifstat
Date: Wed, 24 Mar 2010 14:36:07 +0300

 --FCuugMFkClbJLl1L
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Hi,
 
 On 01:20 Wed 24 Mar, Edwin Groothuis wrote:
 
 > Maintainer of net/ifstat,
 > 
 > Please note that PR ports/144991 has just been submitted.
 > 
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 
 Thanks Ryan to your attention,
 
 I think it is necessary and sufficient condition would be to check any
 version of libsnmp instead of particular one. So I suggest to remove
 version number from LIB_DEPENDS at all.
 
 Please commit the patch I attached.
 
 -- 
 Alexey V. Degtyarev
 
 --FCuugMFkClbJLl1L
 Content-Type: text/x-diff; charset=us-ascii
 Content-Disposition: attachment; filename="ifstat-libdepend.patch"
 
 diff -ur ifstat.orig/Makefile ifstat/Makefile
 --- ifstat.orig/Makefile	2009-02-21 21:24:47.000000000 +0000
 +++ ifstat/Makefile	2010-03-24 10:49:39.000000000 +0000
 @@ -26,7 +26,7 @@
  .include <bsd.port.pre.mk>
  
  .if defined(WITH_SNMP)
 -LIB_DEPENDS+=	netsnmp.10:${PORTSDIR}/net-mgmt/net-snmp
 +LIB_DEPENDS+=	netsnmp:${PORTSDIR}/net-mgmt/net-snmp
  .else
  CONFIGURE_ARGS+=	--without-snmp
  .endif
 
 --FCuugMFkClbJLl1L--
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Wed Mar 24 13:52:23 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144991 
State-Changed-From-To: feedback->closed 
State-Changed-By: wxs 
State-Changed-When: Sun Apr 11 11:59:17 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144991 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/144991: commit references a PR
Date: Sun, 11 Apr 2010 11:57:29 +0000 (UTC)

 wxs         2010-04-11 11:57:21 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/ifstat           Makefile 
   Log:
   - Correct libsnmp major version in LIB_DEPENDS.
   
   PR:             ports/144991
   Submitted by:   Ryan Steinmetz <rpsfa@rit.edu>
   
   Revision  Changes    Path
   1.15      +1 -1      ports/net/ifstat/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
