From nobody@FreeBSD.org  Tue Mar 23 13:35:25 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 61E7C106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Mar 2010 13:35:25 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 50FF38FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Mar 2010 13:35:25 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o2NDZPfd013254
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Mar 2010 13:35:25 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o2NDZO8A013233;
	Tue, 23 Mar 2010 13:35:24 GMT
	(envelope-from nobody)
Message-Id: <201003231335.o2NDZO8A013233@www.freebsd.org>
Date: Tue, 23 Mar 2010 13:35:24 GMT
From: Javier Villavicencio <the_paya@gentoo.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: import of zlib 1.2.4 may break code defining _LARGEFILE64_SOURCE 
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         144976
>Category:       ports
>Synopsis:       import of zlib 1.2.4 may break code defining _LARGEFILE64_SOURCE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 23 13:40:02 UTC 2010
>Closed-Date:    Mon May 03 22:03:24 UTC 2010
>Last-Modified:  Mon May 03 22:03:24 UTC 2010
>Originator:     Javier Villavicencio
>Release:        8.0
>Organization:
Gentoo
>Environment:
FreeBSD Alniyat 8.0-RELEASE FreeBSD Gentoo 8.0 #0: Tue Mar 16 04:27:57 ARST 2010     root@Alniyat:/usr/src/sys-8.0-r0/i386/compile/ALNIYAT  i386
>Description:
Just a heads up.

On svn rev. 205471 zlib was updated to 1.2.4, this version contains this piece of code in zlib.h:

#ifdef _LARGEFILE64_SOURCE
   ZEXTERN gzFile ZEXPORT gzopen64 OF((const char *, const char *));
   ZEXTERN off64_t ZEXPORT gzseek64 OF((gzFile, off64_t, int));
   ZEXTERN off64_t ZEXPORT gztell64 OF((gzFile));
   ZEXTERN off64_t ZEXPORT gzoffset64 OF((gzFile));
   ZEXTERN uLong ZEXPORT adler32_combine64 OF((uLong, uLong, off64_t));
   ZEXTERN uLong ZEXPORT crc32_combine64 OF((uLong, uLong, off64_t));

Some software may define _LARGEFILE64_SOURCE and, off64_t apparently being a glibc thing, by also including this particular zlib.h it will cause a compilation failure.


This was discovered by Alexis Ballier while working on Gentoo/FreeBSD, reported on our bugzilla: 

http://bugs.gentoo.org/show_bug.cgi?id=310209
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: delphij 
State-Changed-When: Thu Mar 25 23:22:56 UTC 2010 
State-Changed-Why:  
Hi, 

Thanks for bringing this to our attention, we will see whether there would 
be problem during the test build exprun. 

In my opinion the whole _LARGE_FILE_SOURCE related concept are broken :( 
We define _FILE_OFFSET_BITS as 64 since *BSDs have 64-bit off_t from the 
day 0 we derived from 4.4BSD-Lite.  I am thinking about some better way 
of representing these in a more portable way and hopefully I can work out 
a better solution before zlib 1.2.5's release. 



Responsible-Changed-From-To: freebsd-ports-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Thu Mar 25 23:22:56 UTC 2010 
Responsible-Changed-Why:  
Take.  Do we have any packages known to broken with the new zlib? 
(Debian uses newer zlib for their testing branch so maybe they have 
some knowledge about this anyways) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144976 
State-Changed-From-To: feedback->closed 
State-Changed-By: delphij 
State-Changed-When: Mon May 3 22:02:58 UTC 2010 
State-Changed-Why:  
I believe that this have been fixed by zlib 1.2.5 import. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144976 
>Unformatted:
