From nobody@FreeBSD.org  Tue Mar  9 00:35:29 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8313F106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  9 Mar 2010 00:35:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 72B848FC18
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  9 Mar 2010 00:35:29 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o290ZSiv041174
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 9 Mar 2010 00:35:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o290ZSBK041172;
	Tue, 9 Mar 2010 00:35:28 GMT
	(envelope-from nobody)
Message-Id: <201003090035.o290ZSBK041172@www.freebsd.org>
Date: Tue, 9 Mar 2010 00:35:28 GMT
From: Benjamin Lee <ben@b1c1l1.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: graphics/gd WITH_FONTCONFIG and WITHOUT_X11 are not exclusive
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         144567
>Category:       ports
>Synopsis:       graphics/gd WITH_FONTCONFIG and WITHOUT_X11 are not exclusive
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dinoex
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 09 00:40:03 UTC 2010
>Closed-Date:    Tue Mar 09 15:08:37 CET 2010
>Last-Modified:  Tue Mar 09 15:08:37 CET 2010
>Originator:     Benjamin Lee
>Release:        8.0-RELEASE-p2
>Organization:
>Environment:
FreeBSD eclipse.b1c1l1.com 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #0: Tue Jan  5 16:02:27 UTC 2010     root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Currently, the graphics/gd port can only build with fontconfig support (via the WITH_FONTCONFIG knob) if WITHOUT_X11 is not defined.

This is an unnecessary restriction, as gd can build with fontconfig support on machine built with WITHOUT_X11 defined.
>How-To-Repeat:
Build graphics/gd with both WITHOUT_X11 and WITH_FONTCONFIG defined.
>Fix:
Apply the attached patch.

Patch attached with submission follows:

--- /usr/ports/graphics/gd/Makefile	2010-02-05 03:38:31.000000000 -0800
+++ Makefile	2010-03-08 16:30:11.000000000 -0800
@@ -50,6 +50,8 @@
 FEATURES+=	GD_XPM
 .endif
 
+.endif
+
 .if defined(WITH_FONTCONFIG)
 LIB_DEPENDS+=	fontconfig.1:${PORTSDIR}/x11-fonts/fontconfig
 CPPFLAGS+=	-I${LOCALBASE}/include -DHAVE_LIBFONTCONFIG -DHAVE_PTHREAD ${PTHREAD_CFLAGS}
@@ -58,8 +60,6 @@
 FEATURES+=	GD_FONTCONFIG
 .endif
 
-.endif
-
 .if defined(WITH_ICONV)
 USE_ICONV=	yes
 CPPFLAGS+=	-DHAVE_ICONV -DHAVE_ICONV_H -DHAVE_ICONV_T_DEF


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->dinoex 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Mar 9 00:40:14 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144567 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/144567: commit references a PR
Date: Tue,  9 Mar 2010 13:48:19 +0000 (UTC)

 dinoex      2010-03-09 13:48:05 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/gd          Makefile 
   Log:
   - allow option WITH_FONTCONFIG with WITHOUT_X11
   PR:             144567
   Submitted by:   Benjamin Lee
   
   Revision  Changes    Path
   1.94      +1 -3      ports/graphics/gd/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: dinoex 
State-Changed-When: Tue Mar 9 15:08:12 CET 2010 
State-Changed-Why:  
committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144567 
>Unformatted:
