From pgollucci@frieza.p6m7g8.net  Wed Feb 24 05:09:57 2010
Return-Path: <pgollucci@frieza.p6m7g8.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AB690106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 24 Feb 2010 05:09:57 +0000 (UTC)
	(envelope-from pgollucci@frieza.p6m7g8.net)
Received: from frieza.p6m7g8.net (wsip-174-79-184-239.dc.dc.cox.net [174.79.184.239])
	by mx1.freebsd.org (Postfix) with ESMTP id 4C8208FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 24 Feb 2010 05:09:56 +0000 (UTC)
Received: from frieza.p6m7g8.net (localhost [127.0.0.1])
	by frieza.p6m7g8.net (8.14.4/8.14.4) with ESMTP id o1O59uUL066988;
	Wed, 24 Feb 2010 00:09:56 -0500 (EST)
	(envelope-from pgollucci@frieza.p6m7g8.net)
Received: (from pgollucci@localhost)
	by frieza.p6m7g8.net (8.14.4/8.14.4/Submit) id o1O59ugC066987;
	Wed, 24 Feb 2010 00:09:56 -0500 (EST)
	(envelope-from pgollucci)
Message-Id: <201002240509.o1O59ugC066987@frieza.p6m7g8.net>
Date: Wed, 24 Feb 2010 00:09:56 -0500 (EST)
From: "Philip M. Gollucci" <pgollucci@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: cristianorolim@hotmail.com, keith@ridecharge.com
Subject: [PATCH] sysutils/rsyslog: -a is obsolete in rc.d script
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         144253
>Category:       ports
>Synopsis:       [PATCH] sysutils/rsyslog: -a is obsolete in rc.d script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 24 05:10:04 UTC 2010
>Closed-Date:    Mon Mar 08 23:00:24 UTC 2010
>Last-Modified:  Mon Mar  8 23:10:07 UTC 2010
>Originator:     Philip M. Gollucci
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
RideCharge Inc.
>Environment:
System: FreeBSD frieza.p6m7g8.net 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Mon Feb 15 21:36:01 EST 2010
>Description:
sudo /usr/local/etc/rc.d/rsyslogd restart
Stopping rsyslogd.
Waiting for PIDS: 81844.
Starting rsyslogd.
error -a is no longer supported, use module imuxsock insteaderror -a is no longer supported, use module imuxsock instead

Port maintainer (cristianorolim@hotmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- rsyslog-5.3.7.patch begins here ---
Index: files/rsyslogd.in
===================================================================
RCS file: /home/ncvs/ports/sysutils/rsyslog5/files/rsyslogd.in,v
retrieving revision 1.2
diff -u -u -r1.2 rsyslogd.in
--- files/rsyslogd.in	18 Dec 2009 20:44:28 -0000	1.2
+++ files/rsyslogd.in	24 Feb 2010 05:08:26 -0000
@@ -23,56 +23,4 @@
 start_precmd="rsyslogd_precmd"
 extra_commands="reload"
 
-sockfile="/var/run/rsyslogd.sockets"
-evalargs="rc_flags=\"\`set_socketlist\` \$rc_flags\""
-altlog_proglist="named"
-
-rsyslogd_precmd()
-{
-	local _l _ldir
-
-	#	Transitional symlink for old binaries
-	#
-	if [ ! -L /dev/log ]; then
-		ln -sf /var/run/log /dev/log
-	fi
-	rm -f /var/run/log
-
-	#	Create default list of syslog sockets to watch
-	#
-	( umask 022 ; > $sockfile )
-
-	#	If running named(8) or ntpd(8) chrooted, added appropriate
-	#	syslog socket to list of sockets to watch.
-	#
-	for _l in $altlog_proglist; do
-		eval _ldir=\$${_l}_chrootdir
-		if checkyesno `set_rcvar $_l` && [ -n "$_ldir" ]; then
-			echo "${_ldir}/var/run/log" >> $sockfile
-		fi
-	done
-
-	#	If other sockets have been provided, change run_rc_command()'s
-	#	internal copy of $rsyslogd_flags to force use of specific
-	#	rsyslogd sockets.
-	#
-	if [ -s $sockfile ]; then
-		echo "/var/run/log" >> $sockfile
-		eval $evalargs
-	fi
-
-	return 0
-}
-
-set_socketlist()
-{
-	local _s _socketargs
-
-	_socketargs=
-	for _s in `cat $sockfile | tr '\n' ' '` ; do
-		_socketargs="-a $_s $_socketargs"
-	done
-	echo $_socketargs
-}
-
 run_rc_command "$1"
--- rsyslog-5.3.7.patch ends here ---

>Release-Note:
>Audit-Trail:

From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: "Philip M. Gollucci" <pgollucci@freebsd.org>
Cc: <FreeBSD-gnats-submit@freebsd.org>, <keith@ridecharge.com>,
	<cristianorolim@hotmail.com>
Subject: Re: ports/144253: [PATCH] sysutils/rsyslog: -a is obsolete in rc.d
 script
Date: Wed, 24 Feb 2010 05:13:54 +0000

 missed one line
 -start_precmd="rsyslogd_precmd"
 
 needs to go too.
 
 
 
 On 02/24/10 05:09, Philip M. Gollucci wrote:
 >> Number:         144253
 >> Category:       ports
 >> Synopsis:       [PATCH] sysutils/rsyslog: -a is obsolete in rc.d script
 >> Confidential:   no
 >> Severity:       non-critical
 >> Priority:       low
 >> Responsible:    freebsd-ports-bugs
 >> State:          open
 >> Quarter:
 >> Keywords:
 >> Date-Required:
 >> Class:          change-request
 >> Submitter-Id:   current-users
 >> Arrival-Date:   Wed Feb 24 05:10:04 UTC 2010
 >> Closed-Date:
 >> Last-Modified:
 >> Originator:     Philip M. Gollucci
 >> Release:        FreeBSD 9.0-CURRENT amd64
 >> Organization:
 > RideCharge Inc.
 >> Environment:
 > System: FreeBSD frieza.p6m7g8.net 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Mon Feb 15 21:36:01 EST 2010
 >> Description:
 > sudo /usr/local/etc/rc.d/rsyslogd restart
 > Stopping rsyslogd.
 > Waiting for PIDS: 81844.
 > Starting rsyslogd.
 > error -a is no longer supported, use module imuxsock insteaderror -a is no longer supported, use module imuxsock instead
 >
 > Port maintainer (cristianorolim@hotmail.com) is cc'd.
 >
 > Generated with FreeBSD Port Tools 0.99
 >> How-To-Repeat:
 >> Fix:
 >
 > --- rsyslog-5.3.7.patch begins here ---
 > Index: files/rsyslogd.in
 > ===================================================================
 > RCS file: /home/ncvs/ports/sysutils/rsyslog5/files/rsyslogd.in,v
 > retrieving revision 1.2
 > diff -u -u -r1.2 rsyslogd.in
 > --- files/rsyslogd.in	18 Dec 2009 20:44:28 -0000	1.2
 > +++ files/rsyslogd.in	24 Feb 2010 05:08:26 -0000
 > @@ -23,56 +23,4 @@
 >   start_precmd="rsyslogd_precmd"
 >   extra_commands="reload"
 >
 > -sockfile="/var/run/rsyslogd.sockets"
 > -evalargs="rc_flags=\"\`set_socketlist\` \$rc_flags\""
 > -altlog_proglist="named"
 > -
 > -rsyslogd_precmd()
 > -{
 > -	local _l _ldir
 > -
 > -	#	Transitional symlink for old binaries
 > -	#
 > -	if [ ! -L /dev/log ]; then
 > -		ln -sf /var/run/log /dev/log
 > -	fi
 > -	rm -f /var/run/log
 > -
 > -	#	Create default list of syslog sockets to watch
 > -	#
 > -	( umask 022 ;>  $sockfile )
 > -
 > -	#	If running named(8) or ntpd(8) chrooted, added appropriate
 > -	#	syslog socket to list of sockets to watch.
 > -	#
 > -	for _l in $altlog_proglist; do
 > -		eval _ldir=\$${_l}_chrootdir
 > -		if checkyesno `set_rcvar $_l`&&  [ -n "$_ldir" ]; then
 > -			echo "${_ldir}/var/run/log">>  $sockfile
 > -		fi
 > -	done
 > -
 > -	#	If other sockets have been provided, change run_rc_command()'s
 > -	#	internal copy of $rsyslogd_flags to force use of specific
 > -	#	rsyslogd sockets.
 > -	#
 > -	if [ -s $sockfile ]; then
 > -		echo "/var/run/log">>  $sockfile
 > -		eval $evalargs
 > -	fi
 > -
 > -	return 0
 > -}
 > -
 > -set_socketlist()
 > -{
 > -	local _s _socketargs
 > -
 > -	_socketargs=
 > -	for _s in `cat $sockfile | tr '\n' ' '` ; do
 > -		_socketargs="-a $_s $_socketargs"
 > -	done
 > -	echo $_socketargs
 > -}
 > -
 >   run_rc_command "$1"
 > --- rsyslog-5.3.7.patch ends here ---
 >
 >> Release-Note:
 >> Audit-Trail:
 >> Unformatted:
 > _______________________________________________
 > freebsd-ports-bugs@freebsd.org mailing list
 > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
 > To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
 
 
 -- 
 ------------------------------------------------------------------------
 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
 Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
 VP Apache Infrastructure; Member, Apache Software Foundation
 Committer,                        FreeBSD Foundation
 Consultant,                       P6M7G8 Inc.
 Sr. System Admin,                 Ridecharge Inc.
 
 Work like you don't need the money,
 love like you'll never get hurt,
 and dance like nobody's watching.

From: "Cristiano Rolim" <cristianorolim@hotmail.com>
To: <bug-followup@FreeBSD.org>,
	<pgollucci@freebsd.org>
Cc:  
Subject: Re: ports/144253: [PATCH] sysutils/rsyslog: -a is obsolete in rc.d script
Date: Fri, 5 Mar 2010 13:36:41 -0300

 I am getting the following with this patch:
 
 [root@bsd8 /usr/ports/sysutils/rsyslog5]# /usr/local/etc/rc.d/rsyslogd start
 rsyslogd_precmd: not found
 /usr/local/etc/rc.d/rsyslogd: WARNING: failed precmd routine for rsyslogd
 
 Removing the line left all thing running well.
 
 I am re-sending the patch without the line.
 
 --
 Cristiano Rolim Pereira
 
 
 --- ../rsyslog5.orig/files/rsyslogd.in	2010-02-26 00:06:10.000000000 -0300
 +++ files/rsyslogd.in	2010-03-05 13:33:12.000000000 -0300
 @@ -20,59 +20,6 @@
  pidfile="${rsyslogd_pidfile}"
  command_args="-i ${pidfile} -f ${rsyslogd_config}"
  required_files="${rsyslogd_config}"
 -start_precmd="rsyslogd_precmd"
  extra_commands="reload"
 
 -sockfile="/var/run/rsyslogd.sockets"
 -evalargs="rc_flags=\"\`set_socketlist\` \$rc_flags\""
 -altlog_proglist="named"
 -
 -rsyslogd_precmd()
 -{
 -	local _l _ldir
 -
 -	#	Transitional symlink for old binaries
 -	#
 -	if [ ! -L /dev/log ]; then
 -		ln -sf /var/run/log /dev/log
 -	fi
 -	rm -f /var/run/log
 -
 -	#	Create default list of syslog sockets to watch
 -	#
 -	( umask 022 ; > $sockfile )
 -
 -	#	If running named(8) or ntpd(8) chrooted, added appropriate
 -	#	syslog socket to list of sockets to watch.
 -	#
 -	for _l in $altlog_proglist; do
 -		eval _ldir=\$${_l}_chrootdir
 -		if checkyesno `set_rcvar $_l` && [ -n "$_ldir" ]; then
 -			echo "${_ldir}/var/run/log" >> $sockfile
 -		fi
 -	done
 -
 -	#	If other sockets have been provided, change run_rc_command()'s
 -	#	internal copy of $rsyslogd_flags to force use of specific
 -	#	rsyslogd sockets.
 -	#
 -	if [ -s $sockfile ]; then
 -		echo "/var/run/log" >> $sockfile
 -		eval $evalargs
 -	fi
 -
 -	return 0
 -}
 -
 -set_socketlist()
 -{
 -	local _s _socketargs
 -
 -	_socketargs=
 -	for _s in `cat $sockfile | tr '\n' ' '` ; do
 -		_socketargs="-a $_s $_socketargs"
 -	done
 -	echo $_socketargs
 -}
 -
  run_rc_command "$1"
 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Mon Mar 8 23:00:17 UTC 2010 
State-Changed-Why:  
included in ports/144566 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144253 

From: "Cristiano Rolim" <cristianorolim@hotmail.com>
To: <bug-followup@FreeBSD.org>,
	<pgollucci@freebsd.org>
Cc:  
Subject: Re: ports/144253: [PATCH] sysutils/rsyslog: -a is obsolete in rc.d script
Date: Mon, 8 Mar 2010 19:57:16 -0300

 This is a multi-part message in MIME format.
 
 ------=_NextPart_000_0005_01CABEF9.8DCB3740
 Content-Type: text/plain;
 	charset="iso-8859-1"
 Content-Transfer-Encoding: quoted-printable
 
 As I included this patch inside the update to version 5.4.0 =
 (http://www.freebsd.org/cgi/query-pr.cgi?pr=3D144566), please end this =
 thread.
 
 Thanks.
 
 --
 Cristiano Rolim Pereira
 ------=_NextPart_000_0005_01CABEF9.8DCB3740
 Content-Type: text/html;
 	charset="iso-8859-1"
 Content-Transfer-Encoding: quoted-printable
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
 <HTML><HEAD>
 <META content=3Dtext/html;charset=3Diso-8859-1 =
 http-equiv=3DContent-Type>
 <META name=3DGENERATOR content=3D"MSHTML 8.00.7600.16490"></HEAD>
 <BODY style=3D"PADDING-LEFT: 10px; PADDING-RIGHT: 10px; PADDING-TOP: =
 15px"=20
 id=3DMailContainerBody leftMargin=3D0 topMargin=3D0 =
 CanvasTabStop=3D"true"=20
 name=3D"Compose message area">
 <DIV><FONT size=3D2 face=3DArial>As I&nbsp;included this patch inside =
 the update to=20
 version 5.4.0 (<A=20
 href=3D"wlmailhtml:{DF73A767-AA36-4564-91FD-4ABBAAAC33B9}mid://00000005/!=
 x-usc:http://www.freebsd.org/cgi/query-pr.cgi?pr=3D144566"><FONT=20
 title=3D"wlmailhtml:{DF73A767-AA36-4564-91FD-4ABBAAAC33B9}mid://00000005/=
 !x-usc:http://www.freebsd.org/cgi/query-pr.cgi?pr=3D144566&#10;CTRL + =
 Click to follow link"=20
 size=3D3=20
 face=3D"Times New =
 Roman">http://www.freebsd.org/cgi/query-pr.cgi?pr=3D144566</FONT></A>),=20
 please end this thread.</FONT></DIV>
 <DIV><FONT size=3D2 face=3DArial></FONT>&nbsp;</DIV>
 <DIV><FONT size=3D2 face=3DArial>Thanks.</FONT></DIV>
 <DIV><FONT size=3D2 face=3DArial></FONT>&nbsp;</DIV>
 <DIV><FONT size=3D2 face=3DArial>--<BR>Cristiano Rolim=20
 Pereira</FONT></DIV></BODY></HTML>
 
 ------=_NextPart_000_0005_01CABEF9.8DCB3740--
 
>Unformatted:
