From max@accessibility.org  Tue Feb 23 06:26:35 2010
Return-Path: <max@accessibility.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3F639106568B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Feb 2010 06:26:35 +0000 (UTC)
	(envelope-from max@accessibility.org)
Received: from bourbon.accessibility.org (bourbon.accessibility.org [210.226.20.19])
	by mx1.freebsd.org (Postfix) with ESMTP id 0E1318FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Feb 2010 06:26:34 +0000 (UTC)
Received: from bourbon.accessibility.org (localhost [127.0.0.1])
	by bourbon.accessibility.org (Postfix) with ESMTP id A54EC547403
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 23 Feb 2010 15:26:33 +0900 (JST)
Received: by bourbon.accessibility.org (Postfix, from userid 1000)
	id 3BA95547402; Tue, 23 Feb 2010 15:26:33 +0900 (JST)
Message-Id: <20100223062633.3BA95547402@bourbon.accessibility.org>
Date: Tue, 23 Feb 2010 15:26:33 +0900 (JST)
From: Masafumi NAKANE <max@FreeBSD.org>
Reply-To: Masafumi NAKANE <max@accessibility.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: ports/textproc/urlview installs non-text browser even when it's not needed
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         144223
>Category:       ports
>Synopsis:       ports/textproc/urlview installs non-text browser even when it's not needed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 23 06:30:04 UTC 2010
>Closed-Date:    Thu Sep 09 19:52:08 UTC 2010
>Last-Modified:  Thu Sep  9 20:00:17 UTC 2010
>Originator:     Masafumi NAKANE
>Release:        FreeBSD 7.0-RELEASE-p5 i386
>Organization:
>Environment:
System: FreeBSD bourbon.accessibility.org 7.0-RELEASE-p5 FreeBSD 7.0-RELEASE-p5 #2: Fri Oct 3 16:27:21 JST 2008 root@bourbon.accessibility.org:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
	
ports/textproc/urlview depends on one of Firefox, SeaMonkey, or Gecko 
according to WITH_* variable defined at make time.
While this has no problem for desktop system where these browsers are used,
this is not desirable on systems where only text browsers, such as
Lynx, w3m, etc., are used.
The fact that there is no easy way to specify, that you don't need any of
these browsers installed and just urlview to be installed, makes the 
issue somewhat serious.

>How-To-Repeat:
	
>Fix:

	

Patch below adds the config dialog so that users can specify
what they need (or don't need) at build time.

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/textproc/urlview/Makefile,v
retrieving revision 1.26
diff -u -r1.26 Makefile
--- Makefile	5 Feb 2010 11:44:35 -0000	1.26
+++ Makefile	23 Feb 2010 06:18:06 -0000
@@ -25,15 +25,19 @@
 SUB_FILES=	gecko.sh
 SUB_LIST=	GECKO=${GECKO}
 
-.include <bsd.port.pre.mk>
+OPTIONS=	GECKO	"Use Gecko"	off \
+		SEAMONKEY "Use SeaMonkey"	off \
+		FIREFOX "Use Firefox"	off
 
+.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 .if defined(WITH_GECKO)
 USE_GECKO=	firefox-devel firefox35 seamonkey
 .include "${PORTSDIR}/Mk/bsd.gecko.mk"
 .elif defined(WITH_SEAMONKEY)
 RUN_DEPENDS+=	${LOCALBASE}/lib/seamonkey/seamonkey-bin:${PORTSDIR}/www/seamonkey
 GECKO=		seamonkey
-.else
+.elif defined(WITH_FIREFOX)
 RUN_DEPENDS+=	${LOCALBASE}/lib/firefox3/firefox:${PORTSDIR}/www/firefox35
 GECKO=		firefox3
 .endif

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->obrien 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Feb 23 06:30:16 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144223 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Thu Sep 9 19:51:51 UTC 2010 
State-Changed-Why:  
Problem corrected.  Sorry for the trouble. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144223 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/144223: commit references a PR
Date: Thu,  9 Sep 2010 19:52:02 +0000 (UTC)

 obrien      2010-09-09 19:51:37 UTC
 
   FreeBSD ports repository
 
   Modified files:
     textproc/urlview     Makefile 
   Log:
   Rev 1.22 (PR 102954) was a bad idea.  This port should not have any default
   dependencies as it causes too much trouble for folks using this port not with
   Firefox.  'pkg_add -r urlview' should not add X11 and Firefox to ones system.
   
   PR:             142378, 144223, 150372
   Submitted by:   Erwan David <erwan@rail.eu.org>, max, Arthur Mesh <arthurmesh@gmail.com>
   
   Revision  Changes    Path
   1.29      +0 -3      ports/textproc/urlview/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
