From nobody@FreeBSD.org  Tue Feb 16 19:17:47 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2FD771065679
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Feb 2010 19:17:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 1DC0C8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Feb 2010 19:17:47 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o1GJHkY1028119
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Feb 2010 19:17:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o1GJHkkR028118;
	Tue, 16 Feb 2010 19:17:46 GMT
	(envelope-from nobody)
Message-Id: <201002161917.o1GJHkkR028118@www.freebsd.org>
Date: Tue, 16 Feb 2010 19:17:46 GMT
From: bf <bf1783@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH]math/ntl: update to 5.5.2
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: wenheping@gmail.com

>Number:         144011
>Category:       ports
>Synopsis:       [PATCH]math/ntl: update to 5.5.2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wen
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 16 19:20:11 UTC 2010
>Closed-Date:    Mon Feb 22 02:45:08 UTC 2010
>Last-Modified:  Mon Feb 22 22:00:10 UTC 2010
>Originator:     bf
>Release:        9-CURRENT amd64
>Organization:
-
>Environment:
>Description:
Update to 5.5.2.  Support non-default PREFIX/LOCALBASE.  Allow the port to be built with lang/gcc4* and devel/binutils.  Simplify a few parts of the Makefile.  Add a test target.

I did not add a shared library because our devel/libtool22 has problems with lang/gcc4*, and I wanted to make it possible to use the later compilers, without having to patch the port.  I may revisit this in a later commit, and possibly also add gf2x support, if nobody else has done so.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -x 'old.*' -x 'new.*' -ruN ntl.orig/Makefile ntl/Makefile
--- ntl.orig/Makefile	2010-02-16 13:48:10.000000000 -0500
+++ ntl/Makefile	2010-02-16 14:03:41.000000000 -0500
@@ -6,8 +6,7 @@
 #
 
 PORTNAME=	ntl
-PORTVERSION=	5.4.2
-PORTREVISION=	2
+PORTVERSION=	5.5.2
 CATEGORIES=	math
 MASTER_SITES=	http://www.shoup.net/ntl/
 
@@ -17,31 +16,35 @@
 # ntl is faster with libgmp4, but you can disable it
 .if !defined(WITHOUT_GMP)
 LIB_DEPENDS=	gmp.8:${PORTSDIR}/math/libgmp4
+
+CONFIGURE_ARGS=	NTL_GMP_LIP=on
 .endif
 
 USE_PERL5_BUILD=	yes
 HAS_CONFIGURE=	yes
-CONFIGURE_ARGS=	CC="${CC}" CFLAGS="${CFLAGS}" \
-		CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" NTL_STD_CXX=on
-
-.if !defined(WITHOUT_GMP)
-CONFIGURE_ARGS+=	NTL_GMP_LIP=on GMP_PREFIX="${LOCALBASE}"
-.endif
-
-CONFIGURE_WRKSRC=	${BUILD_WRKSRC}
+CONFIGURE_ARGS+=	AR="${AR}" \
+		CC="${CC}" CFLAGS="${CFLAGS}" \
+		CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \
+		DEF_PREFIX="${LOCALBASE}" \
+		LDFLAGS="${LDFLAGS}" NTL_STD_CXX=on \
+		PREFIX="${PREFIX}" RANLIB="${RANLIB}"
 
-BUILD_WRKSRC=	${WRKSRC}/src
+WRKSRC=	${WRKDIR}/${DISTNAME}/src
 MAKEFILE=	makefile
 
 do-install:
 	${MKDIR} ${PREFIX}/include/NTL
-	${INSTALL_DATA} ${WRKSRC}/include/NTL/*  ${PREFIX}/include/NTL/
-	${INSTALL_DATA} ${BUILD_WRKSRC}/ntl.a ${PREFIX}/lib/libntl.a
+	${INSTALL_DATA} ${WRKSRC}/../include/NTL/*  ${PREFIX}/include/NTL/
+	${INSTALL_DATA} ${WRKSRC}/ntl.a ${PREFIX}/lib/libntl.a
 
 post-install:
 .if !defined(NOPORTDOCS)
 	${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/doc/* ${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/../doc/* ${DOCSDIR}
 .endif
 
+test: build
+	@(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} \
+		${MAKE_FLAGS} ${MAKEFILE} ${MAKE_ARGS} check)
+
 .include <bsd.port.mk>
diff -x 'old.*' -x 'new.*' -ruN ntl.orig/distinfo ntl/distinfo
--- ntl.orig/distinfo	2010-02-16 13:48:10.000000000 -0500
+++ ntl/distinfo	2010-02-16 11:47:29.000000000 -0500
@@ -1,3 +1,3 @@
-MD5 (ntl-5.4.2.tar.gz) = 0aac5c680eee09a19732e1601b237a0b
-SHA256 (ntl-5.4.2.tar.gz) = 06925936cabba68e4c3d7371e8681381292d21e8cc22ac68314bf36e265ded58
-SIZE (ntl-5.4.2.tar.gz) = 692630
+MD5 (ntl-5.5.2.tar.gz) = 2e0afa1fa3b325e562ce89da57cba983
+SHA256 (ntl-5.5.2.tar.gz) = ef7fe7c8b60ec6e05b2a279caad0081263f7fb68b7360120846644cde726ff56
+SIZE (ntl-5.5.2.tar.gz) = 707247
diff -x 'old.*' -x 'new.*' -ruN ntl.orig/pkg-plist ntl/pkg-plist
--- ntl.orig/pkg-plist	2010-02-16 13:48:10.000000000 -0500
+++ ntl/pkg-plist	2010-02-16 13:26:33.000000000 -0500
@@ -148,6 +148,7 @@
 %%PORTDOCS%%%%DOCSDIR%%/tour-ex5.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-ex6.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-examples.html
+%%PORTDOCS%%%%DOCSDIR%%/tour-gf2x.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-gmp.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-impl.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-intro.html
@@ -156,6 +157,7 @@
 %%PORTDOCS%%%%DOCSDIR%%/tour-stdcxx.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-struct.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-time.html
+%%PORTDOCS%%%%DOCSDIR%%/tour-tips.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-unix.html
 %%PORTDOCS%%%%DOCSDIR%%/tour-win.html
 %%PORTDOCS%%%%DOCSDIR%%/tour.html


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Feb 16 19:20:19 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144011 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: wenheping@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/144011: [PATCH]math/ntl: update to 5.5.2
Date: Tue, 16 Feb 2010 19:20:18 UT

 Maintainer of math/ntl,
 
 Please note that PR ports/144011 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144011
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->wen 
Responsible-Changed-By: lwhsu 
Responsible-Changed-When: Wed Feb 17 07:23:23 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer.  Some people like to change MAINTAINER field along 
with port updating. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144011 
State-Changed-From-To: feedback->closed 
State-Changed-By: wen 
State-Changed-When: Mon Feb 22 02:45:07 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=144011 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/144011: commit references a PR
Date: Mon, 22 Feb 2010 02:44:43 +0000 (UTC)

 wen         2010-02-22 02:44:33 UTC
 
   FreeBSD ports repository
 
   Modified files:
     math/ntl             Makefile distinfo pkg-plist 
   Log:
   - Update to 5.5.2 [1]
   - Update my mail address to FreeBSD
   
   PR:             ports/144011 [1]
   Submitted by:   bf <bf1783@gmail.com> [1]
   Feature safe:   yes
   
   Revision  Changes    Path
   1.16      +18 -15    ports/math/ntl/Makefile
   1.11      +3 -3      ports/math/ntl/distinfo
   1.8       +2 -0      ports/math/ntl/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: "b. f." <bf1783@googlemail.com>
To: wen@freebsd.org
Cc: wenheping@gmail.com, bug-followup@FreeBSD.org
Subject: Re: ports/144011: [PATCH]math/ntl: update to 5.5.2
Date: Mon, 22 Feb 2010 16:59:27 -0500

 On 2/21/10, wen@freebsd.org <wen@freebsd.org> wrote:
 > Synopsis: [PATCH]math/ntl: update to 5.5.2
 >
 > State-Changed-From-To: feedback->closed
 > State-Changed-By: wen
 > State-Changed-When: Mon Feb 22 02:45:07 UTC 2010
 > State-Changed-Why:
 > Committed. Thanks!
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=144011
 >
 
 Great, thanks.  But you should also bump the PORTREVISIONs of other
 ports that need to link to the libraries in this port.
 
 Regards,
                  b.
>Unformatted:
