From nobody@FreeBSD.org  Tue Feb 16 05:48:30 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3CB77106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Feb 2010 05:48:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 128A38FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Feb 2010 05:48:30 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o1G5mTub072771
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 16 Feb 2010 05:48:29 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o1G5mTqA072770;
	Tue, 16 Feb 2010 05:48:29 GMT
	(envelope-from nobody)
Message-Id: <201002160548.o1G5mTqA072770@www.freebsd.org>
Date: Tue, 16 Feb 2010 05:48:29 GMT
From: Richard Kolkovich <sarumont@sigil.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ZSH_MEM, ZSH_SECURE_FREE, DEBUG
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143981
>Category:       ports
>Synopsis:       [patch] shells/zsh: ZSH_MEM, ZSH_SECURE_FREE, DEBUG
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bapt
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Feb 16 05:50:01 UTC 2010
>Closed-Date:    Sun Nov 06 18:36:07 UTC 2011
>Last-Modified:  Sun Nov  6 18:40:11 UTC 2011
>Originator:     Richard Kolkovich
>Release:        8.0-STABLE
>Organization:
sigil.org
>Environment:
FreeBSD magus 8.0-STABLE FreeBSD 8.0-STABLE #1: Mon Feb 15 18:10:24 CST 2010     root@magus:/usr/obj/usr/source/RELENG_8/sys/MAGUS  amd64
>Description:
zsh 'exit' takes approximately 10s with 30k history items,
SAVEHIST/HISTSIZE both at 100000 on my amd64 build.  An i386 jail is
faster using the same history file, but it is still not "instant".
Diagnosed the problem to be the zsh memory (de)allocation routines.
Compiling without --enable-zsh-mem results in my zsh exiting "instantly"

The attached patch separates the zsh-mem and zsh-secure-free options in
the port, defaulting zsh-mem to off.
>How-To-Repeat:
Install zsh with default options on an amd64 build and try to exit zsh
with 30k+ items in ~/.histfile
>Fix:
Don't compile with --enable-zsh-mem

Patch attached with submission follows:

--- Makefile.orig	2010-01-22 08:29:35.000000000 -0600
+++ Makefile	2010-02-15 23:40:02.000000000 -0600
@@ -40,11 +40,13 @@
 EXTRA_COMPLETION_DIR=	Completion/BSD/Command
 
 OPTIONS=	ZSH_GDBM	"Enable GDBM support (GPL)" off \
-		ZSH_MEM		"Enable zsh-mem and zsh-secure-free options" on \
+		ZSH_MEM		"Enable zsh-mem" off \
+		ZSH_SECURE_FREE "Enable zsh-secure-free option" on \
 		ZSH_MAILDIR	"Enable support for Maildirs in MAIL(PATH)" on \
 		ZSH_MULTIBYTE	"Enable multibyte character support" on \
 		ZSH_PCRE	"Enable PCRE support" off \
-		ZSH_STATIC	"Build static executable" off
+		ZSH_STATIC	"Build static executable" off \
+		DEBUG	"Compile with debugging symbols" off
 
 PLIST_SUB+=	ZSH_VER="${ZSH_VER}"
 
@@ -78,7 +80,11 @@
 .endif
 
 .if defined(WITH_ZSH_MEM)
-CONFIGURE_ARGS+=	--enable-zsh-mem --enable-zsh-secure-free
+CONFIGURE_ARGS+=	--enable-zsh-mem 
+.endif
+
+.if defined(WITH_ZSH_SECURE_FREE)
+CONFIGURE_ARGS+=	--enable-zsh-secure-free
 .endif
 
 .if defined(WITH_ZSH_MAILDIR)
@@ -100,6 +106,12 @@
 CONFIGURE_ARGS+=	--disable-multibyte
 .endif
 
+.if defined(WITH_DEBUG)
+CONFIGURE_ARGS+=	--enable-zsh-debug
+.else
+CONFIGURE_ARGS+=	--disable-zsh-debug
+.endif
+
 post-patch:
 	@${SED} -i "" -e "s,link=dynamic,link=either," \
 		${WRKSRC}/Src/Modules/*.mdd


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->des 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Feb 16 06:32:57 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143981 

From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: freebsd-gnats-submit@freebsd.org 
Cc:  
Subject: Re: ports/143981: [patch] shells/zsh: ZSH_MEM, ZSH_SECURE_FREE, DEBUG
Date: Tue, 16 Feb 2010 12:56:56 +0100

 Do we really want a zsh-specific DEBUG option?  Shouldn't we rather
 piggyback on WITH_DEBUG?
 
 DES
 --=20
 Dag-Erling Sm=C3=B8rgrav - des@des.no
State-Changed-From-To: open->feedback 
State-Changed-By: miwi 
State-Changed-When: Sat Feb 5 06:04:39 UTC 2011 
State-Changed-Why:  
any process here? if no let close. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143981 
Responsible-Changed-From-To: des->bapt 
Responsible-Changed-By: bapt 
Responsible-Changed-When: Mon Feb 28 10:35:44 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143981 

From: Richard Kolkovich <richard@sigil.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/143981: [patch] shells/zsh: ZSH_MEM, ZSH_SECURE_FREE, DEBUG
Date: Wed, 12 Oct 2011 11:26:58 -0600

 --0016e6de17d402cc2e04af1d56d6
 Content-Type: text/plain; charset=ISO-8859-1
 
 Attached a modified patch to remove the DEBUG option and just use WITH_DEBUG.
 
 -- 
 
 Richard Kolkovich
 +1 303 219 0042
 http://www.sigil.org
 
 --0016e6de17d402cc2e04af1d56d6
 Content-Type: text/plain; charset=US-ASCII; name="patch.txt"
 Content-Disposition: attachment; filename="patch.txt"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gtoldm2t0
 
 LS0tIE1ha2VmaWxlLm9yaWcJMjAxMS0wOS0yMyAxNjoyNToyMS4wMDAwMDAwMDAgLTA2MDAKKysr
 IE1ha2VmaWxlCTIwMTEtMTAtMTIgMTE6MjI6MzYuMDAwMDAwMDAwIC0wNjAwCkBAIC00NSw3ICs0
 NSw4IEBACiBMSUNFTlNFX0ZJTEU9CSR7V1JLU1JDfS9MSUNFTkNFCiAKIE9QVElPTlM9CVpTSF9H
 REJNCSJFbmFibGUgR0RCTSBzdXBwb3J0IChHUEwpIiBvZmYgXAotCQlaU0hfTUVNCQkiRW5hYmxl
 IHpzaC1tZW0gYW5kIHpzaC1zZWN1cmUtZnJlZSBvcHRpb25zIiBvbiBcCisJCVpTSF9NRU0JCSJF
 bmFibGUgenNoLW1lbSIgb2ZmIFwKKwkJWlNIX1NFQ1VSRV9GUkVFICJFbmFibGUgenNoLXNlY3Vy
 ZS1mcmVlIG9wdGlvbiIgb24gXAogCQlaU0hfTUFJTERJUgkiRW5hYmxlIHN1cHBvcnQgZm9yIE1h
 aWxkaXJzIGluIE1BSUwoUEFUSCkiIG9uIFwKIAkJWlNIX01VTFRJQllURQkiRW5hYmxlIG11bHRp
 Ynl0ZSBjaGFyYWN0ZXIgc3VwcG9ydCIgb24gXAogCQlaU0hfUENSRQkiRW5hYmxlIFBDUkUgc3Vw
 cG9ydCIgb2ZmIFwKQEAgLTgzLDcgKzg0LDExIEBACiAuZW5kaWYKIAogLmlmIGRlZmluZWQoV0lU
 SF9aU0hfTUVNKQotQ09ORklHVVJFX0FSR1MrPQktLWVuYWJsZS16c2gtbWVtIC0tZW5hYmxlLXpz
 aC1zZWN1cmUtZnJlZQorQ09ORklHVVJFX0FSR1MrPQktLWVuYWJsZS16c2gtbWVtIAorLmVuZGlm
 CisKKy5pZiBkZWZpbmVkKFdJVEhfWlNIX1NFQ1VSRV9GUkVFKQorQ09ORklHVVJFX0FSR1MrPQkt
 LWVuYWJsZS16c2gtc2VjdXJlLWZyZWUKIC5lbmRpZgogCiAuaWYgZGVmaW5lZChXSVRIX1pTSF9N
 QUlMRElSKQpAQCAtMTA1LDYgKzExMCwxMiBAQAogQ09ORklHVVJFX0FSR1MrPQktLWRpc2FibGUt
 bXVsdGlieXRlCiAuZW5kaWYKIAorLmlmIGRlZmluZWQoV0lUSF9ERUJVRykKK0NPTkZJR1VSRV9B
 UkdTKz0JLS1lbmFibGUtenNoLWRlYnVnCisuZWxzZQorQ09ORklHVVJFX0FSR1MrPQktLWRpc2Fi
 bGUtenNoLWRlYnVnCisuZW5kaWYKKwogcG9zdC1wYXRjaDoKIAlAJHtTRUR9IC1pICIiIC1lICJz
 LGxpbms9ZHluYW1pYyxsaW5rPWVpdGhlciwiIFwKIAkJJHtXUktTUkN9L1NyYy9Nb2R1bGVzLyou
 bWRkCg==
 --0016e6de17d402cc2e04af1d56d6--
State-Changed-From-To: feedback->closed 
State-Changed-By: bapt 
State-Changed-When: Sun Nov 6 18:36:05 UTC 2011 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143981 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143981: commit references a PR
Date: Sun,  6 Nov 2011 18:35:15 +0000 (UTC)

 bapt        2011-11-06 18:35:06 UTC
 
   FreeBSD ports repository
 
   Modified files:
     shells/zsh           Makefile 
   Log:
   - split the zsh_mem option into zsh_mem and zsh_secure_free activate secure_free my default disable mem by default[1]
   - correct memory report for time builtin [2]
   - bump portrevision
   
   PR:             ports/143981 [1], ports/152820 [2]
   Submitted by:   Richard Kolkovich <sarumont@sigil.org> [1], Anonymous <swell.k@gmail.com> and Tsu <inyaoo@gmail.com> [2]
   Hurried by:     miwi :)
   
   Revision  Changes    Path
   1.129     +19 -8     ports/shells/zsh/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
