From thierry@pompo.net  Thu Feb 11 20:24:17 2010
Return-Path: <thierry@pompo.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5CA771065679;
	Thu, 11 Feb 2010 20:24:17 +0000 (UTC)
	(envelope-from thierry@pompo.net)
Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [212.27.42.5])
	by mx1.freebsd.org (Postfix) with ESMTP id 4C1888FC08;
	Thu, 11 Feb 2010 20:24:14 +0000 (UTC)
Received: from smtp5-g21.free.fr (localhost [127.0.0.1])
	by smtp5-g21.free.fr (Postfix) with ESMTP id 16427D480AD;
	Thu, 11 Feb 2010 21:24:09 +0100 (CET)
Received: from graf.pompo.net (graf.pompo.net [78.225.128.39])
	by smtp5-g21.free.fr (Postfix) with ESMTP id C5E73D481BD;
	Thu, 11 Feb 2010 21:24:06 +0100 (CET)
Received: by graf.pompo.net (Postfix, from userid 1001)
	id EDFE61146A; Thu, 11 Feb 2010 21:24:04 +0100 (CET)
Message-Id: <20100211202404.EDFE61146A@graf.pompo.net>
Date: Thu, 11 Feb 2010 21:24:04 +0100 (CET)
From: Thierry Thomas <thierry@FreeBSD.org>
Reply-To: Thierry Thomas <thierry@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Tong LIU <nemoliu@FreeBSD.org>, Stephen Montgomery-Smith <stephen@missouri.edu>
Subject: cad/gmsh: don't depend on TAUCS by default to unbreak Code_Aster
X-Send-Pr-Version: 3.113
X-GNATS-Notify: stephen@missouri.edu

>Number:         143820
>Category:       ports
>Synopsis:       cad/gmsh: don't depend on TAUCS by default to unbreak Code_Aster
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    thierry
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 11 20:30:02 UTC 2010
>Closed-Date:    Sat Feb 13 08:28:02 UTC 2010
>Last-Modified:  Sat Feb 13 08:30:06 UTC 2010
>Originator:     Thierry Thomas
>Release:        FreeBSD 8.0-STABLE i386
>Organization:
Kabbale Eros
>Environment:
System: FreeBSD graf.pompo.net 8.0-STABLE FreeBSD 8.0-STABLE #0: Sat Dec 5 19:27:51 CET 2009 thierry@graf.pompo.net:/usr/obj/usr/src/sys/GRAF090829 i386


	
>Description:
	Since commit 1.82 for /ports/cad/gmsh/Makefile, which set Taucs
	as a default dependence for Gmsh, the port french/aster is
	broken:

	http://www.freebsd.org/cgi/cvsweb.cgi/ports/cad/gmsh/Makefile.diff?r1=1.81;r2=1.82;f=h

	The problem is that french/aster depends on Gmsh and metis-edf,
	but Taucs depends on metis, which conflicts with metis-edf!

	Note: if Taucs is required for some reason, and Gmsh needs to be
	packaged with it, we could consider to create another slave port.

>How-To-Repeat:
	Try to install the port french/aster.

>Fix:
	Please apply the following patch:

--- gmsh.diff begins here ---
diff -urN cad/gmsh.orig/Makefile cad/gmsh/Makefile
--- cad/gmsh.orig/Makefile	2010-02-07 15:03:21.000000000 +0100
+++ cad/gmsh/Makefile	2010-02-11 21:13:33.000000000 +0100
@@ -80,7 +80,7 @@
 PLIST_SUB+=	METIS="@comment "
 .endif
 
-.if !defined(WITHOUT_TAUCS)
+.if defined(WITH_TAUCS)
 LIB_DEPENDS+=	taucs.1:${PORTSDIR}/math/taucs
 CMAKE_ARGS+=	-DENABLE_TAUCS=ON
 .else
--- gmsh.diff ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->thierry 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Feb 11 20:30:40 UTC 2010 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143820 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Feb 11 20:30:46 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143820 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: stephen@missouri.edu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/143820: cad/gmsh: don't depend on TAUCS by default to unbreak Code_Aster
Date: Thu, 11 Feb 2010 20:30:44 UT

 Maintainer of cad/gmsh,
 
 Please note that PR ports/143820 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143820
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

Date: Thu, 11 Feb 2010 14:33:15 -0600
From: Stephen Montgomery-Smith <stephen@missouri.edu>
To: Thierry Thomas <thierry@FreeBSD.org>
Subject: Re: cad/gmsh: don't depend on TAUCS by default to unbreak Code_Aster

 I have absolutely no problem with making gmsh not install TAUCS by 
 default.  I only put it in because it was possible.  I don't use it myself.
 
 The patch isn't quite right - you will have to change WITHOUT_TAUCS to 
 WITH_TAUCS in a few other places, mostly error checking, messages, 
 comments and such like.  Please think through the logic when you make 
 the changes - it isn't hard, but a simple s/WITHOUT_TAUCS/WITH_TAUCS/ 
 isn't going to suffice.

From: Thierry Thomas <thierry@FreeBSD.org>
To: Stephen Montgomery-Smith <stephen@missouri.edu>
Cc: "FreeBSD-gnats-submit@freebsd.org" <FreeBSD-gnats-submit@FreeBSD.org>,
	Tong LIU <nemoliu@FreeBSD.org>
Subject: Re: ports/143820: cad/gmsh: don't depend on TAUCS by default to unbreak Code_Aster
Date: Fri, 12 Feb 2010 18:39:28 +0100

 On Thu 11 feb 10 at 21:33:15 +0100, Stephen Montgomery-Smith <stephen@missouri.edu>
  wrote:
  
 > I have absolutely no problem with making gmsh not install TAUCS by 
 > default.  I only put it in because it was possible.  I don't use it myself.
 > 
 > The patch isn't quite right - you will have to change WITHOUT_TAUCS to 
 > WITH_TAUCS in a few other places, mostly error checking, messages, 
 > comments and such like.  Please think through the logic when you make 
 > the changes - it isn't hard, but a simple s/WITHOUT_TAUCS/WITH_TAUCS/ 
 > isn't going to suffice.
 
 Sorry, I just reverted commit 1.82...
 
 Please check the attached one:
 
 --- gmsh.diff begins here ---
 diff -urN cad/gmsh.orig/Makefile cad/gmsh/Makefile
 --- cad/gmsh.orig/Makefile	2010-02-07 15:03:21.000000000 +0100
 +++ cad/gmsh/Makefile	2010-02-12 18:28:27.000000000 +0100
 @@ -62,10 +62,10 @@
  .endif
  
  # Even though the taucs port pulls in the metis port, we will still need
 -# WITHOUT_METIS not set when WITHOUT_TAUCS is not set, otherwise the linker
 +# WITHOUT_METIS not set when WITH_TAUCS is set, otherwise the linker
  # does not find the libraries installed by the metis port.
 -.if !defined(WITHOUT_TAUCS) && defined(WITHOUT_METIS)
 -IGNORE=		requires that WITHOUT_METIS is not set if WITHOUT_TAUCS is not set
 +.if defined(WITH_TAUCS) && defined(WITHOUT_METIS)
 +IGNORE=		requires that WITHOUT_METIS is not set if WITH_TAUCS is set
  .endif
  
  .if !defined(WITHOUT_METIS)
 @@ -80,7 +80,7 @@
  PLIST_SUB+=	METIS="@comment "
  .endif
  
 -.if !defined(WITHOUT_TAUCS)
 +.if defined(WITH_TAUCS)
  LIB_DEPENDS+=	taucs.1:${PORTSDIR}/math/taucs
  CMAKE_ARGS+=	-DENABLE_TAUCS=ON
  .else
 @@ -132,8 +132,8 @@
  	@${ECHO_MSG} "3D mesh generator."
  	@${ECHO_MSG} ""
  .endif
 -.if !defined(WITHOUT_TAUCS)
 -	@${ECHO_MSG} "Define WITHOUT_TAUCS to disable the Taucs linear algebra solver."
 +.if defined(WITH_TAUCS)
 +	@${ECHO_MSG} "Define WITH_TAUCS to enable the Taucs linear algebra solver."
  	@${ECHO_MSG} ""
  .endif
  .if !defined(WITHOUT_MED)
 @@ -182,7 +182,7 @@
  	@${ECHO} "http://glaros.dtc.umn.edu/gkhome/metis/metis/faq?q=metis/metis/faq#distribute" >> ${PKGMESSAGE}
  	@${ECHO} "\"A Fast and Highly Quality Multilevel Scheme for Partitioning Irregular Graphs\". George Karypis and Vipin Kumar. SIAM Journal on Scientific Computing, Vol. 20, No. 1, pp. 359-392, 1999." >> ${PKGMESSAGE}
  .endif
 -.if !defined(WITHOUT_TAUCS)
 +.if defined(WITH_TAUCS)
  	@${ECHO} >> ${PKGMESSAGE}
  	@${ECHO} "There might be licensing issues with using Taucs with Gmsh" >> ${PKGMESSAGE}
  	@${ECHO} "because Taucs requires Metis." >> ${PKGMESSAGE}
 --- gmsh.diff ends here ---
 -- 
 Th. Thomas.

From: Stephen Montgomery-Smith <stephen@missouri.edu>
To: Thierry Thomas <thierry@FreeBSD.org>
Cc: "FreeBSD-gnats-submit@freebsd.org" <FreeBSD-gnats-submit@FreeBSD.org>,
        Tong LIU <nemoliu@FreeBSD.org>
Subject: Re: ports/143820: cad/gmsh: don't depend on TAUCS by default to unbreak
 Code_Aster
Date: Fri, 12 Feb 2010 16:14:10 -0600

 Thierry Thomas wrote:
 > On Thu 11 feb 10 at 21:33:15 +0100, Stephen Montgomery-Smith<stephen@missouri.edu>
 >   wrote:
 >
 >> I have absolutely no problem with making gmsh not install TAUCS by
 >> default.  I only put it in because it was possible.  I don't use it myself.
 >>
 >> The patch isn't quite right - you will have to change WITHOUT_TAUCS to
 >> WITH_TAUCS in a few other places, mostly error checking, messages,
 >> comments and such like.  Please think through the logic when you make
 >> the changes - it isn't hard, but a simple s/WITHOUT_TAUCS/WITH_TAUCS/
 >> isn't going to suffice.
 >
 > Sorry, I just reverted commit 1.82...
 >
 > Please check the attached one:
 >
 
 Looks good except:
 
 
 > -.if !defined(WITHOUT_TAUCS)
 > -	@${ECHO_MSG} "Define WITHOUT_TAUCS to disable the Taucs linear algebra solver."
 > +.if defined(WITH_TAUCS)
 > +	@${ECHO_MSG} "Define WITH_TAUCS to enable the Taucs linear algebra solver."
 >   	@${ECHO_MSG} ""
 >   .endif
 
 this should be "!defined(WITH_TAUCS)".
 
State-Changed-From-To: feedback->closed 
State-Changed-By: thierry 
State-Changed-When: Sam 13 fv 2010 08:27:23 UTC 
State-Changed-Why:  

Feedback received, thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=143820 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143820: commit references a PR
Date: Sat, 13 Feb 2010 08:26:55 +0000 (UTC)

 thierry     2010-02-13 08:26:46 UTC
 
   FreeBSD ports repository
 
   Modified files:
     cad/gmsh             Makefile 
   Log:
   Do not depend on TAUCS by default, to unbreak Code_Aster.
   
   PR:             ports/143820
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.86      +7 -7      ports/cad/gmsh/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
