From nobody@FreeBSD.org  Mon Feb  8 22:55:10 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 64CE31065672
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Feb 2010 22:55:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 550908FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Feb 2010 22:55:10 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o18MtAkX069920
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 8 Feb 2010 22:55:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o18Mt9K3069919;
	Mon, 8 Feb 2010 22:55:09 GMT
	(envelope-from nobody)
Message-Id: <201002082255.o18Mt9K3069919@www.freebsd.org>
Date: Mon, 8 Feb 2010 22:55:09 GMT
From: Stef Walter <stef@memberwebs.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: git depends on iconv even when ICONV option not selected
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143683
>Category:       ports
>Synopsis:       devel/git depends on iconv even when ICONV option not selected
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 08 23:00:10 UTC 2010
>Closed-Date:    Sun Feb 14 17:06:35 UTC 2010
>Last-Modified:  Sun Feb 14 17:10:01 UTC 2010
>Originator:     Stef Walter
>Release:        7.2-RELEASE
>Organization:
>Environment:
FreeBSD 7orient.ws.local 7.2-RELEASE FreeBSD 7.2-RELEASE-p4 #2: Sat Oct  3 02:36:12 UTC 2009     root@dev-test2.ws.local:/usr/obj/usr/src/sys/DEVTEST2  amd64

>Description:
Recent versions of git started depending on libiconv, even when the ICON build option is not selected. For example git-1.6.6.1

This is because the git Makefile sets NEEDS_LIBICONV if uname contains FreeBSD.
>How-To-Repeat:
Build devel/git port without the ICONV option. Then:

$ ldd /usr/local/bin/git
>Fix:
Attaching a patch

Patch attached with submission follows:

--- ./Makefile.orig	2010-02-08 22:42:55.000000000 +0000
+++ ./Makefile	2010-02-08 22:43:15.000000000 +0000
@@ -824,5 +824,4 @@
 endif
 ifeq ($(uname_S),FreeBSD)
-	NEEDS_LIBICONV = YesPlease
 	OLD_ICONV = YesPlease
 	NO_MEMMEM = YesPlease


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Feb 9 00:47:14 UTC 2010 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143683 
State-Changed-From-To: open->closed 
State-Changed-By: wxs 
State-Changed-When: Sun Feb 14 17:06:34 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143683 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143683: commit references a PR
Date: Sun, 14 Feb 2010 17:06:14 +0000 (UTC)

 wxs         2010-02-14 17:06:00 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/git            Makefile distinfo pkg-plist 
     devel/git/files      git_daemon.in 
   Log:
   - Update to 1.6.6.2
   - Switch to including bsd.port.options.mk
   - Don't link with libiconv when the option is not selected [1]
   - Add --reuseaddr to git_daemon_flags [2]
   
   PR:             [1]: ports/143683
                   [2]: ports/143275
   Submitted by:   [1]: Stef Walter <stef@memberwebs.com>
                   [2]: Philippe Pepiot <phil@philpep.org>
   
   Revision  Changes    Path
   1.77      +3 -3      ports/devel/git/Makefile
   1.51      +9 -9      ports/devel/git/distinfo
   1.3       +2 -2      ports/devel/git/files/git_daemon.in
   1.48      +1 -0      ports/devel/git/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
