From nobody@FreeBSD.org  Mon Feb  8 11:26:47 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 430A9106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Feb 2010 11:26:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 339028FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Feb 2010 11:26:47 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o18BQkCh040254
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 8 Feb 2010 11:26:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o18BQk7B040253;
	Mon, 8 Feb 2010 11:26:46 GMT
	(envelope-from nobody)
Message-Id: <201002081126.o18BQk7B040253@www.freebsd.org>
Date: Mon, 8 Feb 2010 11:26:46 GMT
From: Alexander Best <alexbestms@wwu.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] ignore building ports-mgmt/portbrowser under * =! FreeBSD 5
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143667
>Category:       ports
>Synopsis:       [patch] ignore building ports-mgmt/portbrowser under * =! FreeBSD 5
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    hrs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 08 11:30:06 UTC 2010
>Closed-Date:    Tue Feb 16 21:31:01 UTC 2010
>Last-Modified:  Wed Feb 17 21:40:05 UTC 2010
>Originator:     Alexander Best
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD otaku 9.0-CURRENT FreeBSD 9.0-CURRENT #14 r203556M: Sun Feb  7 16:32:35 CET 2010     root@otaku:/usr/obj/usr/src/sys/ARUNDEL  amd64
>Description:
ports-mgmt/portbrowser doesn't work on * =! FreeBSD5.

cheers.
alex
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN /usr/ports/ports-mgmt/portbrowser/Makefile portbrowser/Makefile
--- /usr/ports/ports-mgmt/portbrowser/Makefile	2009-12-29 11:25:53.000000000 +0100
+++ portbrowser/Makefile	2010-02-08 03:03:17.000000000 +0100
@@ -6,7 +6,7 @@
 
 PORTNAME=	portbrowser
 PORTVERSION=	0.5.20050618
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	ports-mgmt
 MASTER_SITES=	${MASTER_SITE_LOCAL}
 MASTER_SITE_SUBDIR=	hrs
@@ -17,10 +17,16 @@
 COMMENT=	Graphical frontend for the BSD ports system
 
 USE_GNOME=	gtk20
+.include <bsd.port.pre.mk>
+
+.if ${OSREL} < 5 || ${OSREL} > 5
+IGNORE=		is limited to FreeBSD 5
+.endif
+
 MAKE_ENV=	MANDIR=${PREFIX}/man/man \
 		BINDIR=${PREFIX}/bin \
 		NO_MANCOMPRESS=YES
-CFLAGS+= 	-DINDEXFILE=\\\"${PORTSDIR}/${INDEXFILE}\\\" \
+CFLAGS+=	-DINDEXFILE=\\\"${PORTSDIR}/${INDEXFILE}\\\" \
 		-DPORTS_DIR=\\\"${PORTSDIR}\\\"
 PLIST_FILES=	bin/pbrowser
 
@@ -30,4 +36,4 @@
 	@${REINPLACE_CMD} 's|gram-obsd.y|gram-fbsd.y|' \
 		${WRKSRC}/src/Makefile
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->hrs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Feb 8 11:30:21 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143667 

From: Mark Linimon <linimon@lonesome.com>
To: Alexander Best <alexbestms@wwu.de>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/143667: [patch] ignore building ports-mgmt/portbrowser
	under * =! FreeBSD 5
Date: Tue, 9 Feb 2010 01:13:52 -0600

 RELENG_5 went EOL on 05/31/2008.  If no one has noticed that the port
 has been broken in the last 20 months, IMHO it should just be deleted.
 
 mcl

From: Alexander Best <alexbestms@wwu.de>
To: <bug-followup@FreeBSD.org>
Cc: <hrs@FreeBSD.org>,
 Mark Linimon <linimon@lonesome.com>
Subject: Re: ports/143667: [patch] ignore building ports-mgmt/portbrowser
 under * =! FreeBSD 5
Date: Tue, 09 Feb 2010 13:03:54 +0100 (CET)

 mark's probably right. i doubt this port is being used by a lot of people
 anyway so moving it into the attic won't be a huge loss.
 
 also fixing the port to work with anything else apart from FreeBSD 5 will
 require some work. i tried linking INDEX-5 to INDEX-8 and that made pbrowser
 segfault. probably the INDEX format changed somewhere between FreeBSD 5 and 8.
 
 so it's +1 for removing the port.
 
 cheers.
 alex
State-Changed-From-To: open->closed 
State-Changed-By: hrs 
State-Changed-When: Tue Feb 16 21:29:41 UTC 2010 
State-Changed-Why:  
Sorry for the delay but removed from the ports tree.  Thank you for the report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143667 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143667: commit references a PR
Date: Tue, 16 Feb 2010 21:29:32 +0000 (UTC)

 hrs         2010-02-16 21:29:18 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ports-mgmt           Makefile 
   Removed files:
     ports-mgmt/portbrowser Makefile distinfo pkg-descr 
     ports-mgmt/portbrowser/files patch-src-pkgobject.h 
   Log:
   Remove ports-mgmt/portbrowser.  It is no longer actively maintained and
   broken for years.
   
   Feature safe:   yes
   PR:     ports/143667
   
   Revision  Changes    Path
   1.29      +0 -1      ports/ports-mgmt/Makefile
   1.15      +0 -33     ports/ports-mgmt/portbrowser/Makefile (dead)
   1.5       +0 -3      ports/ports-mgmt/portbrowser/distinfo (dead)
   1.2       +0 -19     ports/ports-mgmt/portbrowser/files/patch-src-pkgobject.h (dead)
   1.2       +0 -4      ports/ports-mgmt/portbrowser/pkg-descr (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Andriy Gapon <avg@icyb.net.ua>
To: bug-followup@FreeBSD.org, hrs@FreeBSD.org
Cc:  
Subject: Re: ports/143667: [patch] ignore building ports-mgmt/portbrowser
 under * =! FreeBSD 5
Date: Wed, 17 Feb 2010 16:10:03 +0200

 Perhaps, an entry in MOVED, just in case?
 
 -- 
 Andriy Gapon

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143667: commit references a PR
Date: Wed, 17 Feb 2010 21:36:39 +0000 (UTC)

 hrs         2010-02-17 21:36:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     .                    MOVED 
   Log:
   Add entry of ports-mgmt/portbrowser removal forgotten when the change
   was committed.
   
   Spotted by:     Andriy Gapon
   PR:             ports/143667
   Feature safe:   yes
   
   Revision  Changes    Path
   1.2094    +2 -1      ports/MOVED
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
