From nobody@FreeBSD.org  Thu Feb  4 21:06:45 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B435C1065676
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  4 Feb 2010 21:06:45 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 973E18FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  4 Feb 2010 21:06:45 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o14L6jgA039786
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 4 Feb 2010 21:06:45 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o14L6isr039785;
	Thu, 4 Feb 2010 21:06:44 GMT
	(envelope-from nobody)
Message-Id: <201002042106.o14L6isr039785@www.freebsd.org>
Date: Thu, 4 Feb 2010 21:06:44 GMT
From: Sergey Prikhodko <sergey@network-asp.biz>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [update] www/mod_fcgid to 2.3.5
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: hemi@puresimplicity.net

>Number:         143563
>Category:       ports
>Synopsis:       [update] www/mod_fcgid to 2.3.5
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 04 21:10:01 UTC 2010
>Closed-Date:    Fri Feb 05 04:10:47 UTC 2010
>Last-Modified:  Fri Feb  5 04:20:07 UTC 2010
>Originator:     Sergey Prikhodko
>Release:        7.2-RELEASE-p4
>Organization:
Network-ASP
>Environment:
FreeBSD travel.office.network-asp.biz 7.2-RELEASE-p4 FreeBSD 7.2-RELEASE-p4 #5 r198093M: Wed Oct 14 21:31:25 EEST 2009     toor@travel.office.network-asp.biz:/usr/obj/usr/src/sys/FABRICA64  amd64

>Description:
update to 2.3.5

Current version in ports has critical bug with large form uploads.

- supercedes ports/143458 and ports/143435
- added patch from http://svn.apache.org/viewvc?view=revision&revision=905302 (fixes incorrect mutex permissions)

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ruN mod_fcgid.orig/Makefile mod_fcgid/Makefile
--- mod_fcgid.orig/Makefile	2009-12-26 08:55:18.000000000 +0200
+++ mod_fcgid/Makefile	2010-02-01 14:27:23.000000000 +0200
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	mod_fcgid
-PORTVERSION=	2.3.4
+PORTVERSION=	2.3.5
 CATEGORIES=	www
 MASTER_SITES=		${MASTER_SITE_APACHE_HTTPD}
 MASTER_SITE_SUBDIR=	${PORTNAME}
diff -ruN mod_fcgid.orig/distinfo mod_fcgid/distinfo
--- mod_fcgid.orig/distinfo	2009-12-26 08:55:18.000000000 +0200
+++ mod_fcgid/distinfo	2010-02-01 14:27:27.000000000 +0200
@@ -1,3 +1,3 @@
-MD5 (mod_fcgid-2.3.4.tar.gz) = 3778c0710ae4d750d87dddee70990681
-SHA256 (mod_fcgid-2.3.4.tar.gz) = 139cb06f766fac2bb2ad583272b5e786316f4b935e072256b6f45cecd8b6df1b
-SIZE (mod_fcgid-2.3.4.tar.gz) = 94417
+MD5 (mod_fcgid-2.3.5.tar.gz) = 82b5bec1ed1c0fc106d5271075641ef9
+SHA256 (mod_fcgid-2.3.5.tar.gz) = 3280fd287659539d577fc3c77a975739c06bb9d0a9cef48275d4beb13c64ef39
+SIZE (mod_fcgid-2.3.5.tar.gz) = 97784
diff -ruN mod_fcgid.orig/files/patch-modules-fcgid-fcgid_conf.c mod_fcgid/files/patch-modules-fcgid-fcgid_conf.c
--- mod_fcgid.orig/files/patch-modules-fcgid-fcgid_conf.c	2009-12-26 08:55:19.000000000 +0200
+++ mod_fcgid/files/patch-modules-fcgid-fcgid_conf.c	1970-01-01 03:00:00.000000000 +0300
@@ -1,13 +0,0 @@
---- modules/fcgid/fcgid_conf.c.orig	2009-10-07 05:16:08.000000000 +0200
-+++ modules/fcgid/fcgid_conf.c	2009-12-11 16:18:09.000000000 +0100
-@@ -35,8 +35,8 @@
- #define DEFAULT_ERROR_SCAN_INTERVAL 3
- #define DEFAULT_ZOMBIE_SCAN_INTERVAL 3
- #define DEFAULT_PROC_LIFETIME (60*60)
--#define DEFAULT_SOCKET_PREFIX "logs/fcgidsock"
--#define DEFAULT_SHM_PATH "logs/fcgid_shm"
-+#define DEFAULT_SOCKET_PREFIX "/var/run/fcgidsock"
-+#define DEFAULT_SHM_PATH "/var/run/fcgid_shm"
- #define DEFAULT_SPAWNSOCRE_UPLIMIT 10
- #define DEFAULT_SPAWN_SCORE 1
- #define DEFAULT_TERMINATION_SCORE 2
diff -ruN mod_fcgid.orig/files/patch-modules-fcgid-fcgid_mutex_unix.c mod_fcgid/files/patch-modules-fcgid-fcgid_mutex_unix.c
--- mod_fcgid.orig/files/patch-modules-fcgid-fcgid_mutex_unix.c	1970-01-01 03:00:00.000000000 +0300
+++ mod_fcgid/files/patch-modules-fcgid-fcgid_mutex_unix.c	2010-02-04 22:54:43.000000000 +0200
@@ -0,0 +1,17 @@
+Index: modules/fcgid/fcgid_mutex_unix.c
+===================================================================
+--- modules/fcgid/fcgid_mutex_unix.c    (revision 904780)
++++ modules/fcgid/fcgid_mutex_unix.c    (working copy)
+@@ -56,6 +56,10 @@
+
+ #include "ap_mpm.h"
+
++#if MODULE_MAGIC_NUMBER_MAJOR < 20051115
++#define AP_NEED_SET_MUTEX_PERMS 1
++#endif
++
+ #if AP_NEED_SET_MUTEX_PERMS
+ #include "unixd.h"
+ #endif
+
+


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Feb 4 21:10:11 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143563 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: hemi@puresimplicity.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/143563: [update] www/mod_fcgid to 2.3.5
Date: Thu, 4 Feb 2010 21:10:09 UT

 Maintainer of www/mod_fcgid,
 
 Please note that PR ports/143563 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143563
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Thu Feb 4 23:49:21 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143563 
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Fri Feb 5 03:42:18 UTC 2010 
State-Changed-Why:  
maintainer has yet to comment on last 5 prs, calling a timeout 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143563 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Fri Feb 5 04:10:46 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143563 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143563: commit references a PR
Date: Fri,  5 Feb 2010 04:10:34 +0000 (UTC)

 pgollucci    2010-02-05 04:10:24 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/mod_fcgid        Makefile distinfo 
   Added files:
     www/mod_fcgid/files  patch-modules-fcgid-fcgid_mutex_unix.c 
   Removed files:
     www/mod_fcgid/files  patch-modules-fcgid-fcgid_conf.c 
   Log:
   - Update 2.3.5 [1]
   - added patch from http://svn.apache.org/viewvc?view=revision&revision=905302  [1]
     (fixes incorrect mutex permissions)
   
   PR:             142795 [2], 143435 [3], 143458 [3], 143563 [1]
   Submitted by:   Sergey Prikhodko <sergey@network-asp.biz>
   Approved by:    maintainer timeout (hemi@puresimplicity.net; 22 days [2])
                   no response from maintainer [3]
   
   Revision  Changes    Path
   1.19      +1 -1      ports/www/mod_fcgid/Makefile
   1.10      +3 -3      ports/www/mod_fcgid/distinfo
   1.2       +0 -13     ports/www/mod_fcgid/files/patch-modules-fcgid-fcgid_conf.c (dead)
   1.1       +17 -0     ports/www/mod_fcgid/files/patch-modules-fcgid-fcgid_mutex_unix.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
