From marck@woozle.rinet.ru  Thu Feb  4 11:00:25 2010
Return-Path: <marck@woozle.rinet.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0C0EB10656C3
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Feb 2010 11:00:25 +0000 (UTC)
	(envelope-from marck@woozle.rinet.ru)
Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 898298FC1A
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  4 Feb 2010 11:00:23 +0000 (UTC)
Received: from woozle.rinet.ru (localhost [127.0.0.1])
	by woozle.rinet.ru (8.14.3/8.14.3) with ESMTP id o14B0MOo002323
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 4 Feb 2010 14:00:22 +0300 (MSK)
	(envelope-from marck@woozle.rinet.ru)
Received: (from marck@localhost)
	by woozle.rinet.ru (8.14.3/8.14.3/Submit) id o14B0MX7002322;
	Thu, 4 Feb 2010 14:00:22 +0300 (MSK)
	(envelope-from marck)
Message-Id: <201002041100.o14B0MX7002322@woozle.rinet.ru>
Date: Thu, 4 Feb 2010 14:00:22 +0300 (MSK)
From: Dmitry Morozovsky <marck@freebsd.org>
Reply-To: Dmitry Morozovsky <marck@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: sysutils/smartmontools: fix daily periodic script
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         143551
>Category:       ports
>Synopsis:       sysutils/smartmontools: fix daily periodic script
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 04 11:10:02 UTC 2010
>Closed-Date:    Thu Feb 04 13:39:16 UTC 2010
>Last-Modified:  Thu Feb 04 13:39:16 UTC 2010
>Originator:     Dmitry Morozovsky
>Release:        FreeBSD 7-STABLE i386
>Organization:
Cronyx Plus LLC (RiNet ISP)
>Environment:
System: FreeBSD 7-STABLE 


>Description:

smartmontools' smartctl no more works with device name without full path, hence
FreeBSD periodic script is non-workable.

>How-To-Repeat:

>Fix:


Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/sysutils/smartmontools/Makefile,v
retrieving revision 1.45
diff -u -r1.45 Makefile
--- Makefile	23 Dec 2009 18:55:52 -0000	1.45
+++ Makefile	4 Feb 2010 10:58:07 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	smartmontools
 PORTVERSION=	5.39
+PORTREVISION=	1
 CATEGORIES=	sysutils
 MASTER_SITES=	SF
 
Index: files/smart.in
===================================================================
RCS file: /home/ncvs/ports/sysutils/smartmontools/files/smart.in,v
retrieving revision 1.5
diff -u -r1.5 smart.in
--- files/smart.in	3 Jun 2009 18:12:30 -0000	1.5
+++ files/smart.in	4 Feb 2010 10:58:07 -0000
@@ -41,7 +41,7 @@
 				echo 
 				echo "Checking health of ${device}:"
 				echo
-				${smartctl} ${daily_status_smartctl_flags} ${device} > "${tmpfile}"
+				${smartctl} ${daily_status_smartctl_flags} /dev/${device} > "${tmpfile}"
 				status=$?
 				if [ $((status & 3)) -ne 0 ]; then
 					rc=2
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->marck 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Feb 4 11:10:16 UTC 2010 
Responsible-Changed-Why:  
Submitter is maintainer and has GNATS access (via the GNATS Auto Assign 
Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143551 
Responsible-Changed-From-To: marck->freebsd-ports-bugs 
Responsible-Changed-By: marck 
Responsible-Changed-When: Thu Feb 4 11:49:39 UTC 2010 
Responsible-Changed-Why:  
Maintainer approval, please commit. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=143551 
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Thu Feb 4 13:21:15 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143551 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143551: commit references a PR
Date: Thu,  4 Feb 2010 13:22:08 +0000 (UTC)

 amdmi3      2010-02-04 13:22:00 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/smartmontools Makefile 
     sysutils/smartmontools/files smart.in 
   Log:
   - Fix periodic script
   
   PR:             143551
   Submitted by:   marck (maintainer)
   
   Revision  Changes    Path
   1.46      +1 -0      ports/sysutils/smartmontools/Makefile
   1.6       +2 -2      ports/sysutils/smartmontools/files/smart.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: amdmi3 
State-Changed-When: Thu Feb 4 13:39:16 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143551 
>Unformatted:
