From nobody@FreeBSD.org  Thu Feb  4 03:35:10 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A06E9106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  4 Feb 2010 03:35:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 8FC3C8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  4 Feb 2010 03:35:10 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o143ZAUP008697
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 4 Feb 2010 03:35:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o143ZAE1008696;
	Thu, 4 Feb 2010 03:35:10 GMT
	(envelope-from nobody)
Message-Id: <201002040335.o143ZAE1008696@www.freebsd.org>
Date: Thu, 4 Feb 2010 03:35:10 GMT
From: Ryan Steinmetz <rpsfa@rit.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Modification to net/quagga to add an option to disable BGP announcement
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: boris@tagnet.ru

>Number:         143538
>Category:       ports
>Synopsis:       Modification to net/quagga to add an option to disable BGP announcement
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 04 03:40:01 UTC 2010
>Closed-Date:    Sun Feb 14 17:16:12 UTC 2010
>Last-Modified:  Sun Feb 14 17:16:12 UTC 2010
>Originator:     Ryan Steinmetz
>Release:        FreeBSD 7.2
>Organization:
Rochester Institute of Technology
>Environment:
FreeBSD XXX.rit.edu 7.2-RELEASE-p4 FreeBSD 7.2-RELEASE-p4 #5: Fri Oct 2 21:03:59 EDT 2009 root@XXX.rit.edu:/usr/obj/usr/src/sys/XXX i386
>Description:
Add a config knob to disable BGP announcements.  This is useful if you plan to use quagga as a route-views server or the like.

PORTVERSION has not been bumped as this is an extremely minor change to the port.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- /usr/ports/net/quagga/Makefile	2010-02-01 12:45:30.000000000 -0500
+++ /tmp/Makefile	2010-02-03 22:19:25.000000000 -0500
@@ -40,7 +40,8 @@
 		RTADV		"IPv6 Router Advertisements"	off \
 		SNMP		"SNMP support"			off \
 		TCPSOCKETS	"Use TCP/IP sockets for protocol daemons" off \
-		DLMALLOC	"Use dlmalloc (makes bgpd much faster)" off
+		DLMALLOC	"Use dlmalloc (makes bgpd much faster)" off \
+		NO_BGP_ANNOUNCE	"Turn off BGP route announcement" off
 
 .include <bsd.port.pre.mk>
 
@@ -124,6 +125,10 @@
 SUB_LIST=	RCLDCONFIG=
 .endif
 
+.if defined(WITH_NO_BGP_ANNOUNCE)
+CONFIGURE_ARGS+=--disable-bgp-announce
+.endif
+
 USE_RC_SUBR=	quagga.sh watchquagga.sh
 
 SUB_LIST+=	LOCALSTATE_DIR=${LOCALSTATE_DIR} \
@@ -153,6 +158,7 @@
 	@${ECHO} "   WITH_SNMP             SNMP support"
 	@${ECHO} "   WITH_TCPSOCKETS       Use TCP/IP sockets for protocol daemons"
 	@${ECHO} "   WITH_DLMALLOC         Use dlmalloc (makes bgpd much faster)"
+	@${ECHO} "   WITH_NO_BGP_ANNOUNCE  Turn off BGP route announcement"
 
 post-install:
 	@${SETENV} ${SCRIPTS_ENV} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Feb 4 03:40:11 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143538 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: boris@tagnet.ru
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/143538: Modification to net/quagga to add an option to disable BGP announcement
Date: Thu, 4 Feb 2010 03:40:09 UT

 Maintainer of net/quagga,
 
 Please note that PR ports/143538 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143538
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Boris Kovalenko <boris@tagnet.ru>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143538: Modification to net/quagga to add an option to
 disable BGP announcement
Date: Thu, 04 Feb 2010 09:14:06 +0500

 Hello!
 
     Agreed.
 > Maintainer of net/quagga,
 >
 > Please note that PR ports/143538 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143538
 >
 >   
 
 
 -- 
 Regards,
 	Boris
 
 
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Wed Feb 10 20:30:02 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143538 
State-Changed-From-To: feedback->closed 
State-Changed-By: wxs 
State-Changed-When: Sun Feb 14 17:16:10 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143538 
>Unformatted:
