From i@levsha.me  Wed Feb  3 17:00:04 2010
Return-Path: <i@levsha.me>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 173641065747
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  3 Feb 2010 17:00:04 +0000 (UTC)
	(envelope-from i@levsha.me)
Received: from expo.ukrweb.net (mail.univua.net [91.202.128.78])
	by mx1.freebsd.org (Postfix) with ESMTP id 57D7C8FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  3 Feb 2010 17:00:03 +0000 (UTC)
Received: from [91.193.166.194] (helo=laptop.levsha.me)
	by expo.ukrweb.net with esmtpsa (TLSv1:AES256-SHA:256)
	(Exim 4.71 (FreeBSD))
	(envelope-from <i@levsha.me>)
	id 1Ncia7-0008u4-Rp
	for FreeBSD-gnats-submit@freebsd.org; Wed, 03 Feb 2010 19:00:02 +0200
Received: from levsha by laptop.levsha.me with local (Exim 4.71 (FreeBSD))
	(envelope-from <i@levsha.me>)
	id 1Ncia7-000AH4-MV
	for FreeBSD-gnats-submit@freebsd.org; Wed, 03 Feb 2010 18:59:59 +0200
Message-Id: <E1Ncia7-000AH4-MV@laptop.levsha.me>
Date: Wed, 03 Feb 2010 18:59:59 +0200
From: Mykola Dzham <i@levsha.me>
Sender: Mykola Dzham <i@levsha.me>
Reply-To: Mykola Dzham <i@levsha.me>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] audio/icecast2: incorrect BEFORE: in startup script
X-Send-Pr-Version: 3.113
X-GNATS-Notify: sunpoet@sunpoet.net

>Number:         143532
>Category:       ports
>Synopsis:       [patch] audio/icecast2: incorrect BEFORE: in startup script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 03 17:10:01 UTC 2010
>Closed-Date:    Fri Feb 12 10:43:30 UTC 2010
>Last-Modified:  Fri Feb 12 10:50:00 UTC 2010
>Originator:     Mykola Dzham
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
System: FreeBSD laptop.levsha.me 9.0-CURRENT FreeBSD 9.0-CURRENT #1 r202552M: Sat Jan 30 01:43:23 EET 2010 root@laptop.levsha.me:/usr/local/arch/obj/usr/local/arch/src/sys/LEVSHA amd64

>Description:
audio/icecast2 contains line 
# BEFORE:  login
in icecast2.sh.in , but correct rc.d script name is LOGIN
>How-To-Repeat:
rcorder /etc/rc.d/* /usr/local/etc/rc.d/* > /dev/null

>Fix:

Index: files/icecast2.sh.in
===================================================================
RCS file: /usr/local/arch/csup/ports/audio/icecast2/files/icecast2.sh.in,v
retrieving revision 1.4
diff -u -r1.4 icecast2.sh.in
--- files/icecast2.sh.in	3 Aug 2006 20:39:08 -0000	1.4
+++ files/icecast2.sh.in	3 Feb 2010 16:55:50 -0000
@@ -5,7 +5,7 @@
 
 # PROVIDE: icecast2
 # REQUIRE: DAEMON
-# BEFORE:  login
+# BEFORE:  LOGIN
 # KEYWORD: shutdown
 
 # Add the following line to /etc/rc.conf to enable `icecast2'. This requires

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Feb 3 17:10:10 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143532 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: sunpoet@sunpoet.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/143532: [patch] audio/icecast2: incorrect BEFORE: in startup script
Date: Wed, 3 Feb 2010 17:10:09 UT

 Maintainer of audio/icecast2,
 
 Please note that PR ports/143532 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143532
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Sunpoet Hsieh <sunpoet@sunpoet.net>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/143532: [patch] audio/icecast2: incorrect BEFORE: in 
	startup script
Date: Thu, 4 Feb 2010 23:25:50 +0800

 Hi,
 
 maintainer approved.
 thanks.
 
 BR,
 Sunpoet
 
 On Thu, Feb 4, 2010 at 1:10 AM, Edwin Groothuis <edwin@freebsd.org> wrote:
 > Maintainer of audio/icecast2,
 >
 > Please note that PR ports/143532 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 > =C2=A0 =C2=A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/143532
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Thu Feb 4 20:12:58 UTC 2010 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143532 
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Fri Feb 12 10:37:56 UTC 2010 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143532 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143532: commit references a PR
Date: Fri, 12 Feb 2010 10:44:10 +0000 (UTC)

 pav         2010-02-12 10:43:15 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/icecast2       Makefile 
     audio/icecast2/files icecast2.sh.in 
   Log:
   - Correct login/LOGIN in rc script
   - Minor cleanup
   
   PR:             ports/143532
   Submitted by:   Mykola Dzham <i@levsha.me>
   Approved by:    Sunpoet Hsieh <sunpoet@sunpoet.net> (maintainer)
   
   Revision  Changes    Path
   1.63      +1 -2      ports/audio/icecast2/Makefile
   1.5       +2 -2      ports/audio/icecast2/files/icecast2.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
