From cy@cschuber.net.gov.bc.ca Wed Oct 13 19:38:01 1999
Return-Path: <cy@cschuber.net.gov.bc.ca>
Received: from point.osg.gov.bc.ca (point.osg.gov.bc.ca [142.32.102.44])
	by hub.freebsd.org (Postfix) with ESMTP id 2551F14DF6
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Oct 1999 19:38:00 -0700 (PDT)
	(envelope-from cy@cschuber.net.gov.bc.ca)
Received: (from daemon@localhost)
	by point.osg.gov.bc.ca (8.8.7/8.8.8) id TAA15483
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 13 Oct 1999 19:38:00 -0700
Received: from cschuber.net.gov.bc.ca(142.31.240.113), claiming to be "cwsys.cwsent.com"
 via SMTP by point.osg.gov.bc.ca, id smtpda15481; Wed Oct 13 19:37:43 1999
Received: (from cy@localhost)
	by cwsys.cwsent.com (8.9.3/8.9.1) id TAA07611;
	Wed, 13 Oct 1999 19:37:41 -0700 (PDT)
Message-Id: <199910140237.TAA07611@cwsys.cwsent.com>
Date: Wed, 13 Oct 1999 19:37:41 -0700 (PDT)
From: Cy.Schubert@uumail.gov.bc.ca
Sender: cy@cschuber.net.gov.bc.ca
Reply-To: Cy.Schubert@uumail.gov.bc.ca
To: FreeBSD-gnats-submit@freebsd.org
Subject: fix to various exmh2 problems
X-Send-Pr-Version: 3.2

>Number:         14316
>Category:       ports
>Synopsis:       exmh not recognizing mh and uses too many colours
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bmah
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 13 19:40:01 PDT 1999
>Closed-Date:    Fri Jul 27 18:14:57 PDT 2001
>Last-Modified:  Fri Jul 27 18:16:20 PDT 2001
>Originator:     Cy Schubert
>Release:        FreeBSD 3.3-RELEASE i386
>Organization:
ITSD Province of BC
>Environment:

FreeBSD cwsys 3.3-RELEASE FreeBSD 3.3-RELEASE #0: Wed Oct 13 08:09:56 PDT 1999     root@cwsys:/opt2/cvs-330/src/sys/compile/CWSYS  i386

>Description:

The enclosed patches to the exmh2 port fix the following problems.

1.  Exmh2 does not detect MH 6.8.4

2.  Exmh2 icon uses too many colours on an 8 bit display.

Reasons:

I use exmh2 with MH 6.8.4.

I use exmh2 on three FreeBSD systems, two with 16 bit displays and one
with an 8 bit display.  The colour icon uses too many colours causing
other apps to display in black & white.

A copy of this PR has been sent to the maintainer of Exmh, welch@acm.org,
and hopefully he'll incorporate these patches into the base product.
Until then, might it be possible to include these patches?

>How-To-Repeat:

Use exmh2 on a system with MH 6.8.4 installed.

Use exmh2 on an 8 bit display.

>Fix:
	
The following patch properly detects if MH 6.8.4 is installed.  It
also detects whether an X server is using an 8 bit or 16 bit (or higer)
display.

diff -urPN /opt/CVSup/usr/ports/mail/exmh2/patches/patch-ca exmh2-991013/patches/patch-ca
--- /opt/CVSup/usr/ports/mail/exmh2/patches/patch-ca	Wed Dec 31 16:00:00 1969
+++ exmh2-991013/patches/patch-ca	Wed Oct 13 19:15:51 1999
@@ -0,0 +1,11 @@
+--- lib/main.tcl.orig	Wed Oct 13 06:55:20 1999
++++ lib/main.tcl	Wed Oct 13 07:39:23 1999
+@@ -14,7 +14,7 @@
+ proc Exmh {} {
+     global exmh argv nmh
+ 
+-    if ![ catch {string match *-group* [exec repl -help] } ] {
++    if [ string match *-group* [exec repl -help] ] {
+ 	set nmh 1
+     } else {
+ 	set nmh 0
diff -urPN /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cb exmh2-991013/patches/patch-cb
--- /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cb	Wed Dec 31 16:00:00 1969
+++ exmh2-991013/patches/patch-cb	Wed Oct 13 19:16:32 1999
@@ -0,0 +1,22 @@
+--- lib/main.tcl.ORIG	Wed Oct 13 07:39:23 1999
++++ lib/main.tcl	Wed Oct 13 17:56:01 1999
+@@ -12,12 +12,18 @@
+ # any specification.
+ 
+ proc Exmh {} {
+-    global exmh argv nmh
++    global exmh argv nmh planes
+ 
+     if [ string match *-group* [exec repl -help] ] {
+ 	set nmh 1
+     } else {
+ 	set nmh 0
++    }
++
++    if [ string match *depth\ of\ root\ window:\ \ \ \ 8\ planes* [exec xdpyinfo] ] {
++	set planes 8
++    } else {
++	set planes 0
+     }
+ 
+     Mh_Init		;# Defines mhProfile
diff -urPN /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cc exmh2-991013/patches/patch-cc
--- /opt/CVSup/usr/ports/mail/exmh2/patches/patch-cc	Wed Dec 31 16:00:00 1969
+++ exmh2-991013/patches/patch-cc	Wed Oct 13 18:09:37 1999
@@ -0,0 +1,20 @@
+--- lib/flag.tcl.orig	Wed Oct 13 06:55:20 1999
++++ lib/flag.tcl	Wed Oct 13 17:57:21 1999
+@@ -24,7 +24,7 @@
+ # any specification.
+ 
+ proc Flag_Init {} {
+-    global flag exmh
++    global flag exmh planes
+     set flag(state) init
+     
+     # Note - if you change the icon, there is some code in ExmhArgv
+@@ -50,7 +50,7 @@
+ 	    set flag($i) 0
+ 	}
+     }
+-    if {!$exmh(slowDisp) || $exmh(slowDispIcons)} {
++    if {(!$exmh(slowDisp) || $exmh(slowDispIcons)) && $planes != 8} {
+ 	if [catch {
+ 	    Exmh_Debug "Creating .icon"
+ 	    toplevel .icon

>Release-Note:
>Audit-Trail:

From: bmah@CA.Sandia.GOV (Bruce A. Mah)
To: Cy.Schubert@uumail.gov.bc.ca
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/14316: fix to various exmh2 problems 
Date: Thu, 14 Oct 1999 08:55:27 -0700

 What version of exmh was in the port at the time you noticed these
 problems? It looks like Peter Wemm recently commited a port for
 exmh-2.1.0, and I have this hazy recollection that we *might* have done
 some work to address both these problems.
 
 Bruce.
 
 
 

From: Cy Schubert <cschuber@uumail.gov.bc.ca>
To: bmah@CA.Sandia.GOV
Cc: Cy.Schubert@uumail.gov.bc.ca, FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/14316: fix to various exmh2 problems 
Date: Thu, 14 Oct 1999 09:35:54 -0700

 These problems are specific to 2.1.0.   2.1.0 incorporates some new 
 features, like a colour glyph, which is not desirable on 8 bit colour 
 cards, and use of the -group option of the nmh repl command.  The problems 
 do not occur in previous versions of Exmh.
 
 
 Regards,                       Phone:  (250)387-8437
 Cy Schubert                      Fax:  (250)387-5766
 Sun/DEC Team, UNIX Group    Internet:  Cy.Schubert@uumail.gov.bc.ca
 ITSD                                   Cy.Schubert@gems8.gov.bc.ca
 Province of BC            
                       "e**(i*pi)+1=0"
 
 In message <199910141555.IAA96995@nimitz.ca.sandia.gov>, Bruce A. Mah 
 writes:
 > What version of exmh was in the port at the time you noticed these
 > problems? It looks like Peter Wemm recently commited a port for
 > exmh-2.1.0, and I have this hazy recollection that we *might* have done
 > some work to address both these problems.
 > 
 > Bruce.
 > 
 > 
 
 
 
Responsible-Changed-From-To: freebsd-ports->markm  
Responsible-Changed-By: cpiazza 
Responsible-Changed-When: Fri Oct 15 20:21:35 PDT 1999 
Responsible-Changed-Why:  
Over to maintainer 
State-Changed-From-To: open->feedback 
State-Changed-By: bmah 
State-Changed-When: Thu Jul 26 20:37:11 PDT 2001 
State-Changed-Why:  
Almost two years later...I'm now the port maintainer.  Is this still 
a problem with the recently-released 2.5? 


Responsible-Changed-From-To: markm->bmah 
Responsible-Changed-By: bmah 
Responsible-Changed-When: Thu Jul 26 20:37:11 PDT 2001 
Responsible-Changed-Why:  
Now it's my port. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=14316 
State-Changed-From-To: feedback->closed 
State-Changed-By: bmah 
State-Changed-When: Fri Jul 27 18:14:57 PDT 2001 
State-Changed-Why:  
Closed by suggestion of submitter and strong agreement of responsible 
committer. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=14316 
>Unformatted:
