From nobody@FreeBSD.org  Thu Jan 21 10:17:56 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D4A2E1065693
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 Jan 2010 10:17:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id C44448FC1F
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 Jan 2010 10:17:56 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0LAHu8Z064622
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 21 Jan 2010 10:17:56 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o0LAHuGJ064621;
	Thu, 21 Jan 2010 10:17:56 GMT
	(envelope-from nobody)
Message-Id: <201001211017.o0LAHuGJ064621@www.freebsd.org>
Date: Thu, 21 Jan 2010 10:17:56 GMT
From: Frank Wall <fw@moov.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] security/denyhosts: fix $command_interpreter in RC script
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: janos.mohacsi@bsd.hu

>Number:         143053
>Category:       ports
>Synopsis:       [PATCH] security/denyhosts: fix $command_interpreter in RC script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 21 10:20:18 UTC 2010
>Closed-Date:    Mon Feb 01 17:43:31 UTC 2010
>Last-Modified:  Mon Feb  1 17:50:03 UTC 2010
>Originator:     Frank Wall
>Release:        7.1-RELEASE
>Organization:
>Environment:
FreeBSD 7.1-RELEASE-p4 FreeBSD 7.1-RELEASE-p4 #0: Sun Mar 22 09:43:46 UTC 2009     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
The RC script for security/denyhosts is outdated. The variable
$command_interpreter needs to be set to "/usr/local/bin/python2.6",
but it is set to "/usr/local/bin/python".
>How-To-Repeat:
1. install security/denyhosts
2. add denyhosts_enable="YES" to /etc/rc.conf
3. start denyhosts: /usr/local/etc/rc.d/denyhosts start
4. a warning message is shown:

/usr/local/etc/rc.d/denyhosts: WARNING: $command_interpreter /usr/local/bin/python != /usr/local/bin/python2.6

>Fix:
see attached patch file

Patch attached with submission follows:

--- files/denyhosts.in.orig	2006-05-20 01:47:45.000000000 +0200
+++ files/denyhosts.in	2010-01-21 11:11:38.000000000 +0100
@@ -12,7 +12,7 @@
 rcvar=${name}_enable
 
 command="%%PREFIX%%/bin/denyhosts.py"
-command_interpreter="/usr/local/bin/python"
+command_interpreter="/usr/local/bin/python2.6"
 command_args="--config %%PREFIX%%/etc/denyhosts.conf --daemon"
 pidfile="/var/run/${name}.pid"



>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Jan 21 10:20:28 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143053 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: janos.mohacsi@bsd.hu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/143053: [PATCH] security/denyhosts: fix $command_interpreter in RC script
Date: Thu, 21 Jan 2010 10:20:26 UT

 Maintainer of security/denyhosts,
 
 Please note that PR ports/143053 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143053
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Janos Mohacsi <mohacsi@niif.hu>
To: bug-followup@FreeBSD.org, fw@moov.de
Cc: edwin@freebsd.org
Subject: Re: ports/143053: [PATCH] security/denyhosts: fix $command_interpreter
 in RC script
Date: Fri, 22 Jan 2010 14:34:51 +0100

 This is a multi-part message in MIME format.
 --------------050506010403050007000802
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 It is more appropriate to use the current default python version instead
 of hard-coding the a particular version. See the attached patch.
 
 Best Regards,
                 Janos Mohacsi
 
 --------------050506010403050007000802
 Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0";
  name="denyhosts.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="denyhosts.diff"
 
 diff -ruN denyhosts.orig/Makefile denyhosts/Makefile
 --- denyhosts.orig/Makefile	2009-08-25 16:24:44.000000000 +0200
 +++ denyhosts/Makefile	2010-01-22 14:30:50.000000000 +0100
 @@ -7,7 +7,7 @@
  
  PORTNAME=	denyhosts
  PORTVERSION=	2.6
 -PORTREVISION=	2
 +PORTREVISION=	3
  CATEGORIES=	security
  MASTER_SITES=	SF
  DISTNAME=	DenyHosts-${PORTVERSION}
 @@ -21,6 +21,7 @@
  
  USE_RC_SUBR=	denyhosts
  SUB_FILES=	pkg-message
 +SUB_LIST=	PYTHONVER=${PYTHON_VERSION}
  
  PORTDOCS=	CHANGELOG.txt LICENSE.txt README.txt
  
 diff -ruN denyhosts.orig/files/denyhosts.in denyhosts/files/denyhosts.in
 --- denyhosts.orig/files/denyhosts.in	2006-05-20 01:47:45.000000000 +0200
 +++ denyhosts/files/denyhosts.in	2010-01-22 14:26:01.000000000 +0100
 @@ -12,7 +12,7 @@
  rcvar=${name}_enable
  
  command="%%PREFIX%%/bin/denyhosts.py"
 -command_interpreter="/usr/local/bin/python"
 +command_interpreter="/usr/local/bin/%%PYTHONVER%%"
  command_args="--config %%PREFIX%%/etc/denyhosts.conf --daemon"
  pidfile="/var/run/${name}.pid"
  
 
 --------------050506010403050007000802--
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Sat Jan 23 00:37:21 UTC 2010 
State-Changed-Why:  
Maintainer has responded with a different patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143053 
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Mon Feb 1 04:04:08 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143053 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Mon Feb 1 17:43:30 UTC 2010 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143053 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/143053: commit references a PR
Date: Mon,  1 Feb 2010 17:44:25 +0000 (UTC)

 pgollucci    2010-02-01 17:43:23 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/denyhosts   Makefile 
     security/denyhosts/files denyhosts.in 
   Log:
   - Fix command_interpreter in the rc.d script
   
   PR:             ports/143053
   Submitted by:   Frank Wall <fw@moov.de>
   Tweaked by:     Janos Mohacsi <mohacsi@niif.hu> (maintainer)
   Corrected by:   pgollucci (myself)
   
   Revision  Changes    Path
   1.13      +2 -1      ports/security/denyhosts/Makefile
   1.2       +2 -2      ports/security/denyhosts/files/denyhosts.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
