From fmysh@quad.dyndns.org  Wed Jan 20 13:34:02 2010
Return-Path: <fmysh@quad.dyndns.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B2E571065693
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Jan 2010 13:34:02 +0000 (UTC)
	(envelope-from fmysh@quad.dyndns.org)
Received: from aqua.quad.dyndns.org (unknown [IPv6:2001:240:66e::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 88E628FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Jan 2010 13:34:02 +0000 (UTC)
Received: by aqua.quad.dyndns.org (Postfix, from userid 1001)
	id 35371153444; Wed, 20 Jan 2010 22:34:01 +0900 (JST)
Message-Id: <20100120133401.35371153444@aqua.quad.dyndns.org>
Date: Wed, 20 Jan 2010 22:34:01 +0900 (JST)
From: TAOKA Fumiyoshi <fmysh@iijmio-mail.jp>
Reply-To: TAOKA Fumiyoshi <fmysh@iijmio-mail.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc: TAOKA Fumiyoshi <fmysh@iijmio-mail.jp>, Takefu <takefu@airport.fm>
Subject: mail/p5-Mail-SpamAssassin: portlint complains
X-Send-Pr-Version: 3.113
X-GNATS-Notify: scheidell@secnap.net

>Number:         143016
>Category:       ports
>Synopsis:       mail/p5-Mail-SpamAssassin: portlint complains
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    wen
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 20 13:40:08 UTC 2010
>Closed-Date:    Thu Feb 11 13:58:39 UTC 2010
>Last-Modified:  Thu Feb 11 13:58:39 UTC 2010
>Originator:     TAOKA Fumiyoshi
>Release:        
>Organization:
>Environment:
>Description:
Portlint pointed out 2 fatal errors.
Here is a fix which was originally submitted by 
Takefu <takefu@airport.fm> for ports/141776.

>How-To-Repeat:

# portlint
FATAL: Makefile: [212]: contiguous blank lines (> 1 lines) found.
FATAL: Makefile: [74]: USE_OPENSSL is set after including bsd.port.pre.mk.
WARN: Makefile: possible use of absolute pathname "/var/db/spamassassin".
WARN: Makefile: possible use of absolute pathname "/var/spool/spamd".
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
WARN: Makefile: do not set RUN_DEPENDS to ${BUILD_DEPENDS}. Instead, explicity list out required RUN_DEPENDS dependencies.
WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
2 fatal errors and 5 warnings found.

>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/p5-Mail-SpamAssassin/Makefile,v
retrieving revision 1.126
diff -u -r1.126 Makefile
--- Makefile	22 Jul 2009 16:26:48 -0000	1.126
+++ Makefile	20 Jan 2010 13:22:51 -0000
@@ -53,6 +53,10 @@
 		SPF_QUERY "Add SPF query support" off \
 		RELAY_COUNTRY "Relay country support" off
 
+.if !defined(WITHOUT_SSL)
+USE_OPENSSL=	yes
+.endif
+
 .include <bsd.port.pre.mk>
 
 .if defined (WITH_SPAMC)
@@ -71,7 +75,6 @@
 .if !defined(WITHOUT_SSL)
 .include "${PORTSDIR}/Mk/bsd.openssl.mk"
 RUN_DEPENDS+=	${SITE_PERL}/IO/Socket/SSL.pm:${PORTSDIR}/security/p5-IO-Socket-SSL
-USE_OPENSSL=	yes
 CFLAGS+=	-I${OPENSSLINC}
 LDFLAGS+=	-L${OPENSSLLIB}
 CONFIGURE_ARGS+=	ENABLE_SSL=yes
@@ -210,7 +213,6 @@
 	@${REINPLACE_CMD} -e '/^CC =/d; \
 		s|@SSLCFLAGS@|& $${CFLAGS}|g' ${WRKSRC}/spamc/Makefile.in
 
-
 .if defined(WITH_RAZOR)
 	${REINPLACE_CMD} -e '/Razor2/s/^#loadplugin/loadplugin/' ${WRKSRC}/rules/v312.pre
 .endif

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Jan 20 13:40:19 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143016 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: scheidell@secnap.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/143016: mail/p5-Mail-SpamAssassin: portlint complains
Date: Wed, 20 Jan 2010 13:40:17 UT

 Maintainer of mail/p5-Mail-SpamAssassin,
 
 Please note that PR ports/143016 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/143016
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Michael Scheidell <scheidell@secnap.net>
To: bug-followup@FreeBSD.org, fmysh@iijmio-mail.jp
Cc:  
Subject: Re: ports/143016: mail/p5-Mail-SpamAssassin: portlint complains
Date: Wed, 20 Jan 2010 08:49:13 -0500

 This is a multi-part message in MIME format.
 --------------080605030402000603010703
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Thanks. please leave open, I will fix it when I upload new port for SA 
 3.30, due out any day.
 
 -- 
 Michael Scheidell, CTO
 Phone: 561-999-5000, x 1259
  > *| *SECNAP Network Security Corporation
 
     * Certified SNORT Integrator
     * 2008-9 Hot Company Award Winner, World Executive Alliance
     * Five-Star Partner Program 2009, VARBusiness
     * Best Anti-Spam Product 2008, Network Products Guide
     * King of Spam Filters, SC Magazine 2008
 
 
 ______________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.secnap.com/products/spammertrap/
 ______________________________________________________________________  
 --------------080605030402000603010703
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
 <head>
 
 <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
 </head>
 <body bgcolor="#ffffff" text="#000000">
 Thanks. please leave open, I will fix it when I upload new port for SA
 3.30, due out any day.<br>
 <br>
 <div class="moz-signature">-- <br>
 Michael Scheidell, CTO<br>
 Phone: 561-999-5000, x 1259<br>
 <font color="#999999">&gt;</font><font color="#cc0000"> <b>| </b></font>SECNAP
 Network Security Corporation
 <style type="text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
 <ul class="unnamed1">
   <li>Certified SNORT Integrator</li>
   <li>2008-9 Hot Company Award Winner, World Executive Alliance</li>
   <li>Five-Star Partner Program 2009, VARBusiness</li>
   <li>Best Anti-Spam Product 2008, Network Products Guide</li>
   <li>King of Spam Filters, SC Magazine 2008</li>
 </ul>
 </div>
 
 <br>
 <div id="disclaimer.secnap.com"><hr />
 <p>This email has been scanned and certified safe by SpammerTrap&reg;.
 <br />For Information please see
 <a href="http://www.secnap.com/products/spammertrap/">http://www.secnap.com/products/spammertrap/</a></p> <hr /></div>
 <br>
 </body>
 </html>
 
 --------------080605030402000603010703--
Responsible-Changed-From-To: freebsd-ports-bugs->wen 
Responsible-Changed-By: wen 
Responsible-Changed-When: Wed Jan 20 14:12:19 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143016 

From: Michael Scheidell <scheidell@secnap.net>
To: wen@FreeBSD.org, edwin@freebsd.org
Cc:  
Subject: Re: ports/143016: mail/p5-Mail-SpamAssassin: portlint complains
Date: Wed, 20 Jan 2010 09:15:08 -0500

 PLEASE... THERE WILL BE A MAJOR UPDATE SOON, THE PORTLINT PROBLEMS DON'T 
 AFFECT ANYONE.
 
 DON'T DO A PORTUPGRADE VERSION AND FORCE EVERYONE TO UPDATE WHO IS ANAL 
 ABOUT UPDATES.
 
 IF YOU MUST DO THIS, THEN DON'T BUMP PORTVERSION.
 
 
 On 1/20/10 9:12 AM, wen@FreeBSD.org wrote:
 > Synopsis: mail/p5-Mail-SpamAssassin: portlint complains
 >
 > Responsible-Changed-From-To: freebsd-ports-bugs->wen
 > Responsible-Changed-By: wen
 > Responsible-Changed-When: Wed Jan 20 14:12:19 UTC 2010
 > Responsible-Changed-Why:
 > I'll take it.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=143016
 >    
 
 -- 
 Michael Scheidell, CTO
 Phone: 561-999-5000, x 1259
  > *| *SECNAP Network Security Corporation
 
     * Certified SNORT Integrator
     * 2008-9 Hot Company Award Winner, World Executive Alliance
     * Five-Star Partner Program 2009, VARBusiness
     * Best Anti-Spam Product 2008, Network Products Guide
     * King of Spam Filters, SC Magazine 2008
 
 ______________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.secnap.com/products/spammertrap/
 ______________________________________________________________________  
 

From: Michael Scheidell <scheidell@secnap.net>
To: bug-followup@FreeBSD.org, fmysh@iijmio-mail.jp
Cc:  
Subject: Re: ports/143016: mail/p5-Mail-SpamAssassin: portlint complains
Date: Sun, 07 Feb 2010 17:46:12 -0500

 This is a multi-part message in MIME format.
 --------------040507060706060402090601
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Thank you for your patches.  These patches have been incorporated into
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=143654
 
 ports commit: please close PR 143016 as incorporated into pr 143654
 
 
 -- 
 Michael Scheidell, CTO
 Phone: 561-999-5000, x 1259
  > *| *SECNAP Network Security Corporation
 
     * Certified SNORT Integrator
     * 2008-9 Hot Company Award Winner, World Executive Alliance
     * Five-Star Partner Program 2009, VARBusiness
     * Best Anti-Spam Product 2008, Network Products Guide
     * King of Spam Filters, SC Magazine 2008
 
 
 ______________________________________________________________________
 This email has been scanned and certified safe by SpammerTrap(r). 
 For Information please see http://www.secnap.com/products/spammertrap/
 ______________________________________________________________________  
 --------------040507060706060402090601
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
 <head>
 
 <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
 </head>
 <body bgcolor="#ffffff" text="#000000">
 Thank you for your patches.&nbsp; These patches have been incorporated into<br>
 <pre wrap=""><a class="moz-txt-link-freetext"
  href="http://www.freebsd.org/cgi/query-pr.cgi?pr=143654">http://www.freebsd.org/cgi/query-pr.cgi?pr=143654</a>
 
 ports commit: please close PR 143016 as incorporated into pr 143654
 </pre>
 <br>
 <div class="moz-signature">-- <br>
 Michael Scheidell, CTO<br>
 Phone: 561-999-5000, x 1259<br>
 <font color="#999999">&gt;</font><font color="#cc0000"> <b>| </b></font>SECNAP
 Network Security Corporation
 <style type="text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
 <ul class="unnamed1">
   <li>Certified SNORT Integrator</li>
   <li>2008-9 Hot Company Award Winner, World Executive Alliance</li>
   <li>Five-Star Partner Program 2009, VARBusiness</li>
   <li>Best Anti-Spam Product 2008, Network Products Guide</li>
   <li>King of Spam Filters, SC Magazine 2008</li>
 </ul>
 </div>
 
 <br>
 <div id="disclaimer.secnap.com"><hr />
 <p>This email has been scanned and certified safe by SpammerTrap&reg;.
 <br />For Information please see
 <a href="http://www.secnap.com/products/spammertrap/">http://www.secnap.com/products/spammertrap/</a></p> <hr /></div>
 <br>
 </body>
 </html>
 
 --------------040507060706060402090601--
State-Changed-From-To: feedback->closed 
State-Changed-By: wen 
State-Changed-When: Thu Feb 11 13:58:38 UTC 2010 
State-Changed-Why:  
Superceded by 143654 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143016 
>Unformatted:
