From nobody@FreeBSD.org  Mon Jan 18 16:29:35 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BF671106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Jan 2010 16:29:35 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id ADE3A8FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Jan 2010 16:29:35 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0IGTZum076375
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Jan 2010 16:29:35 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o0IGTZol076374;
	Mon, 18 Jan 2010 16:29:35 GMT
	(envelope-from nobody)
Message-Id: <201001181629.o0IGTZol076374@www.freebsd.org>
Date: Mon, 18 Jan 2010 16:29:35 GMT
From: Greg Larkin <glarkin@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] sysutils/xfce4-netload-plugin: Adjust OSVERSION in check for BROKEN
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         142939
>Category:       ports
>Synopsis:       [PATCH] sysutils/xfce4-netload-plugin: Adjust OSVERSION in check for BROKEN
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    demon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 18 16:30:08 UTC 2010
>Closed-Date:    Tue Jan 26 11:51:22 UTC 2010
>Last-Modified:  Thu Apr  8 04:58:39 UTC 2010
>Originator:     Greg Larkin
>Release:        7.0-RELEASE
>Organization:
The FreeBSD Project
>Environment:
FreeBSD fbsd70.entropy.prv 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59:
52 UTC 2008     root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
sysutils/xfce4-netload-plugin was marked BROKEN on 8.0 (OSVERSION >= 800000) because of a compile error resulting from a missing net/if_ppp.h include file.

net/if_ppp.h was removed for OSVERSION >= 800045, so adjust the check in the Makefile with that version.

Further discussion of the removal of if_ppp(4) can be found here:
http://www.mail-archive.com/svn-src-all@freebsd.org/msg07293.html

A better solution would be to port xfce4-netload-plugin to use ppp(8) instead of if_ppp(4), if possible.
>How-To-Repeat:

>Fix:
See attached patch

Patch attached with submission follows:

Index: sysutils/xfce4-netload-plugin/Makefile
===================================================================
RCS file: /home/pcvs/ports/sysutils/xfce4-netload-plugin/Makefile,v
retrieving revision 1.30
diff -u -r1.30 Makefile
--- sysutils/xfce4-netload-plugin/Makefile	10 Jan 2010 09:56:21 -0000	1.30
+++ sysutils/xfce4-netload-plugin/Makefile	18 Jan 2010 16:22:31 -0000
@@ -24,7 +24,7 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${OSVERSION} >= 800000
+.if ${OSVERSION} >= 800045
 BROKEN=		does not compile: error: net/if_ppp.h: No such file or directory
 .endif
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->demon 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jan 18 16:30:24 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142939 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/142939: commit references a PR
Date: Tue, 26 Jan 2010 11:46:19 +0000 (UTC)

 demon       2010-01-26 11:46:05 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/xfce4-netload-plugin Makefile 
   Log:
   Adjust OSVERSION the port is broken since.
   
   PR:             142939
   Submitted by:   glarkin
   
   Revision  Changes    Path
   1.31      +1 -1      ports/sysutils/xfce4-netload-plugin/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: demon 
State-Changed-When: Tue Jan 26 11:50:59 UTC 2010 
State-Changed-Why:  
Patch applied, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142939 

From: Brian Powell <bp2626@yahoo.com>
To: bug-followup@FreeBSD.org, glarkin@FreeBSD.org
Cc:  
Subject: Re: ports/142939: [PATCH] sysutils/xfce4-netload-plugin: Adjust OSVERSION in check for BROKEN
Date: Wed, 7 Apr 2010 21:21:28 -0700 (PDT)

 --0-1805881389-1270700488=:12144
 Content-Type: text/plain; charset=iso-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 The include file net/if_ppp.h is not needed for compilation. If you simply =
 comment the include (/*#include <net/if_ppp.h>*/ on line 98 of os.h) everyt=
 hing compiles and runs successfully on FreeBSD 8.
 =A0
 --------------
 sysutils/xfce4-netload-plugin was marked BROKEN on 8.0 (OSVERSION >=3D=0A80=
 0000) because of a compile error resulting from a missing=0Anet/if_ppp.h in=
 clude file.
 =0A
 =0Anet/if_ppp.h was removed for OSVERSION >=3D 800045, so adjust the check =
 in the Makefile with that version.
 =0A
 =0AFurther discussion of the removal of if_ppp(4) can be found here:
 =0Ahttp://www.mail-archive.com/svn-src-all@freebsd.org/msg07293.html
 =0A
 =0AA better solution would be to port xfce4-netload-plugin to use ppp(8) in=
 stead of if_ppp(4), if possible.
 ----------
 
 --0-1805881389-1270700488=:12144--
>Unformatted:
