From wtp@bsdserwis.com  Fri Jan 15 05:18:18 2010
Return-Path: <wtp@bsdserwis.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1B054106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Jan 2010 05:18:18 +0000 (UTC)
	(envelope-from wtp@bsdserwis.com)
Received: from cmd.bsdserwis.com (ns37332.ovh.net [91.121.4.86])
	by mx1.freebsd.org (Postfix) with ESMTP id CB6D88FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Jan 2010 05:18:17 +0000 (UTC)
Received: by cmd.bsdserwis.com (Postfix, from userid 1000)
	id 116732CA26CB; Fri, 15 Jan 2010 06:18:17 +0100 (CET)
Message-Id: <20100115051817.116732CA26CB@cmd.bsdserwis.com>
Date: Fri, 15 Jan 2010 06:18:17 +0100 (CET)
From: Krzysztof Stryjek <admin@bsdserwis.com>
Reply-To: Krzysztof Stryjek <admin@bsdserwis.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Update of fail2ban port.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         142849
>Category:       ports
>Synopsis:       Update of security/py-fail2ban
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 15 05:20:01 UTC 2010
>Closed-Date:    Mon Jan 18 05:24:55 UTC 2010
>Last-Modified:  Mon Jan 18 05:30:09 UTC 2010
>Originator:     Krzysztof Stryjek
>Release:        FreeBSD 7.1-RELEASE amd64
>Organization:
private
>Environment:
System: FreeBSD cmd 7.1-RELEASE FreeBSD 7.1-RELEASE #1: Sun Feb 8 16:35:00 CET 2009 root:/usr/obj/usr/src/sys/OVH amd64

>Description:
	Python fail2ban is very sueful tool. But there is bug with
python2.6, so there should be limitations to python version at port Makefile.

	The fail2ban rc script does not honour fail2ban_flags variable, so
there is no possibility to change start behaviour of fail2ban daemon. Adding
two lines to rcscript solves the problem.

>How-To-Repeat:
	After install and setting fail2ban_enable at rc.conf file try to
start daemon using fail2ban rcscript. There will be python coredump while
python2.6 is used.

>Fix:

After adding this patches: one for Makefile and the second for rcscript you
will be albel to start fail2ban server:

--- Makefile.orig	2009-08-23 05:13:33.000000000 +0200
+++ Makefile	2010-01-15 05:59:44.000000000 +0100
@@ -19,7 +19,7 @@
 
 USE_BZIP2=	yes
 
-USE_PYTHON=	yes
+USE_PYTHON=	2.3-2.5
 USE_PYDISTUTILS=	yes
 
 USE_RC_SUBR=	fail2ban

----------------------------------------------------------------------------

--- files/fail2ban.in.orig	2009-07-16 05:13:16.000000000 +0200
+++ files/fail2ban.in	2010-01-15 06:16:31.000000000 +0100
@@ -23,6 +23,9 @@
 
 extra_commands="reload jailstatus"
 
+# read settings, set defaults
+load_rc_config ${name}
+
 start_cmd="${client} ${fail2ban_flags} start"
 stop_cmd="${client} ${fail2ban_flags} stop"
 reload_cmd="${client} ${fail2ban_flags} reload"

----------------------------------------------------------------------------

Greetings from Poland
--
Krzysztof Stryjek
>Release-Note:
>Audit-Trail:

From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
To: Krzysztof Stryjek <admin@bsdserwis.com>
Cc: FreeBSD-gnats-submit@freebsd.org, Doug Barton <dougb@freebsd.org>
Subject: Re: ports/142849: Update of fail2ban port.
Date: Fri, 15 Jan 2010 06:11:47 +0000

 > --- Makefile.orig	2009-08-23 05:13:33.000000000 +0200
 > +++ Makefile	2010-01-15 05:59:44.000000000 +0100
 > -USE_PYTHON=	yes
 > +USE_PYTHON=	2.3-2.5
 I agree.
 
 > --- files/fail2ban.in.orig	2009-07-16 05:13:16.000000000 +0200
 > +++ files/fail2ban.in	2010-01-15 06:16:31.000000000 +0100
 > @@ -23,6 +23,9 @@
 >  
 >  extra_commands="reload jailstatus"
 >  
 > +# read settings, set defaults
 > +load_rc_config ${name}
 > +
 >  start_cmd="${client} ${fail2ban_flags} start"
 >  stop_cmd="${client} ${fail2ban_flags} stop"
 >  reload_cmd="${client} ${fail2ban_flags} reload"
 That doesn't seem right to me esp since that line is already there but 
 lower. If anything the pidfile line should move.
 
 Doug, comments ?
 
 http://people.freebsd.org/~pgollucci/FreeBSD/diffs/security_py-fail2ban-0.8.3.diff
 
 
 
 -- 
 ------------------------------------------------------------------------
 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
 Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
 VP Apache Infrastructure; Member, Apache Software Foundation
 Committer,                        FreeBSD Foundation
 Consultant,                       P6M7G8 Inc.
 Sr. System Admin,                 Ridecharge Inc.
 
 Work like you don't need the money,
 love like you'll never get hurt,
 and dance like nobody's watching.

From: Mark Linimon <linimon@lonesome.com>
To: Krzysztof Stryjek <admin@bsdserwis.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/142849: Update of fail2ban port.
Date: Fri, 15 Jan 2010 05:37:29 -0600

 To which port does this apply?
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Fri Jan 15 11:47:22 UTC 2010 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142849 

From: Krzysztof Stryjek <wtp@bsdserwis.com>
To: Mark Linimon <linimon@lonesome.com>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/142849: Update of fail2ban port.
Date: Fri, 15 Jan 2010 12:46:19 +0100

 --YkJPYEFdoxh/AXLE
 Content-Type: text/plain; charset=iso-8859-2
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Helo,
 
 On Fri, Jan 15, 2010 at 05:37:29AM -0600, Mark Linimon wrote:
 > To which port does this apply?
 >=20
 security/py-fail2ban
 
 Sorry for my mistake.
 
 Greetings,
 --=20
 Krzysztof Stryjek
 UNIX administrator/Juniper Networks Specialist
 email: wtp (at) bsdserwis (dot) com
 http://www.linkedin.com/in/KrzysztofStryjek
 GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76
 
 In theory, there is no difference between theory and practice.
 In practice, there is.
 
 --YkJPYEFdoxh/AXLE
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.14 (FreeBSD)
 
 iEYEARECAAYFAktQVYsACgkQEpKJWdxhDnaunACgxz0mOfjq3VAZkDOyAE0mZkzZ
 P4sAoJTr3a88pAA3vZl9FrqGr07QmVqo
 =hG1u
 -----END PGP SIGNATURE-----
 
 --YkJPYEFdoxh/AXLE--
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Mon Jan 18 05:24:53 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142849 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/142849: commit references a PR
Date: Mon, 18 Jan 2010 05:24:51 +0000 (UTC)

 pgollucci    2010-01-18 05:24:38 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/py-fail2ban Makefile 
     security/py-fail2ban/files fail2ban.in 
   Log:
   - rc.d fix [2]
   - broken on 2.6, 2.3 is gone, and 2.4 is gone soon, so only 2.5 [1]
   
   PR:             ports/142849 [2]
   Submitted by:   Krzysztof Stryjek <admin@bsdserwis.com> [1], miwi [2]
   
   Revision  Changes    Path
   1.6       +2 -2      ports/security/py-fail2ban/Makefile
   1.3       +2 -2      ports/security/py-fail2ban/files/fail2ban.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
