From nobody@FreeBSD.org  Sat Jan  2 16:37:30 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DC62B106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Jan 2010 16:37:30 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id CC0D28FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  2 Jan 2010 16:37:30 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o02GbUF9087719
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 2 Jan 2010 16:37:30 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o02GbU5o087718;
	Sat, 2 Jan 2010 16:37:30 GMT
	(envelope-from nobody)
Message-Id: <201001021637.o02GbU5o087718@www.freebsd.org>
Date: Sat, 2 Jan 2010 16:37:30 GMT
From: Akinori MUSHA <knu@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: net/samba3: startup script should remove pid files
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         142244
>Category:       ports
>Synopsis:       net/samba3: startup script should remove pid files
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    timur
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 02 16:40:04 UTC 2010
>Closed-Date:    Fri Mar 18 10:08:56 UTC 2011
>Last-Modified:  Fri Mar 18 10:08:56 UTC 2011
>Originator:     Akinori MUSHA
>Release:        FreeBSD 8.0-STABLE amd64
>Organization:
>Environment:
FreeBSD daemon.musha.org 8.0-STABLE FreeBSD 8.0-STABLE #0: Thu Dec 31 03:33:36 JST 2009     root@daemon.musha.org:/var/cache/obj/usr/src/sys/DAEMON  amd64
>Description:
Samba daemons seem to leave pid files under /var/run/ even if they successfully shut down,
and the existence of ghost pid files cause problems in next startup.

I can observe nmbd instances increasing enormously on my box.

>How-To-Repeat:
/usr/local/etc/rc.d/samba start
/usr/local/etc/rc.d/samba stop
/usr/local/etc/rc.d/samba start

>Fix:
Make the rc script remove pid files after shutting down daemons.
I didn't check but this should also apply to other samba ports.

If the problem is on samba's side, please report this to the Samba team.

Patch attached with submission follows:

Index: files/samba.in
===================================================================
RCS file: /home/pcvs/ports/net/samba3/files/samba.in,v
retrieving revision 1.6
diff -u -r1.6 samba.in
--- files/samba.in	5 Jun 2007 10:55:06 -0000	1.6
+++ files/samba.in	2 Jan 2010 16:19:45 -0000
@@ -155,7 +155,10 @@
 	command="%%PREFIX%%/sbin/${name}"
 	pidfile="%%SAMBA_RUNDIR%%/${name}${pid_extra}.pid"
 	
-	run_rc_command "${_rc_prefix}${rc_arg}" ${rc_extra_args}
+	run_rc_command "${_rc_prefix}${rc_arg}" ${rc_extra_args} &&
+	    if [ "${rc_arg}" = "stop" ]; then
+		rm -f -- "${pidfile}"
+	    fi
     done
 }
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->timur 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Jan 2 16:40:13 UTC 2010 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142244 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Fri Mar 18 10:08:56 UTC 2011 
State-Changed-Why:  
port was removed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142244 
>Unformatted:
