From nobody@FreeBSD.org  Mon Dec 28 04:44:04 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 79619106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Dec 2009 04:44:04 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E66B8FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Dec 2009 04:44:04 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBS4i3Gl053224
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Dec 2009 04:44:03 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBS4i3Vl053223;
	Mon, 28 Dec 2009 04:44:03 GMT
	(envelope-from nobody)
Message-Id: <200912280444.nBS4i3Vl053223@www.freebsd.org>
Date: Mon, 28 Dec 2009 04:44:03 GMT
From: "YAMAMOTO, Shigeru" <shigeru@iij.ad.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [ports/textproc/docbook-410] definition mismatch between 'BUILD_DEPENDS' and 'do-install'
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         142091
>Category:       ports
>Synopsis:       textproc/docbook-410: definition mismatch between 'BUILD_DEPENDS' and 'do-install'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gabor
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 28 04:50:00 UTC 2009
>Closed-Date:    Thu Jan 21 10:48:03 UTC 2010
>Last-Modified:  Thu Jan 21 10:50:06 UTC 2010
>Originator:     YAMAMOTO, Shigeru
>Release:        9.0-CURRENT
>Organization:
>Environment:
FreeBSD mercury.iij.ad.jp 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Thu Dec 24 09:31:22 JST 2009     root@XXXX:/usr/src/sys/amd64/compile/XXXX  amd64

>Description:
I can not install 'ports/textproc/docbook-410' before installing 'ports/archivers/unzip'.

Because, definition 'BUILD_DEPENDS' is mismatched to doing 'do-install'.

definition 'BUILD_DEPENDS' in Makefile,

 BUILD_DEPENDS=  unzip:${PORTSDIR}/archivers/unzip

but, calling 'unzip' in 'do-install' is

do-install:
        @${UNZIP_CMD} -a -q -o ${DISTDIR}/${DISTFILES} -d ${INSTDIR}/${PORTVERSION}

In -current, unzip is included in system binarires.('/usr/bin/unzip')
So, 'ports/archives/unzip' is not installed automatically.


>How-To-Repeat:
1) de-install 'archives/unzip'
2) make 'textproc/docbook-410'

>Fix:
I think 2 way to fix it.

1) change 'do-install' same as 'textproc/docbook-420'

Index: textproc/docbook-410/Makefile
===================================================================
RCS file: /share/cvsup/FreeBSD/current/usr/ports/textproc/docbook-410/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- textproc/docbook-410/Makefile       1 Sep 2008 07:44:14 -0000       1.16
+++ textproc/docbook-410/Makefile       28 Dec 2009 04:42:40 -0000
@@ -42,7 +42,7 @@
        @${MKDIR} ${INSTDIR}/${PORTVERSION}
 
 do-install:
-       @${UNZIP_CMD} -a -q -o ${DISTDIR}/${DISTFILES} -d ${INSTDIR}/${PORTVERSION}
+       @unzip -a -q -o ${DISTDIR}/${DISTFILES} -d ${INSTDIR}/${PORTVERSION}
        @${INSTALL_DATA} ${FILESDIR}/catalog ${INSTDIR}/${PORTVERSION}/catalog
        @${ECHO_CMD} "CATALOG \"${ISOCAT}\"" >> ${INSTDIR}/${PORTVERSION}/catalog
        @${CHMOD} ${SHAREMODE} ${INSTDIR}/${PORTVERSION}/*

2) change 'BUILD_DEPENDS' to use '${UNZIP_CMD}'.

Index: textproc/docbook-410/Makefile
===================================================================
RCS file: /share/cvsup/FreeBSD/current/usr/ports/textproc/docbook-410/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- textproc/docbook-410/Makefile       1 Sep 2008 07:44:14 -0000       1.16
+++ textproc/docbook-410/Makefile       28 Dec 2009 04:23:44 -0000
@@ -20,7 +20,7 @@
 
 RUN_DEPENDS=   ${ISOCAT}:${PORTSDIR}/textproc/iso8879 \
                ${XMLCATMGR}:${PORTSDIR}/textproc/xmlcatmgr
-BUILD_DEPENDS= unzip:${PORTSDIR}/archivers/unzip
+BUILD_DEPENDS= ${UNZIP_CMD}:${PORTSDIR}/archivers/unzip
 
 USE_ZIP=       yes
 NO_MTREE=      yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gabor 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Dec 28 04:50:13 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142091 
State-Changed-From-To: open->closed 
State-Changed-By: gabor 
State-Changed-When: Thu Jan 21 10:46:33 UTC 2010 
State-Changed-Why:  
Hi Yamamoto-san, 

I've removed unzip from BUILD_DEPENDS, which was superfluous. The USE_ZIP 
knob is now fixed in bsd.port.mk, so it can deal with base unzip vs ports 
unzip in 9.0-CURRENT. 

Regards, 
Gabor 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142091 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/142091: commit references a PR
Date: Thu, 21 Jan 2010 10:46:20 +0000 (UTC)

 gabor       2010-01-21 10:46:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     textproc/docbook-310 Makefile 
     textproc/docbook-410 Makefile 
   Log:
   - Remove unzip from BUILD_DEPENDS, which is superfluous
   - USE_ZIP is enough, it deals with unzip in 9.0-CURRENT, as well
   
   PR:             ports/142091
   Submitted by:   "YAMAMOTO, Shigeru" <shigeru@iij.ad.jp>
   
   Revision  Changes    Path
   1.29      +0 -1      ports/textproc/docbook-310/Makefile
   1.17      +0 -1      ports/textproc/docbook-410/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
