From nobody@FreeBSD.org  Sat Dec 26 23:14:53 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A5BD106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Dec 2009 23:14:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 28D668FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Dec 2009 23:14:53 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBQNEqgs010244
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 26 Dec 2009 23:14:52 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBQNEqAa010243;
	Sat, 26 Dec 2009 23:14:52 GMT
	(envelope-from nobody)
Message-Id: <200912262314.nBQNEqAa010243@www.freebsd.org>
Date: Sat, 26 Dec 2009 23:14:52 GMT
From: Carlos Santos <unixmania@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: x11/xorg-minimal: [PATCH] allow choosing video driver during build
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: EitanAdlerList@gmail.com

>Number:         142053
>Category:       ports
>Synopsis:       x11/xorg-minimal: [PATCH] allow choosing video driver during build
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Dec 26 23:20:01 UTC 2009
>Closed-Date:    Fri Jan 15 00:48:07 UTC 2010
>Last-Modified:  Fri Jan 15 00:50:01 UTC 2010
>Originator:     Carlos Santos
>Release:        9.0-CURRENT
>Organization:
N.A.
>Environment:
FreeBSD avatar 9.0-CURRENT FreeBSD 9.0-CURRENT #4: Mon Dec  7 03:06:31 UTC 2009     root@avatar:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
The patch contained in the attachment allows the user to choose a video driver to use instead of the default vesa driver. It allse ensures that xinit and xauth are searched at the right place.
>How-To-Repeat:
N.A.
>Fix:
Apply the patch contained in the attachment.

Patch attached with submission follows:

--- x11/xorg-minimal/Makefile.orig	2009-05-10 20:39:00.000000000 -0300
+++ x11/xorg-minimal/Makefile	2009-12-26 21:13:22.000000000 -0200
@@ -19,12 +19,14 @@
 
 NO_BUILD=	yes
 
+VIDEO_DRIVER?=	vesa
+
 RUN_DEPENDS+=	${LOCALBASE}/bin/Xorg:${PORTSDIR}/x11-servers/xorg-server \
-		${LOCALBASE}/lib/xorg/modules/drivers/vesa_drv.so:${PORTSDIR}/x11-drivers/xf86-video-vesa \
+		${LOCALBASE}/lib/xorg/modules/drivers/${VIDEO_DRIVER}_drv.so:${PORTSDIR}/x11-drivers/xf86-video-${VIDEO_DRIVER} \
 		${LOCALBASE}/lib/xorg/modules/input/mouse_drv.so:${PORTSDIR}/x11-drivers/xf86-input-mouse \
 		${LOCALBASE}/lib/xorg/modules/input/kbd_drv.so:${PORTSDIR}/x11-drivers/xf86-input-keyboard \
-		xinit:${PORTSDIR}/x11/xinit \
-		xauth:${PORTSDIR}/x11/xauth \
+		${LOCALBASE}/bin/xinit:${PORTSDIR}/x11/xinit \
+		${LOCALBASE}/bin/xauth:${PORTSDIR}/x11/xauth \
 		${LOCALBASE}/lib/X11/fonts/misc/fonts.alias:${PORTSDIR}/x11-fonts/font-alias \
 		${LOCALBASE}/lib/X11/fonts/misc/cursor.pcf.gz:${PORTSDIR}/x11-fonts/font-cursor-misc \
 		${LOCALBASE}/lib/X11/fonts/misc/10x20.pcf.gz:${PORTSDIR}/x11-fonts/font-misc-misc
@@ -35,6 +37,10 @@
 	@${ECHO_MSG} "This is a meta-port, meaning that it just depends on its subparts of the port."
 	@${ECHO_MSG} "It won't build and install all the parts until you have typed make install"
 	@${ECHO_MSG} "This port does not ensure things are upgraded; use portmaster if you want to"
-	@${ECHO_MSG} "upgrade X.Org."
+	@${ECHO_MSG} "upgrade X.Org. The \"vesa\" driver is installed by default. You can choose a"
+	@${ECHO_MSG} "different one by means of the VIDEO_DRIVER parameter. For example:"
+	@${ECHO_MSG} ""
+	@${ECHO_MSG} "        make install VIDEO_DRIVER=intel"
+	@${ECHO_MSG} ""
 
 .include <bsd.port.mk>


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Dec 26 23:20:11 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142053 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: EitanAdlerList@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/142053: x11/xorg-minimal: [PATCH] allow choosing video driver during build
Date: Sat, 26 Dec 2009 23:20:08 UT

 Maintainer of x11/xorg-minimal,
 
 Please note that PR ports/142053 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/142053
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Eitan Adler <eitanadlerlist@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/142053: x11/xorg-minimal: [PATCH] allow choosing video 
	driver during build
Date: Sun, 27 Dec 2009 01:32:25 +0200

 --001485f6295cdd9255047baa1643
 Content-Type: text/plain; charset=ISO-8859-1
 
  Perfect - I've been thinking about how to do this for a while.
 Go ahead and commit it
 
 --001485f6295cdd9255047baa1643
 Content-Type: text/html; charset=ISO-8859-1
 
 		Perfect - I&#39;ve been thinking about how to do this for a while.<br>Go ahead and commit it<br>
 
 --001485f6295cdd9255047baa1643--
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Wed Jan 13 01:28:50 UTC 2010 
State-Changed-Why:  
Maintainer has approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142053 
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Wed Jan 13 01:28:54 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142053 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Fri Jan 15 00:48:06 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142053 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/142053: commit references a PR
Date: Fri, 15 Jan 2010 00:46:41 +0000 (UTC)

 pgollucci    2010-01-15 00:46:22 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11/xorg-minimal     Makefile 
   Log:
   - Allow the user to choose a video driver to use instead of the default vesa driver.
   - xinit and xauth are searched at the right place
   
   PR:             ports/142053
   Submitted by:   Carlos Santos <unixmania@gmail.com>
   Approved by:    Eitan Adler <eitanadlerlist@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.5       +11 -5     ports/x11/xorg-minimal/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
