From nobody@FreeBSD.org  Fri Dec 25 19:44:02 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7CC66106568D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Dec 2009 19:44:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6AF378FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Dec 2009 19:44:01 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBPJi1xo012923
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 25 Dec 2009 19:44:01 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBPJi13k012922;
	Fri, 25 Dec 2009 19:44:01 GMT
	(envelope-from nobody)
Message-Id: <200912251944.nBPJi13k012922@www.freebsd.org>
Date: Fri, 25 Dec 2009 19:44:01 GMT
From: Thomas Zander <thomas.e.zander@googlemail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] audio/exaile does not respect its OPTIONS
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: jsa@wickedmachine.net

>Number:         142020
>Category:       ports
>Synopsis:       [PATCH] audio/exaile does not respect its OPTIONS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Dec 25 19:50:00 UTC 2009
>Closed-Date:    Fri Jan 08 01:35:05 UTC 2010
>Last-Modified:  Fri Jan 08 01:35:05 UTC 2010
>Originator:     Thomas Zander
>Release:        8.0-STABLE
>Organization:
>Environment:
FreeBSD marvin 8.0-STABLE FreeBSD 8.0-STABLE #0
root@marvin:/usr/obj/usr/src/sys/MARVIN  amd64
>Description:
The port of the audio player exaile does have a menu to set OPTIONS during port build, but it always builds the default configuration.
>How-To-Repeat:
Try and install exaile e.g. without hal, it does still depend on it.
>Fix:
Attached patch resolves the issue.

Patch attached with submission follows:

diff -ruN /usr/ports/audio/exaile/Makefile exaile/Makefile
--- /usr/ports/audio/exaile/Makefile	2009-12-19 12:26:40.290637402 +0100
+++ exaile/Makefile	2009-12-25 19:33:26.728564774 +0100
@@ -34,6 +34,8 @@
 		NLS "Native Language Support" On \
 		SEXY "UI enhancements"  On
 
+.include <bsd.port.pre.mk>
+
 .if !defined(WITHOUT_BAD)
 USE_GSTREAMER+=	bad
 .endif
@@ -74,4 +76,4 @@
 	@${REINPLACE_CMD} -e 's|$$(XDG|$$(PREFIX)$$(XDG|g' \
 		${WRKSRC}/Makefile
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Dec 25 19:50:12 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142020 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: jsa@wickedmachine.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/142020: [PATCH] audio/exaile does not respect its OPTIONS
Date: Fri, 25 Dec 2009 19:50:09 UT

 Maintainer of audio/exaile,
 
 Please note that PR ports/142020 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/142020
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: "Joseph S. Atkinson" <jsa.bsd@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/142020: [PATCH] audio/exaile does not respect its OPTIONS
Date: Wed, 30 Dec 2009 07:25:55 +0000

 Will verify this after the Holidays.

From: "Joseph S. Atkinson" <jsa.bsd@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/142020: [PATCH] audio/exaile does not respect its OPTIONS
Date: Tue, 05 Jan 2010 20:58:31 +0000

 Approved.
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Tue Jan 5 21:02:41 UTC 2010 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142020 
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Thu Jan 7 05:31:55 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142020 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/142020: commit references a PR
Date: Fri,  8 Jan 2010 01:21:34 +0000 (UTC)

 pgollucci    2010-01-08 01:21:20 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/exaile         Makefile 
   Log:
   - Fix OPTIONs
   
   PR:             ports/142020
   Submitted by:   Thomas Zander <thomas.e.zander@googlemail.com>
   Approved by:    "Joseph S. Atkinson" <jsa.bsd@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.19      +3 -1      ports/audio/exaile/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Fri Jan 8 01:35:04 UTC 2010 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=142020 
>Unformatted:
