From garga@FreeBSD.org  Mon Dec  7 10:36:37 2009
Return-Path: <garga@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 908761065692
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Dec 2009 10:36:37 +0000 (UTC)
	(envelope-from garga@FreeBSD.org)
Received: from capeta.freebsdbrasil.com.br (capeta.freebsdbrasil.com.br [201.48.151.3])
	by mx1.freebsd.org (Postfix) with SMTP id D7D8F8FC24
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  7 Dec 2009 10:36:36 +0000 (UTC)
Received: (qmail 29345 invoked from network); 7 Dec 2009 08:34:34 -0200
Received: by simscan 1.4.0 ppid: 29334, pid: 29342, t: 0.2866s
         scanners:none
Received: from unknown (HELO botelhor.bplab.local) (garga@189.19.84.134)
  by capeta.freebsdbrasil.com.br with ESMTPA; 7 Dec 2009 08:34:34 -0200
Received: (qmail 28997 invoked by uid 1001); 7 Dec 2009 08:36:33 -0200
Message-Id: <20091207103633.28996.qmail@botelhor.bplab.local>
Date: 7 Dec 2009 08:36:33 -0200
From: Renato Botelho <garga@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: ntarmos@cs.uoi.gr
Subject: [PATCH] x11-wm/awesome: Fix awful bug introduced in 3.4
X-Send-Pr-Version: 3.113
X-GNATS-Notify: ntarmos@cs.uoi.gr

>Number:         141244
>Category:       ports
>Synopsis:       [PATCH] x11-wm/awesome: Fix awful bug introduced in 3.4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    garga
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 07 10:40:02 UTC 2009
>Closed-Date:    Mon Dec 21 11:08:11 UTC 2009
>Last-Modified:  Mon Dec 21 11:08:11 UTC 2009
>Originator:     Renato Botelho
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
FreeBSD.org
>Environment:
System: FreeBSD botelhor.bplab.local 9.0-CURRENT FreeBSD 9.0-CURRENT #99 r199996: Tue Dec  1 16:07:53
>Description:
A regression was introduced on 3.4 version, you can show a more detailed
description at [1], i got the patch there.

[1] - http://awesome.naquadah.org/bugs/index.php?do=details&task_id=664

Added file(s):
- files/patch-lib__awful__rules.lua.in
- files/patch-lib__awful__tag.lua.in

Port maintainer (ntarmos@cs.uoi.gr) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- awesome-3.4.2_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/x11-wm/awesome/Makefile,v
retrieving revision 1.36
diff -u -u -r1.36 Makefile
--- Makefile	27 Nov 2009 09:56:14 -0000	1.36
+++ Makefile	7 Dec 2009 10:35:08 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	awesome
 PORTVERSION=	3.4.2
+PORTREVISION=	1
 CATEGORIES=	x11-wm
 MASTER_SITES=	http://awesome.naquadah.org/download/ \
 		http://redundancy.redundancy.org/mirror/
Index: files/patch-lib__awful__rules.lua.in
===================================================================
RCS file: files/patch-lib__awful__rules.lua.in
diff -N files/patch-lib__awful__rules.lua.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-lib__awful__rules.lua.in	7 Dec 2009 10:35:08 -0000
@@ -0,0 +1,23 @@
+--- lib/awful/rules.lua.in
++++ lib/awful/rules.lua.in
+@@ -89,7 +89,9 @@ end
+ 
+ --- Apply rules to a client.
+ -- @param c The client.
+-function apply(c)
++-- @param startup Executed at startup ? (optional, default is false)
++function apply(c, startup)
++    startup = startup or false
+     local props = {}
+     local callbacks = {}
+     for _, entry in ipairs(rules) do
+@@ -129,6 +131,9 @@ function apply(c)
+         callback(c)
+     end
+ 
++    -- Apply tags.
++    atag.withcurrent(c, startup)
++
+     -- Do this at last so we do not erase things done by the focus
+     -- signal.
+     if props.focus then
Index: files/patch-lib__awful__tag.lua.in
===================================================================
RCS file: files/patch-lib__awful__tag.lua.in
diff -N files/patch-lib__awful__tag.lua.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-lib__awful__tag.lua.in	7 Dec 2009 10:35:08 -0000
@@ -0,0 +1,10 @@
+--- lib/awful/tag.lua.in
++++ lib/awful/tag.lua.in
+@@ -374,7 +374,6 @@ capi.client.add_signal("manage", function(c, startup)
+             c.screen = capi.mouse.screen
+         end
+     end
+-    withcurrent(c, startup)
+     c:add_signal("property::screen", withcurrent)
+ end)
+ 
--- awesome-3.4.2_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->garga 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Dec 7 10:40:17 UTC 2009 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141244 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Dec 7 10:40:22 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141244 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: ntarmos@cs.uoi.gr
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/141244: [PATCH] x11-wm/awesome: Fix awful bug introduced in 3.4
Date: Mon, 7 Dec 2009 10:40:20 UT

 Maintainer of x11-wm/awesome,
 
 Please note that PR ports/141244 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141244
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Nikos Ntarmos <ntarmos@cs.uoi.gr>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/141244: [PATCH] x11-wm/awesome: Fix awful bug introduced
 in 3.4
Date: Wed, 16 Dec 2009 16:28:27 +0200

 Please commit. Thanks!
 
 \n\n

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/141244: commit references a PR
Date: Mon, 21 Dec 2009 10:37:08 +0000 (UTC)

 garga       2009-12-21 10:36:53 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-wm/awesome       Makefile 
   Added files:
     x11-wm/awesome/files patch-lib__awful__rules.lua.in 
                          patch-lib__awful__tag.lua.in 
   Log:
   Fix a bug on 3.4.x, Tag the new window before apply settings -- FS#664
   
   PR:             ports/141244
   Submitted by:   garga
   Approved by:    maintainer
   Obtained from:  Awesome FS#664
   
   Revision  Changes    Path
   1.37      +1 -0      ports/x11-wm/awesome/Makefile
   1.1       +23 -0     ports/x11-wm/awesome/files/patch-lib__awful__rules.lua.in (new)
   1.1       +10 -0     ports/x11-wm/awesome/files/patch-lib__awful__tag.lua.in (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: garga 
State-Changed-When: Mon Dec 21 11:08:10 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141244 
>Unformatted:
