From fluffy@FreeBSD.org  Wed Dec  2 10:44:21 2009
Return-Path: <fluffy@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B66A4106566B
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed,  2 Dec 2009 10:44:21 +0000 (UTC)
	(envelope-from fluffy@FreeBSD.org)
Received: from ns.ael.RU (ns.ael.ru [62.76.207.226])
	by mx1.freebsd.org (Postfix) with ESMTP id DCB098FC12
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed,  2 Dec 2009 10:44:20 +0000 (UTC)
Received: from Fluffy.Khv.RU (85.9.168.188.retail.ttk.ru [188.168.9.85] (may be forged))
	by ns.ael.RU (8.14.3/8.14.3/Fluffy/5.3) with ESMTP id nB2AiE5J038502
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed, 2 Dec 2009 20:44:16 +1000 (VLAT)
	(envelope-from fluffy@FreeBSD.org)
Received: from Fluffy.Khv.RU (localhost [127.0.0.1])
	by Fluffy.Khv.RU (8.14.3/8.14.3/Fluffy/5.4.1) with ESMTP id nB2AhnpJ089858
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 2 Dec 2009 20:43:49 +1000 (VLAT)
	(envelope-from fluffy@FreeBSD.org)
Message-Id: <1259750629.78472@Fluffy.Khv.RU>
Date: Wed, 2 Dec 2009 20:43:49 +1000
From: "Dima Panov" <fluffy@FreeBSD.org>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject: java/jdk16 (and possibly jdk15) build broken after r199827
X-Send-Pr-Version: gtk-send-pr 0.4.9 
X-GNATS-Notify:

>Number:         141105
>Category:       ports
>Synopsis:       java/jdk16 (and possibly jdk15) build broken after r199827
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    glewis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Dec 02 10:50:01 UTC 2009
>Closed-Date:    Fri Feb 05 05:22:56 UTC 2010
>Last-Modified:  Fri Feb  5 05:30:02 UTC 2010
>Originator:     Dima Panov
>Release:        FreeBSD 9.0-900002-CURRENT amd64
>Organization:
Fluffy.Khv.RU 
>Environment:


System: FreeBSD 9.0-900002-CURRENT #0: Wed Dec  2 05:03:55 VLAT 2009
    root@Fluffy.Khv.RU:/usr/obj/usr/src/sys/Spot



>Description:


java/jdk16 (and possibly jdk15 and other ports) build broken since r199827, which implements sighold, sigignore, sigpause, sigrelse, sigset functions from SUSv4 XSI.
But jdk patchset (bsd-jdk-patches) provide own realization of sigignore() for FreeBSD, and use system sigignore oly on NetBSD.

Patch uses osreldate >= 900002, cause r199827 not bumped osreldate, it need to be corrected.


>How-To-Repeat:


update to r199827 or later, try to build java/jdk16


>Fix:


--- jdk16.diff begins here ---
diff -urN /zroot/a/FreeBSD/Work/ports/java/jdk16/Makefile java/jdk16/Makefile
--- /zroot/a/FreeBSD/Work/ports/java/jdk16/Makefile	2009-11-09 08:48:33.000000000 +1000
+++ java/jdk16/Makefile	2009-12-02 19:47:56.198739813 +1000
@@ -284,6 +284,10 @@
 		${BZIP2_CMD} -dc ${DISTDIR}/${PATCHSETFILE} | ${TAR} -xf - && \
 		${CHMOD} -R u+w * && \
 		${PATCH} -p0 < ${WRKDIR}/jdk16.patches
+.if (${OSVERSION} >= 900002)
+	@cd ${WRKDIR} &&  \
+		${PATCH} -p2 < ${FILESDIR}/extrapatch-j2se-make-common-Defs-bsd.gmk
+.endif
 
 post-patch:
 	@for file in ${LOCAL_FILES}; do \
diff -urN /zroot/a/FreeBSD/Work/ports/java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk
--- /zroot/a/FreeBSD/Work/ports/java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk	1970-01-01 10:00:00.000000000 +1000
+++ java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk	2009-12-02 19:47:33.410582100 +1000
@@ -0,0 +1,11 @@
+--- ../../j2se/make/common/Defs-bsd.gmk.orig	2009-12-02 17:58:29.000000000 +1000
++++ ../../j2se/make/common/Defs-bsd.gmk	2009-12-02 18:50:16.981367494 +1000
+@@ -311,7 +311,7 @@
+ override HAVE_FILIOH             = false
+ override HAVE_GETHRTIME          = false
+ override HAVE_GETHRVTIME         = false
+-ifeq ($(OS_VENDOR),NetBSD)
++ifeq ($(OS_VENDOR),FreeBSD)
+ override HAVE_SIGIGNORE          = true
+ endif
+ ifeq ($(OS_VENDOR),Apple)
--- jdk16.diff ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->glewis 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Dec 2 10:50:37 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141105 

From: Dima Panov <fluffy@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
Cc:  
Subject: Re: ports/141105: java/jdk16 (and possibly jdk15) build broken after r199827
Date: Thu, 3 Dec 2009 03:34:31 +1000

 --nextPart27441777.5RFngVFnsb
 Content-Type: Text/Plain;
   charset="utf-8"
 Content-Transfer-Encoding: quoted-printable
 
 On Wednesday 02 December 2009 20:50:01 FreeBSD-gnats-submit@freebsd.org wro=
 te:
 > Thank you very much for your problem report.
 > It has the internal identification `ports/141105'.
 > The individual assigned to look at your
 > report is: freebsd-ports-bugs.
 >=20
 > You can access the state of your problem report at any time
 > via this link:
 >=20
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D141105
 >=20
 > >Category:       ports
 > >Responsible:    freebsd-ports-bugs
 > >Synopsis:       java/jdk16 (and possibly jdk15) build broken after r1998=
 27
 > >Arrival-Date:   Wed Dec 02 10:50:01 UTC 2009
 >=20
 kib@ bumped osreldate today to 900003 to reflect recent major changes, so
 patch was slightly modified to use correct value.
 Users, who catched the problems in these days (with 900002 os revsion), sho=
 uld upgrade.
 
 diff -urN /zroot/a/FreeBSD/Work/ports/java/jdk16/Makefile java/jdk16/Makefi=
 le
 =2D-- /zroot/a/FreeBSD/Work/ports/java/jdk16/Makefile	2009-11-09 08:48:33.0=
 00000000 +1000
 +++ java/jdk16/Makefile	2009-12-02 19:47:56.198739813 +1000
 @@ -284,6 +284,10 @@
  		${BZIP2_CMD} -dc ${DISTDIR}/${PATCHSETFILE} | ${TAR} -xf - && \
  		${CHMOD} -R u+w * && \
  		${PATCH} -p0 < ${WRKDIR}/jdk16.patches
 +.if (${OSVERSION} > 900002)
 +	@cd ${WRKDIR} &&  \
 +		${PATCH} -p2 < ${FILESDIR}/extrapatch-j2se-make-common-Defs-bsd.gmk
 +.endif
 =20
  post-patch:
  	@for file in ${LOCAL_FILES}; do \
 diff -urN /zroot/a/FreeBSD/Work/ports/java/jdk16/files/extrapatch-j2se-make=
 =2Dcommon-Defs-
 bsd.gmk java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk
 =2D-- /zroot/a/FreeBSD/Work/ports/java/jdk16/files/extrapatch-j2se-make-com=
 mon-Defs-bsd.gmk=09
 1970-01-01 10:00:00.000000000 +1000
 +++ java/jdk16/files/extrapatch-j2se-make-common-Defs-bsd.gmk	2009-12-02=20
 19:47:33.410582100 +1000
 @@ -0,0 +1,11 @@
 +--- ../../j2se/make/common/Defs-bsd.gmk.orig	2009-12-02 17:58:29.000000000=
  +1000
 ++++ ../../j2se/make/common/Defs-bsd.gmk	2009-12-02 18:50:16.981367494 +1000
 +@@ -311,7 +311,7 @@
 + override HAVE_FILIOH             =3D false
 + override HAVE_GETHRTIME          =3D false
 + override HAVE_GETHRVTIME         =3D false
 +-ifeq ($(OS_VENDOR),NetBSD)
 ++ifeq ($(OS_VENDOR),FreeBSD)
 + override HAVE_SIGIGNORE          =3D true
 + endif
 + ifeq ($(OS_VENDOR),Apple)
 
 
 =2D-=20
 Dima "Red Fox" Panov @ Home | C73E 2B72 1FFD 61BD E206 1234 A626 76ED 93E3 =
 B018
 Khabarovsk, Russia          | 2D30 2CCB 9984 130C 6F87 BAFC FB8B A09D D539 =
 8F29
 KDE@FreeBSD Team | FreeBSD committer since 10.08.2009 | FreeBSD since Sept =
 1995
 Twitter.com:fluffy_khv | Skype:dima.panov | Jabber.org:fluffy.khv | ICQ:174=
 5024
 
 --nextPart27441777.5RFngVFnsb
 Content-Type: application/pgp-signature; name=signature.asc 
 Content-Description: This is a digitally signed message part.
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.13 (FreeBSD)
 
 iEYEABECAAYFAksWpSgACgkQpiZ27ZPjsBjRMwCgis+wbVrx+gAzyHdx5OT7z1Qk
 MWEAnAtaY6+G99oOnEZneBd/oBN5uaMo
 =ksPZ
 -----END PGP SIGNATURE-----
 
 --nextPart27441777.5RFngVFnsb--

From: Dima Panov <fluffy@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org, freebsd-ports-bugs@freebsd.org
Cc: glewis@freebsd.org
Subject: Re: ports/141105: java/jdk16 (and possibly jdk15) build broken after r199827
Date: Mon, 1 Feb 2010 21:38:49 +1000

 On Wednesday 02 December 2009 20:50:01 you wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `ports/141105'.
 > The individual assigned to look at your
 > report is: freebsd-ports-bugs.
 > 
 > You can access the state of your problem report at any time
 > via this link:
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=141105
 > 
 > >Category:       ports
 > >Responsible:    freebsd-ports-bugs
 > >Synopsis:       java/jdk16 (and possibly jdk15) build broken after r199827
 > >Arrival-Date:   Wed Dec 02 10:50:01 UTC 2009
 
 Is there any responsible person?
 
 -- 
 Dima "Red Fox" Panov @ Home | C73E 2B72 1FFD 61BD E206 1234 A626 76ED 93E3 B018
 Khabarovsk, Russia          | 2D30 2CCB 9984 130C 6F87 BAFC FB8B A09D D539 8F29
 KDE@FreeBSD Team | FreeBSD committer since 10.08.2009 | FreeBSD since Sept 1995
 Twitter.com:fluffy_khv | Skype:dima.panov | Jabber.org:fluffy.khv | ICQ:1745024
State-Changed-From-To: open->feedback 
State-Changed-By: glewis 
State-Changed-When: Tue Feb 2 07:09:19 UTC 2010 
State-Changed-Why:  
Sorry for the delay. 

Note that you also have OS_VERSION to work with in Defs-bsd.gmk, so you 
should be able to come up with a patch doesn't require extra Makefile 
changes to work.  OS_VERSION is defined, in the jdk16 build as the output 
of uname -r.  Have you got time to update the patch to do something along 
those lines? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141105 
State-Changed-From-To: feedback->closed 
State-Changed-By: glewis 
State-Changed-When: Fri Feb 5 05:22:55 UTC 2010 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141105 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/141105: commit references a PR
Date: Fri,  5 Feb 2010 05:22:39 +0000 (UTC)

 glewis      2010-02-05 05:22:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     java/jdk16/files     patch-j2se-common-Defs-bsd.gmk 
   Log:
   . Detect that recent versions of 9-CURRENT have sigignore(3) and configure
     the build correctly for that.
   
     Fixes the build on those versions of 9-CURRENT
   
   PR:                     141105
   Collaboration with:     fluffy@
   
   Revision  Changes    Path
   1.3       +16 -2     ports/java/jdk16/files/patch-j2se-common-Defs-bsd.gmk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
