From glewis@misty.eyesbeyond.com  Sun Nov 29 20:37:07 2009
Return-Path: <glewis@misty.eyesbeyond.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 10A78106568D
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Nov 2009 20:37:07 +0000 (UTC)
	(envelope-from glewis@misty.eyesbeyond.com)
Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16])
	by mx1.freebsd.org (Postfix) with ESMTP id CF1198FC1B
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Nov 2009 20:37:06 +0000 (UTC)
Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1])
	by misty.eyesbeyond.com (8.14.3/8.14.3) with ESMTP id nATKb4LU031847;
	Sun, 29 Nov 2009 12:37:05 -0800 (PST)
	(envelope-from glewis@misty.eyesbeyond.com)
Received: (from glewis@localhost)
	by misty.eyesbeyond.com (8.14.3/8.14.3/Submit) id nATKb4ij031846;
	Sun, 29 Nov 2009 12:37:04 -0800 (PST)
	(envelope-from glewis)
Message-Id: <200911292037.nATKb4ij031846@misty.eyesbeyond.com>
Date: Sun, 29 Nov 2009 12:37:04 -0800 (PST)
From: Greg Lewis <glewis@misty.eyesbeyond.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: uqs@spoerlein.net
Subject: [PATCH] games/bsdgames: Convert pre-install to pre-su-install
X-Send-Pr-Version: 3.113
X-GNATS-Notify: uqs@spoerlein.net

>Number:         141002
>Category:       ports
>Synopsis:       [PATCH] games/bsdgames: Convert pre-install to pre-su-install
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glewis
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 29 20:40:02 UTC 2009
>Closed-Date:    Mon Nov 30 14:01:52 UTC 2009
>Last-Modified:  Mon Nov 30 14:10:01 UTC 2009
>Originator:     Greg Lewis
>Release:        FreeBSD 7.2-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD misty.eyesbeyond.com 7.2-RELEASE-p4 FreeBSD 7.2-RELEASE-p4 #0: Sat Oct  3 22:52:58 PDT
>Description:

The pre-install target creates directories under /var/games (by default).
Doing so requires root privileges, so the pre-install target should be
pre-su-install instead to ensure these privileges are available.

Port maintainer (uqs@spoerlein.net) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- bsdgames-2.4_1,1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /var/fcvs/ports/games/bsdgames/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- Makefile	26 Nov 2009 14:45:24 -0000	1.24
+++ Makefile	29 Nov 2009 20:25:38 -0000
@@ -96,7 +96,7 @@
 # Only useful for DESTDIR
 VARDIR?=	/var
 
-pre-install:
+pre-su-install:
 	${MKDIR} ${VARDIR}
 	mtree -deU -f ${FILESDIR}/var.mtree -p ${VARDIR}
 	mtree -deU -f ${FILESDIR}/share.mtree -p ${PREFIX}/share
--- bsdgames-2.4_1,1.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Nov 29 20:40:13 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141002 
Responsible-Changed-From-To: freebsd-ports-bugs->glewis 
Responsible-Changed-By: glewis 
Responsible-Changed-When: Sun Nov 29 20:44:41 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141002 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: uqs@spoerlein.net
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/141002: [PATCH] games/bsdgames: Convert pre-install to pre-su-install
Date: Sun, 29 Nov 2009 20:40:09 UT

 Maintainer of games/bsdgames,
 
 Please note that PR ports/141002 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/141002
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Mon Nov 30 08:26:27 UTC 2009 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141002 

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/141002: [PATCH] games/bsdgames: Convert pre-install to
	pre-su-install
Date: Mon, 30 Nov 2009 02:27:04 -0600

 ----- Forwarded message from Ulrich Sprlein <uqs@spoerlein.net> -----
 
 From: Ulrich Sprlein <uqs@spoerlein.net>
 To: glewis@FreeBSD.org
 Mail-Followup-To: Ulrich Sprlein <uqs@spoerlein.net>, glewis@FreeBSD.org,
 	freebsd-ports-bugs@FreeBSD.org
 Cc: freebsd-ports-bugs@FreeBSD.org
 Subject: Re: ports/141002: [PATCH] games/bsdgames: Convert pre-install to
 	pre-su-install
 
 Thanks Greg!
 
 Patch is approved, I didn't even know pre-install was running non-su :(
 
 Cheers,
 Uli
 _______________________________________________
 freebsd-ports-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
 To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
 
 
 ----- End forwarded message -----
State-Changed-From-To: open->closed 
State-Changed-By: glewis 
State-Changed-When: Mon Nov 30 14:01:50 UTC 2009 
State-Changed-Why:  
Thanks Ulrich!  I've committed the change. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141002 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/141002: commit references a PR
Date: Mon, 30 Nov 2009 14:05:39 +0000 (UTC)

 glewis      2009-11-30 14:01:04 UTC
 
   FreeBSD ports repository
 
   Modified files:
     games/bsdgames       Makefile 
   Log:
   . pre-install -> pre-su-install since it creates directories in /var/games.
   
   PR:             141002
   Approved by:    Ulrich Spoerlein (maintainer)
   
   Revision  Changes    Path
   1.25      +1 -1      ports/games/bsdgames/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
