From lioux@uol.com.br  Sun Nov 22 20:46:56 2009
Return-Path: <lioux@uol.com.br>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7B77D1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Nov 2009 20:46:56 +0000 (UTC)
	(envelope-from lioux@uol.com.br)
Received: from goat.gigo.com (ipv6.gigo.com [IPv6:2001:470:1:18::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 655A58FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Nov 2009 20:46:56 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by goat.gigo.com (Postfix) with ESMTP id 38B47893A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Nov 2009 12:46:56 -0800 (PST)
Received: from goat.gigo.com ([127.0.0.1])
	by localhost (vette.gigo.com [127.0.0.1]) (amavisd-new, port 10023)
	with ESMTP id 6snG-2zskW9W for <FreeBSD-gnats-submit@freebsd.org>;
	Sun, 22 Nov 2009 12:46:56 -0800 (PST)
Received: from 200.101.51.149 (200-101-51-149.bsace702.dsl.brasiltelecom.net.br [200.101.51.149])
	by goat.gigo.com (Postfix) with ESMTPSA id B4AF7654E
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 22 Nov 2009 12:46:55 -0800 (PST)
Received: (qmail 74690 invoked by uid 1001); 22 Nov 2009 18:42:55 -0200
Message-Id: <20091122204255.74682.qmail@exxodus.fedaykin.here>
Date: 22 Nov 2009 18:42:55 -0200
From: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: chalpin@cs.wisc.edu
Subject: [PATCH] mail/crm114: Fix build on systems where GCC stack protection was enabled for userland
X-Send-Pr-Version: 3.113
X-GNATS-Notify: chalpin@cs.wisc.edu

>Number:         140790
>Category:       ports
>Synopsis:       [PATCH] mail/crm114: Fix build on systems where GCC stack protection was enabled for userland
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lioux
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 22 20:50:00 UTC 2009
>Closed-Date:    Mon Sep 06 11:37:57 UTC 2010
>Last-Modified:  Mon Sep 06 11:37:57 UTC 2010
>Originator:     Mario Sergio Fujikawa Ferreira
>Release:        FreeBSD 8.0-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD exxodus.fedaykin.here 8.0-PRERELEASE FreeBSD 8.0-PRERELEASE #4: Sun Nov 15 10:14:26 BRST 2009
>Description:
- Fix build on systems (FreeBSD 8+) where GCC stack protection (aka
  Propolice) was enabled for userland on src/share/mk/bsd.sys.mk
  (SVN rev 180012 on 2008-06-25 21:33:28Z by ru)
- For OSVERSION >= 800040, add -fstack-protector to LDFLAGS

Port maintainer (chalpin@cs.wisc.edu) is cc'd.
>How-To-Repeat:
>Fix:

--- crm114-20090423.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/mail/crm114/Makefile,v
retrieving revision 1.27
diff -d -u -u -r1.27 Makefile
--- Makefile	13 May 2009 16:03:16 -0000	1.27
+++ Makefile	22 Nov 2009 20:42:03 -0000
@@ -50,6 +50,13 @@
 
 .include <bsd.port.pre.mk>
 
+# Around the time GCC stack protection (aka Propolice) for userland
+# was enabled on src/share/mk/bsd.sys.mk
+# SVN rev 180012 on 2008-06-25 21:33:28Z by ru
+.if ${OSVERSION} >= 800040
+LDFLAGS+=	-fstack-protector
+.endif
+
 .if defined(WITH_PGO)
 MAKE_ARGS+=	CFLAGS="${CFLAGS} -fprofile-use" \
 		LDFLAGS="${LDFLAGS} -fprofile-use"
--- crm114-20090423.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lioux 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Nov 22 20:50:09 UTC 2009 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140790 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Nov 22 20:50:13 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140790 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: chalpin@cs.wisc.edu
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/140790: [PATCH] mail/crm114: Fix build on systems where GCC stack protection was enabled for userland
Date: Sun, 22 Nov 2009 20:50:11 UT

 Maintainer of mail/crm114,
 
 Please note that PR ports/140790 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/140790
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Corey Halpin <chalpin@cs.wisc.edu>
To: bug-followup@FreeBSD.ORG
Cc:  
Subject: Re: ports/140790: [PATCH] mail/crm114: Fix build on systems where
	GCC stack protection was enabled for userland
Date: Sun, 22 Nov 2009 14:58:42 -0600

 --opJtzjQTFsWo+cga
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On 2009-11-22, Edwin Groothuis wrote:
 > Maintainer of mail/crm114,
 >=20
 > Please note that PR ports/140790 has just been submitted.
 >=20
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >=20
 > The full text of the PR can be found at:
 >     http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/140790
 
 Looks good.  Approve.
 
 ~crh
 
 --opJtzjQTFsWo+cga
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (Darwin)
 
 iEYEARECAAYFAksJpgIACgkQQ/a2GD73knuU4wCfaJjuSn/3qU9076spFSdM9lR7
 RlcAn0X7TtpTzZvAsysOwESt8zGo/8aN
 =U+cR
 -----END PGP SIGNATURE-----
 
 --opJtzjQTFsWo+cga--
State-Changed-From-To: feedback->closed 
State-Changed-By: lioux 
State-Changed-When: Mon Sep 6 11:37:56 UTC 2010 
State-Changed-Why:  
A fix has been available on the 8-STABLE branch for a while now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140790 
>Unformatted:
