From nobody@FreeBSD.org  Sat Nov 14 00:41:33 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 13C9B106568D
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 14 Nov 2009 00:41:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id DC3828FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 14 Nov 2009 00:41:32 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nAE0fWOs013724
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 14 Nov 2009 00:41:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nAE0fWFS013700;
	Sat, 14 Nov 2009 00:41:32 GMT
	(envelope-from nobody)
Message-Id: <200911140041.nAE0fWFS013700@www.freebsd.org>
Date: Sat, 14 Nov 2009 00:41:32 GMT
From: Benjamin Lee <ben@b1c1l1.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/isc-cron should be compatible with cron from base
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: edwin@mavetju.org

>Number:         140542
>Category:       ports
>Synopsis:       sysutils/isc-cron should be compatible with cron from base
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    edwin
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 14 00:50:01 UTC 2009
>Closed-Date:    
>Last-Modified:  Sun Sep 12 04:07:27 UTC 2010
>Originator:     Benjamin Lee
>Release:        7.2-RELEASE
>Organization:
>Environment:
FreeBSD eclipse.b1c1l1.com 7.2-RELEASE-p4 FreeBSD 7.2-RELEASE-p4 #0: Fri Oct  2 12:21:39 UTC 2009     root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
sysutils/isc-cron does not currently function as a drop-in replacement for cron from base:

1. It expects permissions on crontab to be 0600, rather than 0644.
2. It uses "cron.allow" and "cron.deny" rather than "allow" and "deny".
3. It defines LOG_FILE.

The attached patches correct these inconsistencies.
>How-To-Repeat:
Install sysutils/isc-cron from ports.
>Fix:
Apply the attached patches.

Patch attached with submission follows:

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	patch-database.c
#	patch-pathnames.h
#
echo x - patch-database.c
sed 's/^X//' >patch-database.c << 'afd7d714fa4cc3f21fc8bef1eb337368'
Xdiff -ru isc-cron-4.1.orig/database.c isc-cron-4.1/database.c
X--- database.c	2009-10-01 17:40:45.000000000 -0700
X+++ database.c	2009-10-01 17:41:08.000000000 -0700
X@@ -206,7 +206,7 @@
X 		log_it(fname, getpid(), "NOT REGULAR", tabname);
X 		goto next_crontab;
X 	}
X-	if ((statbuf->st_mode & 07777) != 0600) {
X+	if ((statbuf->st_mode & 07777) != 0644) {
X 		log_it(fname, getpid(), "BAD FILE MODE", tabname);
X 		goto next_crontab;
X 	}
afd7d714fa4cc3f21fc8bef1eb337368
echo x - patch-pathnames.h
sed 's/^X//' >patch-pathnames.h << 'f86e2db0fe768f1b7c2a578357e47d80'
Xdiff -ru isc-cron-4.1.orig/pathnames.h isc-cron-4.1/pathnames.h
X--- pathnames.h	2009-10-01 16:51:26.000000000 -0700
X+++ pathnames.h	2009-10-01 17:01:10.000000000 -0700
X@@ -51,8 +51,8 @@
X 			/* cron allow/deny file.  At least cron.deny must
X 			 * exist for ordinary users to run crontab.
X 			 */
X-#define	CRON_ALLOW	"cron.allow"
X-#define	CRON_DENY	"cron.deny"
X+#define	CRON_ALLOW	"allow"
X+#define	CRON_DENY	"deny"
X 
X 			/* undefining this turns off logging to a file.  If
X 			 * neither LOG_FILE or SYSLOG is defined, we don't log.
X@@ -60,7 +60,7 @@
X 			 * LOG_CRON is defined by <syslog.h>, LOG_FILE will not
X 			 * be used.
X 			 */
X-#define LOG_FILE	"log"
X+/*#define LOG_FILE	"log"*/
X 
X 			/* where should the daemon stick its PID?
X 			 * PIDDIR must end in '/'.
f86e2db0fe768f1b7c2a578357e47d80
exit



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->edwin 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Nov 14 00:50:11 UTC 2009 
Responsible-Changed-Why:  
edwin@mavetju.org => edwin@ (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140542 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sat Nov 14 00:50:15 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140542 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: edwin@mavetju.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/140542: sysutils/isc-cron should be compatible with cron from base
Date: Sat, 14 Nov 2009 00:50:13 UT

 Maintainer of sysutils/isc-cron,
 
 Please note that PR ports/140542 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/140542
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Benjamin Lee <ben@b1c1l1.com>
To: bug-followup@FreeBSD.org, ben@b1c1l1.com
Cc:  
Subject: Re: ports/140542: sysutils/isc-cron should be compatible with cron
 from base
Date: Thu, 29 Jul 2010 18:15:06 -0700

 This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
 --------------enig17E7F79DDFC032B6EF12C0BF
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Hello,
 
 This PR has exceeded maintainer timeout.
 
 
 --=20
 Benjamin Lee
 http://www.b1c1l1.com/
 
 
 --------------enig17E7F79DDFC032B6EF12C0BF
 Content-Type: application/pgp-signature; name="signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.16 (GNU/Linux)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
 iQIcBAEBAgAGBQJMUiemAAoJEHBW16CPoSMCvqoQALDdBXD2M50YkLnyLBnwjrQT
 /JmBav5CamBD0kFFlwLXJk6NycqsgCVlUD/Ato6zpaFeK9VN/kRultoMeyb40ksD
 K0W39+nVziw1vZJ3aMHg4b9f9rwI7lzTzyT1ukLTANNo3JWYSuDKR5wBRvoGr1tI
 zsUs7naZlGbaTQla+JfP57ZZgFIMUj60WiheQvH91fxOtcUyUkl9/16aGLcLH08j
 lvwM9DY6DcWcImqbrdW+GSCxNfGykNVr8ChUqI1tN3F0SGC10gmfH2u3yjG0xlZu
 ohSVkpxl7kHt/dKJjm07wIEWdb+59dyFeF9EpogNXOtIVoLJ3IFbxgbq212ETW9/
 a0oZUNL+LteKsYUD9SdprOXfFU8Jsm2cKp21thcj4G9xrD6G5PvNMiQphf2OoYT5
 fsz/6rSA7meR2gQLABLs5TnAF1nO8Awf5MRcwzV2UQtileJ3MAs+iz8TUoppt5op
 xSqt/h6P33Nzpw468fN6XkwBuq5mn/3PSkVuMTiAnJlzzP6Pjd4ZH0giu6dh6nsk
 tQz/hbE0FhKWzwYnfeTz5OD/GY8zN8jutC4vyfT8G5NSsmofH1S+F5//+k940n18
 A3dr5ktE1H9Ola/8yJMo5KTfTw2ewzF/000xJh00ILhX27TphrHxRTNArkmPxX5A
 MKgh7b72Ni+My4d3IYvq
 =MIN3
 -----END PGP SIGNATURE-----
 
 --------------enig17E7F79DDFC032B6EF12C0BF--
State-Changed-From-To: feedback->open 
State-Changed-By: pgollucci 
State-Changed-When: Sun Sep 12 04:07:26 UTC 2010 
State-Changed-Why:  
maintainer timeout (edwin@mavetju.org ; 44 days) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140542 
>Unformatted:
