From mjl@luckie.org.nz  Mon Nov  9 20:34:50 2009
Return-Path: <mjl@luckie.org.nz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B4E37106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Nov 2009 20:34:50 +0000 (UTC)
	(envelope-from mjl@luckie.org.nz)
Received: from mailfilter66.ihug.co.nz (mailfilter66.ihug.co.nz [203.109.136.66])
	by mx1.freebsd.org (Postfix) with ESMTP id 520778FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  9 Nov 2009 20:34:49 +0000 (UTC)
Received: from 118-93-74-195.dsl.dyn.ihug.co.nz (HELO spandex.luckie.org.nz) ([118.93.74.195])
  by smtp.mailfilter2.ihug.co.nz with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Nov 2009 09:04:57 +1300
Received: from mjl by spandex.luckie.org.nz with local (Exim 4.69 (FreeBSD))
	(envelope-from <mjl@luckie.org.nz>)
	id 1N7aTw-0000xP-7z
	for FreeBSD-gnats-submit@freebsd.org; Tue, 10 Nov 2009 09:04:56 +1300
Message-Id: <E1N7aTw-0000xP-7z@spandex.luckie.org.nz>
Date: Tue, 10 Nov 2009 09:04:56 +1300
From: Matthew Luckie <mjl@luckie.org.nz>
Reply-To: Matthew Luckie <mjl@luckie.org.nz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: net/pptpclient 1.7.2_3 is broken
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         140432
>Category:       ports
>Synopsis:       net/pptpclient 1.7.2_3 is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lippe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 09 20:40:01 UTC 2009
>Closed-Date:    Fri Nov 20 21:49:57 UTC 2009
>Last-Modified:  Fri Nov 20 21:50:01 UTC 2009
>Originator:     Matthew Luckie
>Release:        FreeBSD 7.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD spandex.luckie.org.nz 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Mon Jul 27 19:48:00 NZST 2009 root@spandex.luckie.org.nz:/usr/src/sys/i386/compile/spandex i386

Ports are up to date as of now.

>Description:

When I updated net/pptpclient from 1.7.2_2 to 1.7.2_3 it stopped working.
Downgrading back to 1.7.2_2 works fine.

I use pptpclient as follows:

/usr/local/sbin/pptp 192.168.0.2 adsl

where adsl is a ppp label that handles login to my adsl provider.

ppp.conf as follows:

default:
 set log Phase Chat LCP IPCP CCP tun command
 ident user-ppp VERSION (built COMPILATIONDATE)

adsl:
 set authname foo 
 set authkey bar 
 set timeout 0
 set ifaddr 0 0
 #enable dns
 add default HISADDR

/var/log/messages when pptp is broken 1.7.2_3:

Nov 10 08:09:27 spandex pptp[1534]: anon log[main:pptp.c:314]: The synchronous pptp option is NOT activated
Nov 10 08:09:27 spandex pptp[1542]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 1 'Start-Control-Connection-Request'
Nov 10 08:09:27 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:739]: Received Start Control Connection Reply
Nov 10 08:09:27 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:773]: Client connection established.
Nov 10 08:09:28 spandex pptp[1542]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 7 'Outgoing-Call-Request'
Nov 10 08:09:28 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:858]: Received Outgoing Call Reply.
Nov 10 08:09:28 spandex pptp[1534]: anon fatal[main:pptp.c:361]: Could not launch pppd
Nov 10 08:09:28 spandex pptp[1542]: anon log[ctrlp_disp:pptp_ctrl.c:897]: Outgoing call established (call ID 0, peer's call ID 0).
Nov 10 08:09:30 spandex pptp[1543]: anon warn[decaps_hdlc:pptp_gre.c:204]: short read (0): Invalid argument
Nov 10 08:09:30 spandex pptp[1542]: anon log[callmgr_main:pptp_callmgr.c:234]: Closing connection (unhandled)
Nov 10 08:09:30 spandex pptp[1542]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 12 'Call-Clear-Request'
Nov 10 08:09:30 spandex pptp[1542]: anon log[call_callback:pptp_callmgr.c:79]: Closing connection (call state)

/var/log/messages when pptp is fixed 1.7.2_2:

Nov 10 08:29:46 spandex pptp[3272]: anon log[main:pptp.c:314]: The synchronous pptp option is NOT activated
Nov 10 08:29:46 spandex pptp[3280]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 1 'Start-Control-Connection
-Request'
Nov 10 08:29:46 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:739]: Received Start Control Connection Reply
Nov 10 08:29:46 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:773]: Client connection established.
Nov 10 08:29:47 spandex pptp[3280]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 7 'Outgoing-Call-Request'
Nov 10 08:29:47 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:858]: Received Outgoing Call Reply.
Nov 10 08:29:47 spandex pptp[3280]: anon log[ctrlp_disp:pptp_ctrl.c:897]: Outgoing call established (call ID 0, peer's call ID 0
).
Nov 10 08:29:51 spandex ppp[3272]: tun0: Warning: 0.0.0.0/0: Change route failed: errno: No such process
Nov 10 08:29:51 spandex ppp[3272]: tun0: Warning: ff02:5::/32: Change route failed: errno: Network is unreachable
Nov 10 08:30:37 spandex pptp[3280]: anon log[logecho:pptp_ctrl.c:677]: Echo Request received.
Nov 10 08:30:37 spandex pptp[3280]: anon log[ctrlp_rep:pptp_ctrl.c:251]: Sent control packet type is 6 'Echo-Reply'

>How-To-Repeat:

Upgrade from 1.7.2_2 to 1.7.2_3

>Fix:

Downgrade to 1.7.2_2


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->lippe 
Responsible-Changed-By: lippe 
Responsible-Changed-When: Mon Nov 9 21:08:18 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140432 
State-Changed-From-To: open->closed 
State-Changed-By: lippe 
State-Changed-When: Fri Nov 20 21:49:55 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140432 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/140432: commit references a PR
Date: Fri, 20 Nov 2009 21:49:38 +0000 (UTC)

 lippe       2009-11-20 21:49:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/pptpclient       Makefile 
   Log:
   - Revert last changes, that cause port broken.
   
   PR:             ports/140432
   Noticed by:     Matthew Luckie <mjl@luckie.org.nz>
   
   Revision  Changes    Path
   1.24      +6 -19     ports/net/pptpclient/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
