From nobody@FreeBSD.org  Sun Oct 25 07:41:43 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A118106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Oct 2009 07:41:43 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 28C048FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Oct 2009 07:41:43 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n9P7fgn3058603
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 25 Oct 2009 07:41:42 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n9P7fgHa058599;
	Sun, 25 Oct 2009 07:41:42 GMT
	(envelope-from nobody)
Message-Id: <200910250741.n9P7fgHa058599@www.freebsd.org>
Date: Sun, 25 Oct 2009 07:41:42 GMT
From: Denny Lin <dennylin93@cnmc32.hs.ntnu.edu.tw>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Add missing dependency to graphics/evince
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         139941
>Category:       ports
>Synopsis:       [PATCH] Add missing dependency to graphics/evince
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnome
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 25 07:50:01 UTC 2009
>Closed-Date:    Sat Nov 28 20:22:06 UTC 2009
>Last-Modified:  Sat Nov 28 20:22:06 UTC 2009
>Originator:     Denny Lin
>Release:        FreeBSD 7.2-RELEASE-p3
>Organization:
>Environment:
FreeBSD cnmc32.hs.ntnu.edu.tw 7.2-RELEASE-p3 FreeBSD 7.2-RELEASE-p3 #0: Sat Sep 19 14:31:04 CST 2009     root@cnmc32.hs.ntnu.edu.tw:/usr/obj/usr/src/sys/FUSION  amd64
>Description:
The Makefile of graphics/evince seems to be missing a dependency (graphics/openjpeg). Evince requires libopenjpeg.so.2 to run ($ ldd /usr/local/bin/evince).
>How-To-Repeat:
1. Install graphics/evince.
2. Deinstall graphics/openjpeg (user isn't notified about dependency).
3. Run Evince.
>Fix:
See patch.

Patch attached with submission follows:

--- graphics/evince/Makefile.orig	2009-10-25 15:32:43.000000000 +0800
+++ graphics/evince/Makefile	2009-10-25 15:35:40.000000000 +0800
@@ -17,7 +17,8 @@
 COMMENT=	GNOME 2 multi-format document viewer
 
 LIB_DEPENDS=	poppler-glib.4:${PORTSDIR}/graphics/poppler-gtk \
-		spectre.1:${PORTSDIR}/print/libspectre
+		spectre.1:${PORTSDIR}/print/libspectre \
+		libopenjpeg.2:${PORTSDIR}/graphics/openjpeg
 
 USE_LDCONFIG=	yes
 USE_BZIP2=	yes


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->gnome 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Oct 25 07:50:12 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139941 

From: Anonymous <swell.k@gmail.com>
To: Denny Lin <dennylin93@cnmc32.hs.ntnu.edu.tw>
Cc: bug-followup@freebsd.org
Subject: Re: ports/139941: [PATCH] Add missing dependency to graphics/evince
Date: Sun, 25 Oct 2009 15:51:33 +0300

 Denny Lin <dennylin93@cnmc32.hs.ntnu.edu.tw> writes:
 
 >>Description:
 > The Makefile of graphics/evince seems to be missing a dependency (graphics/openjpeg). Evince requires libopenjpeg.so.2 to run ($ ldd /usr/local/bin/evince).
 >>How-To-Repeat:
 > 1. Install graphics/evince.
 > 2. Deinstall graphics/openjpeg (user isn't notified about dependency).
 > 3. Run Evince.
 
 Can't reproduce here. However, if I do
 
 1. install graphics/openjpeg
 2. install graphics/poppler*
 
 prior your first step then I *can*.
 
 Found by
 
     $ cd graphics/poppler
     $ make extract
     $ fgrep -ir openjpeg work/
 
 >>Fix:
 > See patch.
 >
 > Patch attached with submission follows:
 >
 > --- graphics/evince/Makefile.orig	2009-10-25 15:32:43.000000000 +0800
 > +++ graphics/evince/Makefile	2009-10-25 15:35:40.000000000 +0800
 > @@ -17,7 +17,8 @@
 >  COMMENT=	GNOME 2 multi-format document viewer
 >  
 >  LIB_DEPENDS=	poppler-glib.4:${PORTSDIR}/graphics/poppler-gtk \
 > -		spectre.1:${PORTSDIR}/print/libspectre
 > +		spectre.1:${PORTSDIR}/print/libspectre \
 > +		libopenjpeg.2:${PORTSDIR}/graphics/openjpeg
 
 Please, don't make it a hard dependency. I for one don't need JPEG 2000
 support in poppler/evince.
 
 >  
 >  USE_LDCONFIG=	yes
 >  USE_BZIP2=	yes
 >
 >
State-Changed-From-To: open->patched 
State-Changed-By: marcus 
State-Changed-When: Sun Oct 25 17:00:36 UTC 2009 
State-Changed-Why:  
The problem is actually with poppler, not evince.  I have added an optional 
dependency on OpenJPEG to poppler-0.12 which will be committed with GNOME 
2.28 after 8.0 is released. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139941 
State-Changed-From-To: patched->closed 
State-Changed-By: marcus 
State-Changed-When: Sat Nov 28 20:21:45 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139941 
>Unformatted:
