From tijl@kalimero.kotnet.org  Sat Oct 24 12:50:20 2009
Return-Path: <tijl@kalimero.kotnet.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5A2E1106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Oct 2009 12:50:20 +0000 (UTC)
	(envelope-from tijl@kalimero.kotnet.org)
Received: from mailrelay002.isp.belgacom.be (mailrelay002.isp.belgacom.be [195.238.6.175])
	by mx1.freebsd.org (Postfix) with ESMTP id ECEC08FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Oct 2009 12:50:19 +0000 (UTC)
Received: from 242.44-245-81.adsl-dyn.isp.belgacom.be (HELO kalimero.kotnet.org) ([81.245.44.242])
  by relay.skynet.be with ESMTP; 24 Oct 2009 14:50:18 +0200
Received: from kalimero.kotnet.org (kalimero.kotnet.org [127.0.0.1])
	by kalimero.kotnet.org (8.14.3/8.14.3) with ESMTP id n9OCllEw064765
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 24 Oct 2009 14:47:47 +0200 (CEST)
	(envelope-from tijl@kalimero.kotnet.org)
Received: (from tijl@localhost)
	by kalimero.kotnet.org (8.14.3/8.14.3/Submit) id n9OCllGp064764;
	Sat, 24 Oct 2009 14:47:47 +0200 (CEST)
	(envelope-from tijl)
Message-Id: <200910241247.n9OCllGp064764@kalimero.kotnet.org>
Date: Sat, 24 Oct 2009 14:47:47 +0200 (CEST)
From: Tijl Coosemans <tijl@ulyssis.org>
Reply-To: Tijl Coosemans <tijl@ulyssis.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: audio/akode: fix dependency on libltdl
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         139884
>Category:       ports
>Synopsis:       audio/akode: fix dependency on libltdl
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kde
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Oct 24 13:00:13 UTC 2009
>Closed-Date:    Sat Oct 24 16:44:41 UTC 2009
>Last-Modified:  Sat Oct 24 16:50:01 UTC 2009
>Originator:     Tijl Coosemans
>Release:        FreeBSD 7.2-STABLE i386
>Organization:
>Environment:
>Description:
In the audio/akode Makefile the USE_AUTOTOOLS variable is assigned twice
thereby erasing the dependency on libltdl.
>How-To-Repeat:
>Fix:
The first patch fixes the USE_AUTOTOOLS assignment.
The second patch is an attempt to simplify the Makefile and fix
some portlint warnings.

--- patch-akode begins here ---
--- Makefile.orig	2009-10-24 13:07:24.000000000 +0200
+++ Makefile	2009-10-24 13:42:07.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	akode
 PORTVERSION=	2.0.2
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	audio kde
 MASTER_SITES=	${MASTER_SITE_GENTOO}
@@ -27,8 +28,7 @@
 		RESAMPLER "Resampler processing plugin" on \
 		XIPH "FLAC/Speex/Vorbis decoder plugin" on
 
-USE_AUTOTOOLS=	libltdl
-USE_AUTOTOOLS=  libtool:22
+USE_AUTOTOOLS=	libtool:22 libltdl
 USE_BZIP2=	yes
 USE_GMAKE=	yes
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
--- patch-akode ends here ---

--- patch-akode2 begins here ---
--- Makefile.orig	2009-10-24 13:43:00.000000000 +0200
+++ Makefile	2009-10-24 14:21:55.000000000 +0200
@@ -12,8 +12,7 @@
 CATEGORIES=	audio kde
 MASTER_SITES=	${MASTER_SITE_GENTOO}
 MASTER_SITE_SUBDIR=distfiles
-DISTNAME=	30375-${PORTNAME}-${PORTVERSION}.tar.bz2
-EXTRACT_SUFX=	# none
+DISTFILES=	30375-${DISTNAME}${EXTRACT_SUFX}
 
 MAINTAINER=	kde@FreeBSD.org
 COMMENT=	Default KDE audio backend
@@ -31,7 +30,6 @@
 USE_AUTOTOOLS=	libtool:22 libltdl
 USE_BZIP2=	yes
 USE_GMAKE=	yes
-WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 USE_LDCONFIG=	yes
 PLIST_SUB+=	MACHINE_ARCH=${MACHINE_ARCH}
 
@@ -39,10 +37,10 @@
 		--with-extra-libs=${LOCALBASE}/lib \
 		--with-extra-includes=${LOCALBASE}/include
 
-.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
 
 .if defined(WITH_FFMPEG)
-RUN_DEPENDS=	${LOCALBASE}/lib/libakode_ffmpeg_decoder.so:${PORTSDIR}/audio/akode-plugins-ffmpeg
+RUN_DEPENDS+=	${LOCALBASE}/lib/libakode_ffmpeg_decoder.so:${PORTSDIR}/audio/akode-plugins-ffmpeg
 .endif
 
 .if defined(WITH_JACK)
@@ -76,10 +74,4 @@
 	$$(all_libraries) ${PTHREAD_LIBS}|g' \
 		${WRKSRC}/akode/akodeplay/Makefile.in
 
-do-build:
-	cd ${WRKSRC}/akode && ${GMAKE}
-
-do-install:
-	cd ${WRKSRC}/akode && ${GMAKE} install
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
--- patch-akode2 ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->kde 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sat Oct 24 13:00:26 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139884 

From: "Jeremy Messenger" <mezz7@cox.net>
To: bug-followup@freebsd.org, tijl@ulyssis.org
Cc:  
Subject: Re: ports/139884: audio/akode: fix dependency on libltdl
Date: Sat, 24 Oct 2009 10:56:52 -0500

 Before anyone commit this patch. Make sure to add ':22' in the libltdl, ie:
 
 -USE_AUTOTOOLS=  libltdl
 -USE_AUTOTOOLS=  libtool:22
 +USE_AUTOTOOLS=  libtool:22 libltdl:22
 
 Cheers,
 Mezz
 
 
 -- 
 mezz7@cox.net  -  mezz@FreeBSD.org
 FreeBSD GNOME Team
 http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org
State-Changed-From-To: open->closed 
State-Changed-By: makc 
State-Changed-When: Sat Oct 24 16:44:40 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139884 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/139884: commit references a PR
Date: Sat, 24 Oct 2009 16:40:32 +0000 (UTC)

 makc        2009-10-24 16:40:22 UTC
 
   FreeBSD ports repository
 
   Modified files:
     audio/akode          Makefile 
   Log:
   Fix the USE_AUTOTOOLS assignment.
   Minor clean-ups.
   Bump PORTREVISION.
   
   PR:             ports/139884
   Submitted by:   Tijl Coosemans <tijl at ulyssis.org>
   
   Revision  Changes    Path
   1.27      +4 -12     ports/audio/akode/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
