From naddy@mips.inka.de  Sun Oct 18 14:01:15 2009
Return-Path: <naddy@mips.inka.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E9147106566B;
	Sun, 18 Oct 2009 14:01:15 +0000 (UTC)
	(envelope-from naddy@mips.inka.de)
Received: from mail-in-02.arcor-online.net (mail-in-02.arcor-online.net [151.189.21.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 749298FC14;
	Sun, 18 Oct 2009 14:01:15 +0000 (UTC)
Received: from mail-in-05-z2.arcor-online.net (mail-in-05-z2.arcor-online.net [151.189.8.17])
	by mx.arcor.de (Postfix) with ESMTP id F28653FE4A9;
	Sun, 18 Oct 2009 16:01:13 +0200 (CEST)
Received: from mail-in-14.arcor-online.net (mail-in-14.arcor-online.net [151.189.21.54])
	by mail-in-05-z2.arcor-online.net (Postfix) with ESMTP id E92022DB0D4;
	Sun, 18 Oct 2009 16:01:13 +0200 (CEST)
Received: from lorvorc.mips.inka.de (dslb-092-075-109-122.pools.arcor-ip.net [92.75.109.122])
	by mail-in-14.arcor-online.net (Postfix) with ESMTPS id C138B28B075;
	Sun, 18 Oct 2009 16:01:13 +0200 (CEST)
Received: from lorvorc.mips.inka.de (localhost [127.0.0.1])
	by lorvorc.mips.inka.de (8.14.3/8.14.3) with ESMTP id n9IE1DvX065072;
	Sun, 18 Oct 2009 16:01:13 +0200 (CEST)
	(envelope-from naddy@lorvorc.mips.inka.de)
Received: (from naddy@localhost)
	by lorvorc.mips.inka.de (8.14.3/8.14.3/Submit) id n9IE1DJf065071;
	Sun, 18 Oct 2009 16:01:13 +0200 (CEST)
	(envelope-from naddy)
Message-Id: <200910181401.n9IE1DJf065071@lorvorc.mips.inka.de>
Date: Sun, 18 Oct 2009 16:01:13 +0200 (CEST)
From: Christian Weisgerber <naddy@freebsd.org>
Reply-To: Christian Weisgerber <naddy@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: obrien@freebsd.org
Subject: shells/bash: fix $() parsing
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         139720
>Category:       ports
>Synopsis:       shells/bash: fix $() parsing
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 18 14:10:02 UTC 2009
>Closed-Date:    Mon Nov 02 18:30:21 UTC 2009
>Last-Modified:  Mon Nov  2 18:40:04 UTC 2009
>Originator:     Christian Weisgerber
>Release:        FreeBSD 7.2-STABLE amd64
>Organization:
>Environment:
System: FreeBSD lorvorc.mips.inka.de 7.2-STABLE FreeBSD 7.2-STABLE #0: Sun Oct 18 13:39:23 CEST 2009 naddy@lorvorc.mips.inka.de:/usr/obj/usr/src/sys/GENERIC amd64

>Description:

$() parsing is still broken in bash 4.0.33 as installed by the port.

We need to pass the -y flag to bison.  Plain "bison -d parse.y"
outputs parse.tab.c instead of y.tab.c, so y.tab.c is never
regenerated, and the parser fix from patch 001 is effectively not
applied.

[Resent as PR so it doesn't get lost again.]

>How-To-Repeat:

bash -c 'echo $(echo \|)'

>Fix:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/shells/bash/Makefile,v
retrieving revision 1.115
diff -u -r1.115 Makefile
--- Makefile	19 Sep 2009 22:24:28 -0000	1.115
+++ Makefile	18 Oct 2009 13:28:10 -0000
@@ -9,7 +9,7 @@
 PORTNAME=		bash
 PATCHLEVEL=		33
 PORTVERSION=		4.0.${PATCHLEVEL:S/^0//g}
-PORTREVISION?=		0
+PORTREVISION?=		1
 CATEGORIES=		shells
 MASTER_SITES=		${MASTER_SITE_GNU:S/$/:bash/} \
 			ftp://ftp.cwru.edu/pub/%SUBDIR%/:faq
@@ -94,7 +94,7 @@
 
 CONFIGURE_ENV=		CPPFLAGS="${CPPFLAGS}" \
 			LDFLAGS="${LDFLAGS}" \
-			YACC="bison"
+			YACC="bison -y"
 
 .include <bsd.port.pre.mk>
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->obrien 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Oct 18 14:10:14 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139720 
State-Changed-From-To: open->closed 
State-Changed-By: naddy 
State-Changed-When: Mon Nov 2 18:29:21 UTC 2009 
State-Changed-Why:  
Committed.  The PR has been open for two weeks and I originally mailed 
obrien@ on Sep 21. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139720 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/139720: commit references a PR
Date: Mon,  2 Nov 2009 18:29:08 +0000 (UTC)

 naddy       2009-11-02 18:28:59 UTC
 
   FreeBSD ports repository
 
   Modified files:
     shells/bash          Makefile 
   Log:
   Pass the -y flag to bison to fix $() parsing.
   Plain "bison -d parse.y" outputs parse.tab.c instead of y.tab.c,
   so y.tab.c is never regenerated, and the parser fix from patch 001
   is effectively not applied.
   
   PR:             139720
   Approved by:    maintainer timeout (4+2 weeks)
   
   Revision  Changes    Path
   1.117     +2 -2      ports/shells/bash/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
