From nobody@FreeBSD.org  Fri Oct 16 08:13:27 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26AA2106568D
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 16 Oct 2009 08:13:27 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id ECDAD8FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 16 Oct 2009 08:13:26 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n9G8DQXl041424
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 16 Oct 2009 08:13:26 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n9G8DQIK041423;
	Fri, 16 Oct 2009 08:13:26 GMT
	(envelope-from nobody)
Message-Id: <200910160813.n9G8DQIK041423@www.freebsd.org>
Date: Fri, 16 Oct 2009 08:13:26 GMT
From: Marius Nuennerich <marius@nuenneri.ch>
To: freebsd-gnats-submit@FreeBSD.org
Subject: maintainer update x11/xlockmore
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         139676
>Category:       ports
>Synopsis:       maintainer update x11/xlockmore
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 16 08:20:05 UTC 2009
>Closed-Date:    Sun Oct 18 11:11:08 UTC 2009
>Last-Modified:  Sun Oct 18 11:20:03 UTC 2009
>Originator:     Marius Nuennerich
>Release:        7.2-stable
>Organization:
>Environment:
>Description:
Patch attached.
Many thanks to David Wolfskill and David A. Bagley.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -ru xlockmore/Makefile /usr/ports/x11/xlockmore/Makefile
--- xlockmore/Makefile	2009-10-16 09:59:07.977563290 +0200
+++ /usr/ports/x11/xlockmore/Makefile	2009-10-01 02:38:11.000000000 +0200
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	xlockmore
-PORTVERSION=	5.29.1
+PORTVERSION=	5.29
 CATEGORIES?=	x11
 MASTER_SITES=	ftp://ibiblio.org/pub/Linux/X11/screensavers/ \
 		http://www.tux.org/~bagleyd/xlock/${PORTNAME}-${PORTVERSION}/ \
diff -ru xlockmore/distinfo /usr/ports/x11/xlockmore/distinfo
--- xlockmore/distinfo	2009-10-16 10:04:42.423802690 +0200
+++ /usr/ports/x11/xlockmore/distinfo	2009-10-01 02:38:11.000000000 +0200
@@ -1,3 +1,3 @@
-MD5 (xlockmore-5.29.1.tar.bz2) = 5492e1dd0eb2c1e2350c777f0e94d112
-SHA256 (xlockmore-5.29.1.tar.bz2) = acda214225e86b7c6cbb43d8baf60f9cb56cfb32bbaeb1d095f95e17b43fe183
-SIZE (xlockmore-5.29.1.tar.bz2) = 1938941
+MD5 (xlockmore-5.29.tar.bz2) = 8ac1f5967c383e79deb99559150fcca7
+SHA256 (xlockmore-5.29.tar.bz2) = 47700f74cdd6ada80717358fd9cbb4316a0b2350fd527cfcd1e9b018d3818db2
+SIZE (xlockmore-5.29.tar.bz2) = 1928287


>Release-Note:
>Audit-Trail:

From: David Wolfskill <david@catwhisker.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/139676: maintainer update x11/xlockmore
Date: Fri, 16 Oct 2009 10:22:39 -0700

 --VbJkn9YxBvnuCH5J
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Please note that the reason xlockmore 5.29.1 was released is that 5.29
 will fail if invoked from within certain "virtual" window managers.
 
 The failure is accompanied by a message:
 
 | X Error of failed request:  BadWindow (invalid Window parameter)
 |   Major opcode of failed request:  3 (X_GetWindowAttributes)
 |   Resource id in failed request:  0x45
 |   Serial number of failed request:  82
 |   Current serial number in output stream:  83
 
 and xlockmore fails to actually lock the screen.
 
 (I specifically observed it with the piewm and tvtwm window managers,
 and noted that the failure does not occur using the twm window
 manager.  I believe that in general, window managers based on tvtwm are
 susceptible.  It is possible that any "virtual" window manager is
 susceptible.)
 
 As a common way to invoke xlock(more) is via xautolock (in which case,
 the message is not generally displayed in a place where anyone would see
 it), the overall effect is that one would leave the computer, expecting
 that xlock(more) would offer at least some protection, while in fact,
 nothing of the sort happens: the machine is merely left logged in and
 unattended.
 
 This is probably a bit more of a security exposure than folks using
 xautolock would be likely to expect.  Getting this committed prior to
 the release of 8.0 would thus be welcome.
 
 (I have also verified that the fix is effective for both piewm and
 tvtwm.)
 
 Peace,
 david
 --=20
 David H. Wolfskill				david@catwhisker.org
 Depriving a girl or boy of an opportunity for education is evil.
 
 See http://www.catwhisker.org/~david/publickey.gpg for my public key.
 
 --VbJkn9YxBvnuCH5J
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v2.0.13 (FreeBSD)
 
 iEYEARECAAYFAkrYq94ACgkQmprOCmdXAD1iegCeOluAqFRdeqo4sdH0abTQr1Fq
 BT8An3Y8yJshIablGBS2POUjyRKynwa2
 =u9oA
 -----END PGP SIGNATURE-----
 
 --VbJkn9YxBvnuCH5J--
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sun Oct 18 11:11:06 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139676 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/139676: commit references a PR
Date: Sun, 18 Oct 2009 11:11:08 +0000 (UTC)

 miwi        2009-10-18 11:10:58 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11/xlockmore        Makefile distinfo 
   Log:
   - Update to 5.29.1
   
   PR:             139676
   Submitted by:   Marius Nuennerich <marius@nuenneri.ch> (maintainer)
   
   Revision  Changes    Path
   1.121     +1 -1      ports/x11/xlockmore/Makefile
   1.64      +3 -3      ports/x11/xlockmore/distinfo
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
