From tobias.rehbein@web.de  Thu Oct 15 17:58:52 2009
Return-Path: <tobias.rehbein@web.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A7E40106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Oct 2009 17:58:52 +0000 (UTC)
	(envelope-from tobias.rehbein@web.de)
Received: from fmmailgate03.web.de (fmmailgate03.web.de [217.72.192.234])
	by mx1.freebsd.org (Postfix) with ESMTP id 60D958FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Oct 2009 17:58:51 +0000 (UTC)
Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215])
	by fmmailgate03.web.de (Postfix) with ESMTP id 1D6861256BF36
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Oct 2009 19:56:34 +0200 (CEST)
Received: from [95.88.224.31] (helo=sushi.pseudo.local)
	by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.110 #314)
	id 1MyUYz-0000I0-00
	for FreeBSD-gnats-submit@freebsd.org; Thu, 15 Oct 2009 19:56:33 +0200
Received: from sushi.pseudo.local (localhost [127.0.0.1])
	by sushi.pseudo.local (8.14.3/8.14.3) with ESMTP id n9FHurKK041215
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 15 Oct 2009 19:56:53 +0200 (CEST)
	(envelope-from tobi@sushi.pseudo.local)
Received: (from tobi@localhost)
	by sushi.pseudo.local (8.14.3/8.14.3/Submit) id n9FHurdx041214;
	Thu, 15 Oct 2009 19:56:53 +0200 (CEST)
	(envelope-from tobi)
Message-Id: <200910151756.n9FHurdx041214@sushi.pseudo.local>
Date: Thu, 15 Oct 2009 19:56:53 +0200 (CEST)
From: Tobias Rehbein <tobias.rehbein@web.de>
Sender: tobias.rehbein@web.de
Reply-To: Tobias Rehbein <tobias.rehbein@web.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] port mail/rss2email fails for certain feeds
X-Send-Pr-Version: 3.113
X-GNATS-Notify: chifeng@gmail.com

>Number:         139649
>Category:       ports
>Synopsis:       [patch] port mail/rss2email fails for certain feeds
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 15 18:00:07 UTC 2009
>Closed-Date:    Tue Oct 20 09:40:30 UTC 2009
>Last-Modified:  Wed Oct 21 10:40:04 UTC 2009
>Originator:     Tobias Rehbein
>Release:        FreeBSD 8.0-RC1 i386
>Organization:
>Environment:
System: FreeBSD sushi.pseudo.local 8.0-RC1 FreeBSD 8.0-RC1 #54: Sat Oct 3 16:40:05 CEST 2009 tobi@sushi.pseudo.local:/usr/obj/usr/src/sys/SUSHI i386


	
>Description:
        This is a follow-up to ports/139383. As neither the maintainer nor I can re-open the issue I'll repost it.

        rss2email fails to process certain feeds. Most notably for me it bails out for sourceforges file release feeds.
	
>How-To-Repeat:
        Example feed exposing the error:

        http://sourceforge.net/api/file/index/project-id/143991/rss

	
>Fix:
       Attached is a patch which works around the issue. I have pulled it out of:
       http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=543710

       The corresponding bug report for feedparser is:
       http://code.google.com/p/feedparser/issues/detail?id=96

	

--- mail-rss2email.diff begins here ---
diff -ruN rss2email.orig/Makefile rss2email/Makefile
--- rss2email.orig/Makefile	2009-09-30 16:05:17.000000000 +0200
+++ rss2email/Makefile	2009-10-12 09:17:39.000000000 +0200
@@ -7,6 +7,7 @@
 
 PORTNAME=	rss2email
 PORTVERSION=	2.65
+PORTREVISION=	1
 CATEGORIES=	mail python
 MASTER_SITES=	http://www.chifeng.name/dist/rss2email/
 
@@ -27,6 +28,8 @@
 post-patch:
 	@${REINPLACE_CMD} -e 's|@PYTHONCMD@|${PYTHON_CMD}|;s|@DATADIR@|${DATADIR}|'\
 		${WRKSRC}/r2e
+	@${REINPLACE_CMD} -e "s|\([^[:alnum:]]\)c.type\([^[:alnum:]]\)|\1c.get('type','')\2|"\
+		${WRKSRC}/rss2email.py
 
 do-install:
 	@${INSTALL} -d ${DATADIR}/
--- mail-rss2email.diff ends here ---


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Thu Oct 15 18:00:21 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139649 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: chifeng@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/139649: [patch] port mail/rss2email fails for certain feeds
Date: Thu, 15 Oct 2009 18:00:19 UT

 Maintainer of mail/rss2email,
 
 Please note that PR ports/139649 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139649
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: chifeng <chifeng@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: ports/139649: [patch] port mail/rss2email fails for certain feeds
Date: Fri, 16 Oct 2009 11:24:04 +0800

 --000e0cd517148a79c2047604edac
 Content-Type: text/plain; charset=ISO-8859-1
 
 Approved, Thank you so much!
 
 Chifeng
 
 On Fri, Oct 16, 2009 at 2:00 AM, Edwin Groothuis <edwin@freebsd.org> wrote:
 
 > Maintainer of mail/rss2email,
 >
 > Please note that PR ports/139649 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139649
 >
 > --
 > Edwin Groothuis via the GNATS Auto Assign Tool
 > edwin@FreeBSD.org
 >
 
 
 
 -- 
 regards.
 chifeng
 
 --000e0cd517148a79c2047604edac
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Approved, Thank you so much!<br><br>Chifeng<br><br><div class=3D"gmail_quot=
 e">On Fri, Oct 16, 2009 at 2:00 AM, Edwin Groothuis <span dir=3D"ltr">&lt;<=
 a href=3D"mailto:edwin@freebsd.org">edwin@freebsd.org</a>&gt;</span> wrote:=
 <br>
 <blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Maintainer of mai=
 l/rss2email,<br>
 <br>
 Please note that PR ports/139649 has just been submitted.<br>
 <br>
 If it contains a patch for an upgrade, an enhancement or a bug fix<br>
 you agree on, reply to this email stating that you approve the patch<br>
 and a committer will take care of it.<br>
 <br>
 The full text of the PR can be found at:<br>
  =A0 =A0<a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/13964=
 9" target=3D"_blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/139=
 649</a><br>
 <font color=3D"#888888"><br>
 --<br>
 Edwin Groothuis via the GNATS Auto Assign Tool<br>
 edwin@FreeBSD.org<br>
 </font></blockquote></div><br><br clear=3D"all"><br>-- <br>regards.<br>chif=
 eng<br>
 
 --000e0cd517148a79c2047604edac--
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri Oct 16 05:25:19 UTC 2009 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139649 
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Sun Oct 18 11:03:04 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139649 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Tue Oct 20 09:40:28 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139649 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/139649: commit references a PR
Date: Wed, 21 Oct 2009 10:36:15 +0000 (UTC)

 miwi        2009-10-21 10:35:54 UTC
 
   FreeBSD ports repository
 
   Modified files:
     mail/rss2email       Makefile 
   Log:
   - Fix feed fetch
   
   PR:             139649
   Submitted by:   Tobias Rehbein <tobias.rehbein@web.de> (maintainer)
   
   Revision  Changes    Path
   1.6       +3 -0      ports/mail/rss2email/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
