From nobody@FreeBSD.org  Tue Oct  6 13:30:18 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 81CFA1065693
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  6 Oct 2009 13:30:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 70D0F8FC20
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  6 Oct 2009 13:30:18 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n96DUIRB099922
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 6 Oct 2009 13:30:18 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n96DUIXV099882;
	Tue, 6 Oct 2009 13:30:18 GMT
	(envelope-from nobody)
Message-Id: <200910061330.n96DUIXV099882@www.freebsd.org>
Date: Tue, 6 Oct 2009 13:30:18 GMT
From: Alexander Logvinov <avl@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] devel/rubygem-activesupport: add dependency on converters/ruby-iconv
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         139379
>Category:       ports
>Synopsis:       [PATCH] devel/rubygem-activesupport: add dependency on converters/ruby-iconv
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 06 13:40:03 UTC 2009
>Closed-Date:    Tue Nov 03 17:50:52 UTC 2009
>Last-Modified:  Tue Nov 03 17:50:52 UTC 2009
>Originator:     Alexander Logvinov
>Release:        7.2-STABLE i386
>Organization:
>Environment:
>Description:
 I can't create Rails project without ruby-iconv port installed.

$ pwd
/usr/local/lib/ruby/gems/1.8/gems/activesupport-2.3.4

$ fgrep -R "require 'iconv'" *
lib/active_support/inflector.rb:require 'iconv'

 And it would be nice to add the same dependency to mail/rubygem-actionmailer:

$ pwd
/usr/local/lib/ruby/gems/1.8/gems/actionmailer-2.3.4

$ fgrep -R "require 'iconv'" *
lib/action_mailer/vendor/tmail-1.2.3/tmail/quoting.rb:        require 'iconv'

>How-To-Repeat:
$ pkg_info -Ix iconv
libiconv-1.13.1     A character set conversion library

$ rails test
undefined method `camelize' for "app":String

% pkg_info -Ix iconv
libiconv-1.13.1     A character set conversion library
ruby18-iconv-1.8.7.160,1 An iconv wrapper class for Ruby

$ rails test
      create  
      create  app/controllers

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/devel/rubygem-activesupport/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	10 Sep 2009 17:12:19 -0000	1.19
+++ Makefile	6 Oct 2009 13:20:09 -0000
@@ -6,6 +6,7 @@
 
 PORTNAME=	activesupport
 PORTVERSION=	2.3.4
+PORTREVISION=	1
 CATEGORIES=	devel rubygems
 MASTER_SITES=	RF
 
@@ -13,6 +14,7 @@
 COMMENT=	Utility classes and extension that are required by Rails MVC Framework
 
 USE_RUBY=	yes
+USE_RUBY_FEATURES=	iconv
 USE_RUBYGEMS=	yes
 RUBYGEM_AUTOPLIST=	yes
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Oct 6 13:40:13 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139379 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/139379: commit references a PR
Date: Tue,  3 Nov 2009 17:38:05 +0000 (UTC)

 avl         2009-11-03 17:37:51 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/rubygem-activesupport Makefile 
   Log:
   - Add dependency on converters/ruby-iconv
   
   PR:             ports/139379
   Submitted by:   myself
   Approved by:    maintainer (pgollucci via ports@ maillist)
   
   Revision  Changes    Path
   1.20      +2 -0      ports/devel/rubygem-activesupport/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: avl 
State-Changed-When: Tue Nov 3 17:50:51 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139379 
>Unformatted:
