From nobody@FreeBSD.org  Tue Sep 29 04:41:23 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4207C106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Sep 2009 04:41:23 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id D65378FC2C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Sep 2009 04:41:22 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n8T4fMAf050977
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Sep 2009 04:41:22 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n8T4fMw4050975;
	Tue, 29 Sep 2009 04:41:22 GMT
	(envelope-from nobody)
Message-Id: <200909290441.n8T4fMw4050975@www.freebsd.org>
Date: Tue, 29 Sep 2009 04:41:22 GMT
From: Tom Pusateri <pusateri@bangj.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: net/libevnet-0.3.8_4 incompatible with dns/c-ares-1.6.0
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         139228
>Category:       ports
>Synopsis:       net/libevnet 0.3.8_4 incompatible with dns/c-ares-1.6.0
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ijliao
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 29 04:50:00 UTC 2009
>Closed-Date:    Sun Oct 04 02:20:57 UTC 2009
>Last-Modified:  Sun Oct  4 02:30:01 UTC 2009
>Originator:     Tom Pusateri
>Release:        8.0-RC1
>Organization:
!j Incorporated
>Environment:
FreeBSD crag.mountain2sea.com 8.0-RC1 FreeBSD 8.0-RC1 #0: Thu Sep 17 20:45:19 UTC 2009     root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
A library change for the arguments of a callback have changed between c-ares-1.4.0 and c-ares-1.6.0. This causes libevnet-0.3.8_4 to not work correctly. libevnet needs to be patched to be brought up to date with c-ares-1.6.0 adding the new timeouts argument.

The patch to libevnet is minor and should become part of the libevnet ports distribution until it is fixed by the author of libevnet. Currently, the web site for libevnet is down and the author is not reachable.

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- src/lookup.c.orig	2007-05-04 02:07:32.000000000 -0400
+++ src/lookup.c	2009-09-29 00:29:01.000000000 -0400
@@ -2037,7 +2037,7 @@
 } /* lookup_additional_query() */
 
 
-static void lookup_catch_ares(void *, int, unsigned char *, int);
+static void lookup_catch_ares(void *, int, int, unsigned char *, int);
 
 static void lookup_issue_query(struct lookup *l, struct lookup_query *q, const char *qname, size_t qnamelen, int rtype) {
 	struct ares_channel *c;
@@ -2052,7 +2052,7 @@
 	q->channel	= c;
 
 	if (l->opts.query_max != 0 && q->live_queries_made >= l->opts.query_max) {
-		lookup_catch_ares(q, ARES_ENODATA, NULL, 0);
+		lookup_catch_ares(q, ARES_ENODATA, 0, NULL, 0);
 	} else {
 		++q->live_queries_made;
 		ares_query(c->channel, qname, C_IN, lookup_rtype2arpa(rtype), lookup_catch_ares, q);
@@ -2708,7 +2708,7 @@
 } /* lookup_process() */
 
 
-static void lookup_catch_ares(void *l_, int ares_errno, unsigned char *abuf, int alen) {
+static void lookup_catch_ares(void *l_, int ares_errno, int timeouts, unsigned char *abuf, int alen) {
 	int lookup_errno	= LOOKUP_ESUCCESS;
 	struct lookup_query *q;
 	struct lookup *l;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ijliao 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Sep 29 22:00:51 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139228 
State-Changed-From-To: open->closed 
State-Changed-By: ijliao 
State-Changed-When: Sun Oct 4 02:20:43 UTC 2009 
State-Changed-Why:  
committed, thanks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139228 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/139228: commit references a PR
Date: Sun,  4 Oct 2009 02:20:17 +0000 (UTC)

 ijliao      2009-10-04 02:20:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/libevnet         Makefile 
   Added files:
     net/libevnet/files   patch-src::lookup.c 
   Log:
   chase changes between c-ares 1.4.0 to c-ares 1.6.0
   pass maintainership to submitter
   
   PR:             139228
   Submitted by:   Tom Pusateri <pusateri at bangj dot com>
   
   Revision  Changes    Path
   1.8       +2 -2      ports/net/libevnet/Makefile
   1.1       +29 -0     ports/net/libevnet/files/patch-src::lookup.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
