From nobody@FreeBSD.org  Mon Sep 28 08:16:24 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D0C20106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Sep 2009 08:16:24 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BFA2E8FC1A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Sep 2009 08:16:24 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n8S8GOp9036543
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 28 Sep 2009 08:16:24 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n8S8GOSV036542;
	Mon, 28 Sep 2009 08:16:24 GMT
	(envelope-from nobody)
Message-Id: <200909280816.n8S8GOSV036542@www.freebsd.org>
Date: Mon, 28 Sep 2009 08:16:24 GMT
From: Fedor Dikarev <fedor.dikarev@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/freebsd-snapshot more careful patch not depending of LANG/LC_ALL
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: gtodd@bellanet.org

>Number:         139203
>Category:       ports
>Synopsis:       sysutils/freebsd-snapshot more careful patch not depending of LANG/LC_ALL
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    crees
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 28 08:20:00 UTC 2009
>Closed-Date:    Sun Mar 04 13:23:01 UTC 2012
>Last-Modified:  Sun Mar 04 13:23:01 UTC 2012
>Originator:     Fedor Dikarev
>Release:        7.2
>Organization:
Rambler
>Environment:
FreeBSD net.park.rambler.ru 7.2-STABLE FreeBSD 7.2-STABLE #1: Tue Jun  2 10:49:29 MSD 2009     root@net.park.rambler.ru:/usr/obj/usr/src/sys/MNGMT  amd64

>Description:
This is another way to solve bug ports/137105 (http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/137105)

But it's not only fix those bug, it make code more neatly, and allow to use different languages depending of user sets LANG/LC_ALL in the future.

So with current version snapshot program output is always as LC_ALL=C. With my version, output depends on user settings, so it's more flexible.
>How-To-Repeat:
Problem in original "snapshot":

LANG="ru_RU.KOI8-R" ~/snapshot.orig.orig -v list
Filesystem      Type     User   User%     Snap   Snap%  Snapshot Name   Snapshot Time
/                ufs    661MB   66,9%      5MB    0,6%  test.0          2009-07-01T14:02
/home            ufs      5GB   68,2%      1GB   19,8%  test.1          2009-07-01T14:03
/home            ufs      5GB   68,2%      9MB    0,1%  test.0          2009-07-01T14:10
[: 88,6: bad number
[: 88,6: bad number
/zraid/rrd       zfs      4GB    0,2%   88,6KB    0,0%  test.1          2009-07-01T13:19
[: 88,6: bad number
[: 88,6: bad number
/zraid/rrd       zfs      4GB    0,2%   88,6KB    0,0%  test.0          2009-07-01T13:20
/zraid/svn       zfs     35MB    0,0%      0KB    0,0%  dump1           2009-06-09T10:07
/zraid/svn       zfs     35MB    0,0%      0KB    0,0%  dump2           2009-06-09T10:07

>Fix:
Using option "-p", when running "zfs get" commands

Patch attached with submission follows:

--- snapshot    2009-09-28 11:58:03.000000000 +0400
+++ snapshot.orig       2009-09-28 11:59:40.000000000 +0400
@@ -30,6 +30,8 @@

 #   make sure system tools are used first
 PATH="/bin:/usr/bin:/sbin:/usr/sbin:/usr/local/sbin:$PATH"
+LC_ALL=C
+LANG=C

 #   option defaults
 verbose=no
@@ -165,12 +167,19 @@
                 #   determine sizes
                 fs_size=`df -k $fs_dir | tail -n1 | awk '{ print $2; }'`
                 used_size=`df -k $fs_dir | tail -n1 | awk '{ print $3; }'`
-                snap_size=`zfs get -H -p -o value used $snap | sed -e 's;\.[0-9][0-9]*;;'`
+                snap_size=`zfs get -H -o value used $snap | sed -e 's;\.[0-9][0-9]*;;'`
+                case "$snap_size" in
+                    *B ) snap_size=`echo "$snap_size" | sed -e 's;B$;;'`; snap_size=$(($snap_size / 1024))               ;;
+                    *K ) snap_size=`echo "$snap_size" | sed -e 's;K$;;'`                                                 ;;
+                    *M ) snap_size=`echo "$snap_size" | sed -e 's;M$;;'`; snap_size=$(($snap_size * 1024))               ;;
+                    *G ) snap_size=`echo "$snap_size" | sed -e 's;G$;;'`; snap_size=$(($snap_size * 1024 * 1024))        ;;
+                    *T ) snap_size=`echo "$snap_size" | sed -e 's;T$;;'`; snap_size=$(($snap_size * 1024 * 1024 * 1024)) ;;
+                esac

                 #   determine snapshot creation time
                 if [ ".$verbose" = .yes ]; then
-                    snap_time=`zfs get -H -p -o value creation $snap`
-                    snap_time=`date -r "$snap_time" "+%Y-%m-%dT%H:%M"`
+                    snap_time=`zfs get -H -o value creation $snap`
+                    snap_time=`date -j -f "%a %b %d %H:%M %Y" "$snap_time" "+%Y-%m-%dT%H:%M"`
                 fi

                 #   calculate percentages


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Sep 28 08:20:12 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139203 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: gtodd@bellanet.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/139203: sysutils/freebsd-snapshot more careful patch not depending of LANG/LC_ALL
Date: Mon, 28 Sep 2009 08:20:09 UT

 Maintainer of sysutils/freebsd-snapshot,
 
 Please note that PR ports/139203 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139203
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: pgollucci@FreeBSD.org
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/139203 sysutils/freebsd-snapshot more careful patch not depending of LANG/LC_ALL
Date: Mon, 18 Jan 2010 02:26:48 -0500

 ping....
 
Responsible-Changed-From-To: freebsd-ports-bugs->stefan 
Responsible-Changed-By: stefan 
Responsible-Changed-When: Fri May 21 14:29:31 UTC 2010 
Responsible-Changed-Why:  
Track this for now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139203 

From: Stefan Walter <stefan@freebsd.org>
To: Graham Todd <gtodd@bellanet.org>
Cc: GNATS <FreeBSD-gnats-submit@FreeBSD.org>
Subject: Re: ports/139203: sysutils/freebsd-snapshot more careful patch not
 depending of LANG/LC_ALL
Date: Fri, 21 May 2010 16:28:36 +0200

 Dear maintainer of sysutils/freebsd-snapshot,
 
 a problem report has been submitted for your port for which your 
 feedback might be required; its contents can be found at [1]. If it 
 contains a patch or suggestions for a change, please send a followup to 
 the PR explaining whether or not you approve it and want it to be 
 committed.
 
 Regards,
 Stefan
 
 [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/139203

From: Stefan Walter <stefan@FreeBSD.org>
To: Fedor Dikarev <fedor.dikarev@gmail.com>
Cc: GNATS <FreeBSD-gnats-submit@FreeBSD.org>,
	Graham Todd <gtodd@bellanet.org>
Subject: Re: ports/139203: sysutils/freebsd-snapshot more careful patch not
 depending of LANG/LC_ALL
Date: Sun, 27 Jun 2010 15:50:46 +0200

 Hi Fedor,
 
 the port sysutils/freebsd-snapshot, for which you have sent a patch, has
 seen multiple updates in the meantime. Could you send an updated patch
 against the current version of the port (if the problem still exists)? Or
 has it been resolved in the meantime so this PR could be closed?
 
 Regards,
 Stefan

From: Fedor Dikarev <fedor.dikarev@gmail.com>
To: Stefan Walter <stefan@freebsd.org>
Cc: GNATS <FreeBSD-gnats-submit@freebsd.org>, Graham Todd <gtodd@bellanet.org>
Subject: Re: ports/139203: sysutils/freebsd-snapshot more careful patch not 
	depending of LANG/LC_ALL
Date: Sun, 27 Jun 2010 19:39:29 +0400

 --001636457a3c4a292b048a04cfac
 Content-Type: text/plain; charset=ISO-8859-1
 
 2010/6/27 Stefan Walter <stefan@freebsd.org>:
 > Hi Fedor,
 >
 > the port sysutils/freebsd-snapshot, for which you have sent a patch, has
 > seen multiple updates in the meantime. Could you send an updated patch
 > against the current version of the port (if the problem still exists)? Or
 > has it been resolved in the meantime so this PR could be closed?
 
 New patch enclosed.
 
 
 >
 > Regards,
 > Stefan
 >
 
 
 
 -- 
 Fedor Dikarev
 
 --001636457a3c4a292b048a04cfac
 Content-Type: text/x-patch; charset=US-ASCII; name="freebsd-snapshot-fixing-LC_ALL.patch"
 Content-Disposition: attachment; 
 	filename="freebsd-snapshot-fixing-LC_ALL.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gay1o5kx0
 
 LS0tIHNuYXBzaG90Lm9yaWcJMjAxMC0wNi0yNyAxOToyMzo1Ny4wMDAwMDAwMDAgKzA0MDAKKysr
 IHNuYXBzaG90CTIwMTAtMDYtMjcgMTk6Mjk6MTMuMDAwMDAwMDAwICswNDAwCkBAIC0zMCw4ICsz
 MCw2IEBACiAKICMgICBtYWtlIHN1cmUgc3lzdGVtIHRvb2xzIGFyZSB1c2VkIGZpcnN0CiBQQVRI
 PSIvYmluOi91c3IvYmluOi9zYmluOi91c3Ivc2JpbjovdXNyL2xvY2FsL3NiaW46JFBBVEgiCi1M
 Q19BTEw9QwotTEFORz1DCiAKICMgICBvcHRpb24gZGVmYXVsdHMKIHZlcmJvc2U9bm8KQEAgLTE2
 OCwxOSArMTY2LDEyIEBACiAgICAgICAgICAgICAgICAgIyAgIGRldGVybWluZSBzaXplcwogICAg
 ICAgICAgICAgICAgIGZzX3NpemU9YGRmIC1rICRmc19kaXIgfCB0YWlsIC1uMSB8IGF3ayAneyBw
 cmludCAkMjsgfSdgCiAgICAgICAgICAgICAgICAgdXNlZF9zaXplPWBkZiAtayAkZnNfZGlyIHwg
 dGFpbCAtbjEgfCBhd2sgJ3sgcHJpbnQgJDM7IH0nYAotICAgICAgICAgICAgICAgIHNuYXBfc2l6
 ZT1gemZzIGdldCAtSCAtbyB2YWx1ZSB1c2VkICRzbmFwIHwgc2VkIC1lICdzO1wuWzAtOV1bMC05
 XSo7OydgCi0gICAgICAgICAgICAgICAgY2FzZSAiJHNuYXBfc2l6ZSIgaW4KLSAgICAgICAgICAg
 ICAgICAgICAgKkIgKSBzbmFwX3NpemU9YGVjaG8gIiRzbmFwX3NpemUiIHwgc2VkIC1lICdzO0Ik
 OzsnYDsgc25hcF9zaXplPSQoKCRzbmFwX3NpemUgLyAxMDI0KSkgICAgICAgICAgICAgICA7Owot
 ICAgICAgICAgICAgICAgICAgICAqSyApIHNuYXBfc2l6ZT1gZWNobyAiJHNuYXBfc2l6ZSIgfCBz
 ZWQgLWUgJ3M7SyQ7OydgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
 ICAgICAgIDs7Ci0gICAgICAgICAgICAgICAgICAgICpNICkgc25hcF9zaXplPWBlY2hvICIkc25h
 cF9zaXplIiB8IHNlZCAtZSAncztNJDs7J2A7IHNuYXBfc2l6ZT0kKCgkc25hcF9zaXplICogMTAy
 NCkpICAgICAgICAgICAgICAgOzsKLSAgICAgICAgICAgICAgICAgICAgKkcgKSBzbmFwX3NpemU9
 YGVjaG8gIiRzbmFwX3NpemUiIHwgc2VkIC1lICdzO0ckOzsnYDsgc25hcF9zaXplPSQoKCRzbmFw
 X3NpemUgKiAxMDI0ICogMTAyNCkpICAgICAgICA7OwotICAgICAgICAgICAgICAgICAgICAqVCAp
 IHNuYXBfc2l6ZT1gZWNobyAiJHNuYXBfc2l6ZSIgfCBzZWQgLWUgJ3M7VCQ7OydgOyBzbmFwX3Np
 emU9JCgoJHNuYXBfc2l6ZSAqIDEwMjQgKiAxMDI0ICogMTAyNCkpIDs7Ci0gICAgICAgICAgICAg
 ICAgZXNhYworICAgICAgICAgICAgICAgIHNuYXBfc2l6ZT1gemZzIGdldCAtSCAtcCAtbyB2YWx1
 ZSB1c2VkICRzbmFwIHwgc2VkIC1lICdzO1wuWzAtOV1bMC05XSo7OydgCiAKICAgICAgICAgICAg
 ICAgICAjICAgZGV0ZXJtaW5lIHNuYXBzaG90IGNyZWF0aW9uIHRpbWUKICAgICAgICAgICAgICAg
 ICBpZiBbICIuJHZlcmJvc2UiID0gLnllcyBdOyB0aGVuCi0gICAgICAgICAgICAgICAgICAgIHNu
 YXBfdGltZT1gemZzIGdldCAtSCAtbyB2YWx1ZSBjcmVhdGlvbiAkc25hcGAKLSAgICAgICAgICAg
 ICAgICAgICAgc25hcF90aW1lPWBkYXRlIC1qIC1mICIlYSAlYiAlZCAlSDolTSAlWSIgIiRzbmFw
 X3RpbWUiICIrJVktJW0tJWRUJUg6JU0iYAorICAgICAgICAgICAgICAgICAgICBzbmFwX3RpbWU9
 YHpmcyBnZXQgLUggLXAgLW8gdmFsdWUgY3JlYXRpb24gJHNuYXBgCisgICAgICAgICAgICAgICAg
 ICAgIHNuYXBfdGltZT1gZGF0ZSAtciAiJHNuYXBfdGltZSIgIislWS0lbS0lZFQlSDolTSJgCiAg
 ICAgICAgICAgICAgICAgZmkKICAgICAKICAgICAgICAgICAgICAgICAjICAgY2FsY3VsYXRlIHBl
 cmNlbnRhZ2VzCg==
 --001636457a3c4a292b048a04cfac--

From: Stefan Walter <stefan@freebsd.org>
To: Fedor Dikarev <fedor.dikarev@gmail.com>
Cc: GNATS <FreeBSD-gnats-submit@freebsd.org>,
	Graham Todd <gtodd@bellanet.org>
Subject: Re: ports/139203: sysutils/freebsd-snapshot more careful patch not
 depending of LANG/LC_ALL
Date: Sun, 27 Jun 2010 18:19:21 +0200

 Hi Fedor,
 
 what I meant was a patch against the port itself. In your case,
 files/patch-snapshot would have to be changed.
 
 Regards,
 Stefan

From: Fedor Dikarev <fedor.dikarev@gmail.com>
To: Stefan Walter <stefan@freebsd.org>
Cc: GNATS <FreeBSD-gnats-submit@freebsd.org>, Graham Todd <gtodd@bellanet.org>
Subject: Re: ports/139203: sysutils/freebsd-snapshot more careful patch not 
	depending of LANG/LC_ALL
Date: Mon, 28 Jun 2010 10:36:32 +0400

 --001485f85b4664d14c048a11570b
 Content-Type: text/plain; charset=ISO-8859-1
 
 Stefan,
 
 if I understand you right, then right patch in attachment.
 
 2010/6/27 Stefan Walter <stefan@freebsd.org>:
 > Hi Fedor,
 >
 > what I meant was a patch against the port itself. In your case,
 > files/patch-snapshot would have to be changed.
 >
 > Regards,
 > Stefan
 >
 
 
 
 -- 
 Fedor Dikarev
 
 --001485f85b4664d14c048a11570b
 Content-Type: application/octet-stream; name=patch-snapshot
 Content-Disposition: attachment; filename=patch-snapshot
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gayxprmj0
 
 LS0tIHNuYXBzaG90Lm9yaWcJMjAxMC0wNi0yOCAxMDoyODoyNS4wMDAwMDAwMDAgKzA0MDAKKysr
 IHNuYXBzaG90CTIwMTAtMDYtMjggMTA6MzI6MjQuMDAwMDAwMDAwICswNDAwCkBAIC0yOSw3ICsy
 OSw3IEBACiAjIwogCiAjICAgbWFrZSBzdXJlIHN5c3RlbSB0b29scyBhcmUgdXNlZCBmaXJzdAot
 UEFUSD0iL2JpbjovdXNyL2Jpbjovc2JpbjovdXNyL3NiaW46JFBBVEgiCitQQVRIPSIvYmluOi91
 c3IvYmluOi9zYmluOi91c3Ivc2JpbjolJVBSRUZJWCUlL3NiaW46JFBBVEgiCiAKICMgICBvcHRp
 b24gZGVmYXVsdHMKIHZlcmJvc2U9bm8KQEAgLTc5LDYgKzc5LDcgQEAKICAgICAgICAgc291cmNl
 X3JjX2NvbmZzOyBcCiAgICAgZmk7IFwKICAgICAuIC9ldGMvcmMuc3VicjsgXAorICAgIGxvYWRf
 cmNfY29uZmlnIHpmczsgXAogICAgIGlmIGNoZWNreWVzbm8gemZzX2VuYWJsZTsgdGhlbiBcCiAg
 ICAgICAgIGVjaG8gJ3llcyc7IFwKICAgICBlbHNlIFwKQEAgLTE2NSwxOSArMTY2LDEyIEBACiAg
 ICAgICAgICAgICAgICAgIyAgIGRldGVybWluZSBzaXplcwogICAgICAgICAgICAgICAgIGZzX3Np
 emU9YGRmIC1rICRmc19kaXIgfCB0YWlsIC1uMSB8IGF3ayAneyBwcmludCAkMjsgfSdgCiAgICAg
 ICAgICAgICAgICAgdXNlZF9zaXplPWBkZiAtayAkZnNfZGlyIHwgdGFpbCAtbjEgfCBhd2sgJ3sg
 cHJpbnQgJDM7IH0nYAotICAgICAgICAgICAgICAgIHNuYXBfc2l6ZT1gemZzIGdldCAtSCAtbyB2
 YWx1ZSB1c2VkICRzbmFwIHwgc2VkIC1lICdzO1wuWzAtOV1bMC05XSo7OydgCi0gICAgICAgICAg
 ICAgICAgY2FzZSAiJHNuYXBfc2l6ZSIgaW4KLSAgICAgICAgICAgICAgICAgICAgKkIgKSBzbmFw
 X3NpemU9YGVjaG8gIiRzbmFwX3NpemUiIHwgc2VkIC1lICdzO0IkOzsnYDsgc25hcF9zaXplPSQo
 KCRzbmFwX3NpemUgLyAxMDI0KSkgICAgICAgICAgICAgICA7OwotICAgICAgICAgICAgICAgICAg
 ICAqSyApIHNuYXBfc2l6ZT1gZWNobyAiJHNuYXBfc2l6ZSIgfCBzZWQgLWUgJ3M7SyQ7OydgICAg
 ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7Ci0gICAgICAg
 ICAgICAgICAgICAgICpNICkgc25hcF9zaXplPWBlY2hvICIkc25hcF9zaXplIiB8IHNlZCAtZSAn
 cztNJDs7J2A7IHNuYXBfc2l6ZT0kKCgkc25hcF9zaXplICogMTAyNCkpICAgICAgICAgICAgICAg
 OzsKLSAgICAgICAgICAgICAgICAgICAgKkcgKSBzbmFwX3NpemU9YGVjaG8gIiRzbmFwX3NpemUi
 IHwgc2VkIC1lICdzO0ckOzsnYDsgc25hcF9zaXplPSQoKCRzbmFwX3NpemUgKiAxMDI0ICogMTAy
 NCkpICAgICAgICA7OwotICAgICAgICAgICAgICAgICAgICAqVCApIHNuYXBfc2l6ZT1gZWNobyAi
 JHNuYXBfc2l6ZSIgfCBzZWQgLWUgJ3M7VCQ7OydgOyBzbmFwX3NpemU9JCgoJHNuYXBfc2l6ZSAq
 IDEwMjQgKiAxMDI0ICogMTAyNCkpIDs7Ci0gICAgICAgICAgICAgICAgZXNhYworICAgICAgICAg
 ICAgICAgIHNuYXBfc2l6ZT1gemZzIGdldCAtSCAtcCAtbyB2YWx1ZSB1c2VkICRzbmFwIHwgc2Vk
 IC1lICdzO1wuWzAtOV1bMC05XSo7OydgCiAKICAgICAgICAgICAgICAgICAjICAgZGV0ZXJtaW5l
 IHNuYXBzaG90IGNyZWF0aW9uIHRpbWUKICAgICAgICAgICAgICAgICBpZiBbICIuJHZlcmJvc2Ui
 ID0gLnllcyBdOyB0aGVuCi0gICAgICAgICAgICAgICAgICAgIHNuYXBfdGltZT1gemZzIGdldCAt
 SCAtbyB2YWx1ZSBjcmVhdGlvbiAkc25hcGAKLSAgICAgICAgICAgICAgICAgICAgc25hcF90aW1l
 PWBkYXRlIC1qIC1mICIlYSAlYiAlZCAlSDolTSAlWSIgIiRzbmFwX3RpbWUiICIrJVktJW0tJWRU
 JUg6JU0iYAorICAgICAgICAgICAgICAgICAgICBzbmFwX3RpbWU9YHpmcyBnZXQgLUggLXAgLW8g
 dmFsdWUgY3JlYXRpb24gJHNuYXBgCisgICAgICAgICAgICAgICAgICAgIHNuYXBfdGltZT1gZGF0
 ZSAtciAiJHNuYXBfdGltZSIgIislWS0lbS0lZFQlSDolTSJgCiAgICAgICAgICAgICAgICAgZmkK
 ICAgICAKICAgICAgICAgICAgICAgICAjICAgY2FsY3VsYXRlIHBlcmNlbnRhZ2VzCg==
 --001485f85b4664d14c048a11570b--

From: Graham Todd <gtodd@bellanet.org>
To: Fedor Dikarev <fedor.dikarev@gmail.com>
Cc: Stefan Walter <stefan@freebsd.org>, 
 GNATS <FreeBSD-gnats-submit@freebsd.org>,
 "Ralf S. Engelschall" <rse@FreeBSD.org>
Subject: Re: ports/139203: sysutils/freebsd-snapshot more careful patch not
 depending of LANG/LC_ALL
Date: Mon, 28 Jun 2010 15:38:38 -0400

 Fedor Dikarev wrote:
 > Stefan,
 > 
 > if I understand you right, then right patch in attachment.
 > 
 > 2010/6/27 Stefan Walter <stefan@freebsd.org>:
 >> Hi Fedor,
 >>
 >> what I meant was a patch against the port itself. In your case,
 >> files/patch-snapshot would have to be changed.
 
 Thanks for these patches.
 
 Very often Ralf integrates changes upstream and the port patches
 eventually go into the source tarball. I think for a few years there's
 been about 2-3 releases a year of this utility.
 
 Perhaps if - like a bird on a nest - you sit on the port patch for a few
 days, a new upstream release might hatch.
 
 ;-)
 
 cheers
Responsible-Changed-From-To: stefan->freebsd-ports-bugs 
Responsible-Changed-By: stefan 
Responsible-Changed-When: Mon Aug 2 16:50:08 UTC 2010 
Responsible-Changed-Why:  
Return this PR to the pool - I currently do not have the time to take care of 
it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139203 
State-Changed-From-To: feedback->open 
State-Changed-By: shaun 
State-Changed-When: Tue Jul 26 21:07:57 UTC 2011 
State-Changed-Why:  
Feedback received; set this back to open. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139203 
State-Changed-From-To: open->analyzed 
State-Changed-By: shaun 
State-Changed-When: Tue Jul 26 21:10:58 UTC 2011 
State-Changed-Why:  
Actually, "analyzed" is more appropriate. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139203 
State-Changed-From-To: analyzed->feedback 
State-Changed-By: crees 
State-Changed-When: Thu Feb 9 19:48:56 UTC 2012 
State-Changed-Why:  
Hi Graham, 

As you suggested earlier, these problems should have been resolved in a recent release.  Is that the case? 


Responsible-Changed-From-To: freebsd-ports-bugs->crees 
Responsible-Changed-By: crees 
Responsible-Changed-When: Thu Feb 9 19:48:56 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139203 
State-Changed-From-To: feedback->closed 
State-Changed-By: crees 
State-Changed-When: Sun Mar 4 13:23:00 UTC 2012 
State-Changed-Why:  
Patch already in latest release.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139203 
>Unformatted:
