From vivek@kcilink.com  Wed Sep 16 16:18:36 2009
Return-Path: <vivek@kcilink.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 937621065670
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 16 Sep 2009 16:18:36 +0000 (UTC)
	(envelope-from vivek@kcilink.com)
Received: from lorax.kcilink.com (lorax.kcilink.com [206.112.95.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 72F428FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 16 Sep 2009 16:18:36 +0000 (UTC)
Received: by lorax.kcilink.com (Postfix, from userid 120)
	id B005AA102D; Wed, 16 Sep 2009 12:10:02 -0400 (EDT)
Message-Id: <20090916161002.B005AA102D@lorax.kcilink.com>
Date: Wed, 16 Sep 2009 12:10:02 -0400 (EDT)
From: Vivek Khera <vivek@khera.org>
Reply-To: Vivek Khera <vivek@khera.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: p5-Net-XMPP registers unnecessary run-dependency
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         138883
>Category:       ports
>Synopsis:       net-im/p5-Net-XMPP registers unnecessary run-dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    perl
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 16 16:20:05 UTC 2009
>Closed-Date:    Sat Sep 19 20:40:21 UTC 2009
>Last-Modified:  Sat Sep 19 20:40:21 UTC 2009
>Originator:     Vivek Khera
>Release:        FreeBSD 7.2-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD lorax.kcilink.com 7.2-RELEASE-p2 FreeBSD 7.2-RELEASE-p2 #12: Tue Jul 14 11:32:39 EDT 2009 steve@lorax.kcilink.com:/u/lorax1/usr7/obj.i386/u/lorax1/usr7/src/sys/KCI32SMP i386


	
>Description:
	

The way the net-im/p5-Net-XMPP makefile is written, it registers Module::Build
as a runtime dependency, whereas that is only needed during compile time.

This patch adjusts the dependency lists so that the run and build dependencies
are more correct.

>How-To-Repeat:
	

Compare the RUN_DEPENDS lists.

In the current port:

# make -V BUILD_DEPENDS
p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream  p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/lib/perl5/site_perl/5.8.9/Module/Build.pm:/usr/ports/devel/p5-Module-Build /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8
# make -V RUN_DEPENDS
p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream  p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/lib/perl5/site_perl/5.8.9/Module/Build.pm:/usr/ports/devel/p5-Module-Build /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8 /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8

In the revised port:

# make -V BUILD_DEPENDS
p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream  p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/lib/perl5/site_perl/5.8.9/Module/Build.pm:/usr/ports/devel/p5-Module-Build /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8
# make -V RUN_DEPENDS
p5-XML-Stream>=1.22:/usr/ports/textproc/p5-XML-Stream  p5-Digest-SHA1>=1.02:/usr/ports/security/p5-Digest-SHA1 /usr/local/bin/perl5.8.9:/usr/ports/lang/perl5.8


>Fix:

	


diff -Nru p5-Net-XMPP.old/Makefile p5-Net-XMPP/Makefile
--- p5-Net-XMPP.old/Makefile	2008-01-04 18:48:20.000000000 -0500
+++ p5-Net-XMPP/Makefile	2009-09-16 12:01:54.000000000 -0400
@@ -14,9 +14,10 @@
 MAINTAINER=	perl@FreeBSD.org
 COMMENT=	Net::XMPP provides Perl Developer access to the XMPP protocol
 
-BUILD_DEPENDS=	p5-XML-Stream>=1.22:${PORTSDIR}/textproc/p5-XML-Stream \
+BUILD_DEPENDS+=	p5-XML-Stream>=1.22:${PORTSDIR}/textproc/p5-XML-Stream \
+		p5-Digest-SHA1>=1.02:${PORTSDIR}/security/p5-Digest-SHA1
+RUN_DEPENDS+=	p5-XML-Stream>=1.22:${PORTSDIR}/textproc/p5-XML-Stream \
 		p5-Digest-SHA1>=1.02:${PORTSDIR}/security/p5-Digest-SHA1
-RUN_DEPENDS=	${BUILD_DEPENDS}
 
 USE_PERL5=	5.8.0+	# Require perl 5.8.x due to XML::Stream
 PERL_MODBUILD=	yes
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->perl 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Sep 16 21:57:41 UTC 2009 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138883 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/138883: commit references a PR
Date: Sat, 19 Sep 2009 20:38:30 +0000 (UTC)

 miwi        2009-09-19 20:38:21 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-im/p5-Net-XMPP   Makefile 
   Log:
   - Fix dependnecy
   
   PR:             138883
   Submitted by:   Vivek Khera <vivek@khera.org>
   Feature safe:   yes
   
   Revision  Changes    Path
   1.6       +3 -2      ports/net-im/p5-Net-XMPP/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Sat Sep 19 20:40:19 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138883 
>Unformatted:
