From gi@serv.azagal.com  Tue Sep 15 15:11:01 2009
Return-Path: <gi@serv.azagal.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2149D106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Sep 2009 15:11:01 +0000 (UTC)
	(envelope-from gi@serv.azagal.com)
Received: from smtp2.electronicbox.net (smtp.electronicbox.net [69.28.239.23])
	by mx1.freebsd.org (Postfix) with ESMTP id EC1398FC24
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Sep 2009 15:11:00 +0000 (UTC)
Received: from azagal.com (62-35-97-65-CableMTL.3menatwork.com [65.97.35.62])
	by smtp2.electronicbox.net (Postfix) with SMTP id A343B410599
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Sep 2009 10:44:31 -0400 (EDT)
Received: (qmail 20824 invoked from network); 15 Sep 2009 14:43:44 -0000
Received: from unknown (HELO serv.azagal.com) (127.0.0.1)
  by localhost.azagal.com with SMTP; 15 Sep 2009 14:43:44 -0000
Received: (from root@localhost)
	by serv.azagal.com (8.14.3/8.14.3/Submit) id n8FEhiKJ020822;
	Tue, 15 Sep 2009 10:43:44 -0400 (EDT)
	(envelope-from gi)
Message-Id: <200909151443.n8FEhiKJ020822@serv.azagal.com>
Date: Tue, 15 Sep 2009 10:43:44 -0400 (EDT)
From: "George D." <gi@azagal.com>
Reply-To: "George D." <gi@azagal.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: www/apache22 mod_proxy optional patch is not applied by the Makefile
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         138846
>Category:       ports
>Synopsis:       www/apache22 mod_proxy optional patch is not applied by the Makefile
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 15 15:20:07 UTC 2009
>Closed-Date:    Fri Dec 11 22:57:37 UTC 2009
>Last-Modified:  Fri Dec 11 23:00:10 UTC 2009
>Originator:     George D.
>Release:        FreeBSD 7.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Tue May 12 07:24:33 EDT 2009 gi@serv.azagal.com:/usr/obj/usr/src/sys/serv_KERN i386

>Description:
	The optional patch for the mod_proxy_connect which can be enabled and disabled throught the config options is not getting applied
	regardless of whether the option is turned on or off.
	This is happening because the Makefile is checking for a wrong variable and not setting the EXTRA_PATCHES variable.
>How-To-Repeat:
	The following steps reproduce the issue:
	- cd into the www/apache22 folder
	- run "make extract"
	- save the modules/proxy/mod_proxy_connect.c file to a different location
	- run "make config"
	- check that the PATCH_PROXY_CONNECT option is turned on
	- run "make patch"
	- check that the modules/proxy/mod_proxy_connect.c file has not changed compared to the original file
>Fix:

	Apply the following patch to the www/apache22/Makefile :

--- Makefile.org        2009-09-15 08:35:07.000000000 -0400
+++ Makefile    2009-09-15 08:35:32.000000000 -0400
@@ -189,7 +189,7 @@ show-options:
        @${SED} -ne 's/^##//p' ${APACHEDIR}/Makefile.doc

 #optionally enable mod_proxy_connect patch
-.if defined(PATCH_PROXY_CONNECT)
+.if defined(WITH_PATCH_PROXY_CONNECT)
 EXTRA_PATCHES+= ${FILESDIR}/opt-patch-modules:proxy:mod_proxy_connect.c
 .endif



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->apache 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Sep 15 15:20:18 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138846 
Responsible-Changed-From-To: apache->pgollucci 
Responsible-Changed-By: pgollucci 
Responsible-Changed-When: Thu Dec 10 10:35:25 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138846 
State-Changed-From-To: open->closed 
State-Changed-By: pgollucci 
State-Changed-When: Fri Dec 11 22:57:36 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138846 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/138846: commit references a PR
Date: Fri, 11 Dec 2009 22:57:38 +0000 (UTC)

 pgollucci    2009-12-11 22:57:29 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/apache22         Makefile 
   Log:
   - Fix option WITH_PATCH_PROXY_CONNECT
   
   PR:             ports/138846
   Submitted by:   "George D." <gi@azagal.com>
   
   Revision  Changes    Path
   1.246     +2 -2      ports/www/apache22/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
