From nobody@FreeBSD.org  Wed Sep  2 11:43:00 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 75C4D106568D
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Sep 2009 11:43:00 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 645F98FC2B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  2 Sep 2009 11:43:00 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n82BgxLY044276
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 2 Sep 2009 11:42:59 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n82Bgx3E044275;
	Wed, 2 Sep 2009 11:42:59 GMT
	(envelope-from nobody)
Message-Id: <200909021142.n82Bgx3E044275@www.freebsd.org>
Date: Wed, 2 Sep 2009 11:42:59 GMT
From: Oleg Gawriloff <barzog@telecom.by>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysutils/bacula-client must include option to build static version of bacula-fd binary
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: dan@langille.org

>Number:         138478
>Category:       ports
>Synopsis:       sysutils/bacula-client must include option to build static version of bacula-fd binary
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wxs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 02 11:50:04 UTC 2009
>Closed-Date:    Sun Oct 11 13:36:35 UTC 2009
>Last-Modified:  Sun Oct 11 13:40:03 UTC 2009
>Originator:     Oleg Gawriloff
>Release:        7.2
>Organization:
Atlant Telecom
>Environment:
FreeBSD albatros.telecom.by 7.2-RELEASE-p2 FreeBSD 7.2-RELEASE-p2 #0: Mon Jul 13 13:04:32 EEST 2009     root@albatros.telecom.by:/usr/obj/usr/src/sys/ALBATROS  i386

>Description:
As stated in http://bacula.org/manuals/en/concepts/concepts/Disast_Recove_Using_Bacula.html#SECTION0026110000000000000000 and http://bacula.org/manuals/en/concepts/concepts/Disast_Recove_Using_Bacula.html#SECTION002670050000000000000 when there is a need for disaster recovery there should be option to build bacula-client as static binary.

Gentoo users have this option:
barzog@falcon-cl2 ~ $ equery uses bacula
 - - static            : !!do not set this during bootstrap!! Causes binaries to be statically linked instead of dynamically

so should we.

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Wed Sep 2 11:50:18 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138478 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: dan@langille.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/138478: sysutils/bacula-client must include option to build static version of bacula-fd binary
Date: Wed, 2 Sep 2009 11:50:16 UT

 Maintainer of sysutils/bacula-client,
 
 Please note that PR ports/138478 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138478
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
Responsible-Changed-From-To: freebsd-ports-bugs->wxs 
Responsible-Changed-By: wxs 
Responsible-Changed-When: Wed Sep 2 23:54:50 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138478 

From: Chris Petrik <c.petrik.sosa@gmail.com>
To: bug-followup@FreeBSD.org, barzog@telecom.by
Cc:  
Subject: Re: ports/138478: sysutils/bacula-client must include option to build
 static version of bacula-fd binary
Date: Thu, 03 Sep 2009 00:59:25 -0500

 This is a multi-part message in MIME format.
 --------------040309010509000602030401
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Hello,
 
 First attempt at a patch,
 
 Please don't laugh that hard ;/
 
 --------------040309010509000602030401
 Content-Type: text/plain;
  name="patch-bacula-client.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="patch-bacula-client.txt"
 
 --- /usr/ports/sysutils/bacula-client/Makefile	2009-08-16 21:54:49.000000000 -0500
 +++ bacula-client/Makefile	2009-09-02 09:26:39.000000000 -0500
 @@ -6,7 +6,11 @@
  
  MASTERDIR=	${.CURDIR}/../bacula-server
  COMMENT=	The network backup solution (client)
 +.if defined(WITH_SFDAEMON)
 +PLIST=		${PKGDIR}/pkg-plist.static
 +else
  PLIST=		${PKGDIR}/pkg-plist.client
 +.endif
  
  WITH_CLIENT_ONLY=	yes
  USE_RC_SUBR=	bacula-fd
 
 --------------040309010509000602030401
 Content-Type: text/plain;
  name="patch-bacula-server.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="patch-bacula-server.txt"
 
 --- /usr/ports/sysutils/bacula-server/Makefile	2009-08-22 19:21:30.000000000 -0500
 +++ bacula-server/Makefile	2009-09-02 10:46:55.000000000 -0500
 @@ -93,13 +93,14 @@
  .if defined(WITH_CLIENT_ONLY)
  OPTIONS=	WXCONSOLE "Build with wxGTK based GUI console: deprecated" off
  OPTIONS+=	GNOMECONSOLE "Build with GNOME based GUI console: deprecated" off
 +OPTIONS+=	SFDAEMON "Build with staticly compiled file daemon" off
  .elif defined(WITH_BAT)
  OPTIONS=	
  .else
 -OPTIONS=	SQLITE3 "Use SqLite-3 database instead of SqLite-2" off
 -OPTIONS+=	MYSQL "Use MySQL database instead of SqLite" off
 -OPTIONS+=	POSTGRESQL "Use PostgreSQL database instead of SqLite" off
 -OPTIONS+=	MTX "Install mtx for control of autochanger devices" off
 +OPTIONS= SQLITE3 "Use SqLite-3 database instead of SqLite-2" off
 +OPTIONS+= MYSQL "Use MySQL database instead of SqLite" off
 +OPTIONS+= POSTGRESQL "Use PostgreSQL database instead of SqLite" off
 +OPTIONS+= MTX "Install mtx for control of autochanger devices" off
  .endif
  
  OPTIONS+=	NLS "Native Language Support via gettext utilities" on
 @@ -139,6 +140,8 @@
  CONFFILES=	fd
  # --disable-xattr is temporary to allow build with 8-current
  CONFIGURE_ARGS+=	--enable-client-only --disable-xattr
 +.if defined(WITH_SFDAEMON)
 +CONFIGURE_ARGS+=	--enable-static-fd
  
  PKGDEINSTALL=	${PKGDIR}/pkg-deinstall.client
  PKGINSTALL=	${PKGDIR}/pkg-install.client
 @@ -151,6 +154,7 @@
  WITHOUT_GNOME=		yes
  PLIST_SUB+=		GNOMECONS="@comment "
  .endif
 +.endif
  # Build bwx-console
  .if defined(WITH_WXCONSOLE)
  USE_WX=			2.4
 @@ -219,6 +223,7 @@
  	@${ECHO_MSG} "  WITH_GNOMECONSOLE=yes	if you only want a GNOME based GUI console."
  	@${ECHO_MSG} "  WITH_MTX=yes		if you want to use mtx instead of chio for autochanger control."
  	@${ECHO_MSG} "  WITH_SQLITE3=yes  	if you want SqLite-3 instead of SqLite-2 as the database."
 +	@${ECHO_MSG} "  WITH_SFDAEMON  if you want staticly compiled file daemon (client)."
  .if !defined(WITH_MYSQL) && !defined(WITH_POSTGRESQL)
  	@${ECHO_MSG} "  WITH_MYSQL=yes  	if you want MySQL instead of SqLite as the database."
  	@${ECHO_MSG} "  WITH_POSTGRESQL=yes	if you want PostgreSQL instead of SqLite as the database."
 
 --------------040309010509000602030401--

From: Chris Petrik <c.petrik.sosa@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/138478: sysutils/bacula-client must include option to build
 static version of bacula-fd binary
Date: Thu, 03 Sep 2009 01:20:01 -0500

 This is a multi-part message in MIME format.
 --------------030903000107050304070406
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 forgot one file.
 
 --------------030903000107050304070406
 Content-Type: text/plain;
  name="pkg-plist.static.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="pkg-plist.static.txt"
 
 sbin/bacula-fd
 sbin/bconsole
 %%GNOMECONS%%sbin/gnome-console
 %%WXCONS%%sbin/bwx-console
 @unexec /usr/bin/killall badula-fd > /dev/null 2>&1 || true
 @exec mkdir -p %%BACULA_DIR%%
 @dirrmtry %%BACULA_DIR%%
 @dirrm share/bacula
 
 --------------030903000107050304070406--

From: Chris Petrik <c.petrik.sosa@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/138478: sysutils/bacula-client must include option to build
 static version of bacula-fd binary
Date: Thu, 03 Sep 2009 11:00:33 -0500

 This is a multi-part message in MIME format.
 --------------010707020206090400080700
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 As per request.
 
 --------------010707020206090400080700
 Content-Type: text/plain;
  name="patch-bacula.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="patch-bacula.diff"
 
 Index: bacula-client/Makefile
 ===================================================================
 RCS file: /usr/ncvs/ports/sysutils/bacula-client/Makefile,v
 retrieving revision 1.5
 diff -u -u -p -r1.5 Makefile
 --- bacula-client/Makefile	14 Aug 2009 20:02:52 -0000	1.5
 +++ bacula-client/Makefile	3 Sep 2009 14:57:08 -0000
 @@ -6,7 +6,11 @@ PKGNAMESUFFIX=  -client
  
  MASTERDIR=	${.CURDIR}/../bacula-server
  COMMENT=	The network backup solution (client)
 -PLIST=		${PKGDIR}/pkg-plist.client
 +.if defined(WITH_SFDAEMON)
 +PLIST=         ${PKGDIR}/pkg-plist.static
 +else
 +PLIST=         ${PKGDIR}/pkg-plist.client
 +.endif
  
  WITH_CLIENT_ONLY=	yes
  USE_RC_SUBR=	bacula-fd
 Index: bacula-server/Makefile
 ===================================================================
 RCS file: /usr/ncvs/ports/sysutils/bacula-server/Makefile,v
 retrieving revision 1.119
 diff -u -u -p -r1.119 Makefile
 --- bacula-server/Makefile	22 Aug 2009 00:35:11 -0000	1.119
 +++ bacula-server/Makefile	3 Sep 2009 15:43:39 -0000
 @@ -93,6 +93,7 @@ IS_INTERACTIVE=	yes
  .if defined(WITH_CLIENT_ONLY)
  OPTIONS=	WXCONSOLE "Build with wxGTK based GUI console: deprecated" off
  OPTIONS+=	GNOMECONSOLE "Build with GNOME based GUI console: deprecated" off
 +OPTIONS+=	SFDAEMON "Build with staticly compiled file daemon" off
  .elif defined(WITH_BAT)
  OPTIONS=	
  .else
 @@ -139,6 +140,8 @@ PKGINSTALL=	${PKGDIR}/pkg-install.server
  CONFFILES=	fd
  # --disable-xattr is temporary to allow build with 8-current
  CONFIGURE_ARGS+=	--enable-client-only --disable-xattr
 +.if defined(WITH_SFDAEMON)
 +CONFIGURE_ARGS+=	--enable-static-fd
  
  PKGDEINSTALL=	${PKGDIR}/pkg-deinstall.client
  PKGINSTALL=	${PKGDIR}/pkg-install.client
 @@ -151,6 +154,7 @@ PLIST_SUB+=		GNOMECONS=""
  WITHOUT_GNOME=		yes
  PLIST_SUB+=		GNOMECONS="@comment "
  .endif
 +.endif
  # Build bwx-console
  .if defined(WITH_WXCONSOLE)
  USE_WX=			2.4
 @@ -219,6 +223,7 @@ pre-everything::
  	@${ECHO_MSG} "  WITH_GNOMECONSOLE=yes	if you only want a GNOME based GUI console."
  	@${ECHO_MSG} "  WITH_MTX=yes		if you want to use mtx instead of chio for autochanger control."
  	@${ECHO_MSG} "  WITH_SQLITE3=yes  	if you want SqLite-3 instead of SqLite-2 as the database."
 +	@${ECHO_MSG} "  WITH_SFDAEMON=yes  if you want staticly compiled file daemon (client)."
  .if !defined(WITH_MYSQL) && !defined(WITH_POSTGRESQL)
  	@${ECHO_MSG} "  WITH_MYSQL=yes  	if you want MySQL instead of SqLite as the database."
  	@${ECHO_MSG} "  WITH_POSTGRESQL=yes	if you want PostgreSQL instead of SqLite as the database."
 Index: bacula-server/pkg-plist.static
 ===================================================================
 RCS file: bacula-server/pkg-plist.static
 diff -N bacula-server/pkg-plist.static
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ bacula-server/pkg-plist.static	3 Sep 2009 14:59:58 -0000
 @@ -0,0 +1,8 @@
 +sbin/bacula-fd
 +sbin/bconsole
 +%%GNOMECONS%%sbin/gnome-console
 +%%WXCONS%%sbin/bwx-console
 +@unexec /usr/bin/killall badula-fd > /dev/null 2>&1 || true
 +@exec mkdir -p %%BACULA_DIR%%
 +@dirrmtry %%BACULA_DIR%%
 +@dirrm share/bacula
 
 --------------010707020206090400080700--
State-Changed-From-To: feedback->closed 
State-Changed-By: wxs 
State-Changed-When: Sun Oct 11 13:36:34 UTC 2009 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138478 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/138478: commit references a PR
Date: Sun, 11 Oct 2009 13:36:22 +0000 (UTC)

 wxs         2009-10-11 13:36:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     sysutils/bacula-server Makefile pkg-plist.client 
   Log:
   - Add an option to build a static fd binary (off by default).
   
   PR:             ports/138478
   Submitted by:   Oleg Gawriloff <barzog@telecom.by>
   Approved by:    maintainer timeout
   
   Revision  Changes    Path
   1.120     +9 -1      ports/sysutils/bacula-server/Makefile
   1.9       +1 -0      ports/sysutils/bacula-server/pkg-plist.client
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
