From neil@darlow.co.uk  Tue Sep  1 20:54:03 2009
Return-Path: <neil@darlow.co.uk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EDE94106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 Sep 2009 20:54:03 +0000 (UTC)
	(envelope-from neil@darlow.co.uk)
Received: from mtaout02-winn.ispmail.ntl.com (mtaout02-winn.ispmail.ntl.com [81.103.221.48])
	by mx1.freebsd.org (Postfix) with ESMTP id 4A0808FC21
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 Sep 2009 20:54:02 +0000 (UTC)
Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35])
          by mtaout02-winn.ispmail.ntl.com
          (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP
          id <20090901205401.XVSN6611.mtaout02-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Tue, 1 Sep 2009 21:54:01 +0100
Received: from router.darlow.co.uk ([82.1.192.202])
          by aamtaout04-winn.ispmail.ntl.com
          (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP
          id <20090901205401.JPGB22934.aamtaout04-winn.ispmail.ntl.com@router.darlow.co.uk>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Tue, 1 Sep 2009 21:54:01 +0100
Received: from router.darlow.co.uk (localhost [127.0.0.1])
	by router.darlow.co.uk (Postfix) with ESMTP id 77B2F102CD6
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  1 Sep 2009 21:54:01 +0100 (BST)
Received: by router.darlow.co.uk (Postfix, from userid 1001)
	id 354AB102C65; Tue,  1 Sep 2009 21:54:01 +0100 (BST)
Message-Id: <20090901205401.354AB102C65@router.darlow.co.uk>
Date: Tue,  1 Sep 2009 21:54:01 +0100 (BST)
From: Neil Darlow <neil@darlow.co.uk>
Reply-To: Neil Darlow <neil@darlow.co.uk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: net/isc-dhcp31-server rcNG script has syntax errors 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         138461
>Category:       ports
>Synopsis:       net/isc-dhcp31-server rcNG script has syntax errors
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jpaetzel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 01 21:00:04 UTC 2009
>Closed-Date:    Wed Sep 02 13:47:52 UTC 2009
>Last-Modified:  Wed Sep  2 13:50:02 UTC 2009
>Originator:     Neil Darlow
>Release:        FreeBSD 7.2-RELEASE-p3 i386
>Organization:
>Environment:
System: FreeBSD router.darlow.co.uk 7.2-RELEASE-p3 FreeBSD 7.2-RELEASE-p3 #0: Wed Jul 29 19:55:32 BST 2009 root@router.darlow.co.uk:/usr/obj/usr/src/sys/ROUTER i386 
>Description:
The sed expression processing $rc_flags contains two errors:
1) Use of $(rc_flags) where ${rc_flags} is intended
2) Misplaced ' character in -q$)'//` where -q$)'//` is intended
Additionally, there is an echo command for $rc_flags which has probably been left
behind from debugging. 	
>How-To-Repeat:
Restart isc-dhcpd and note output produced. 
>Fix:
Patch follows.
--- isc-dhcpd.orig	2009-08-31 21:36:24.000000000 +0100
+++ isc-dhcpd	2009-09-01 21:40:31.000000000 +0100
@@ -706,9 +706,8 @@
         setup_flags
 	rc_flags_mod="$rc_flags"
         # Eliminate '-q' flag if it is present
-	echo $rc_flags
 	case "$rc_flags" in
-	*-q*)	rc_flags_mod=`echo "$(rc_flags)" | sed -Ee 's/(^-q | -q | -q$)'//` ;;
+	*-q*)	rc_flags_mod=`echo "${rc_flags}" | sed -Ee 's/(^-q | -q | -q$)//'` ;;
 	esac
         if ! ${command} -t -q ${rc_flags_mod}; then
                 err 1 "`${command} -t ${rc_flags_mod}` Configuration file sanity check failed"



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->jpaetzel 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Sep 1 21:00:20 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138461 

From: neil@darlow.co.uk (Neil Darlow)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/138461: net/isc-dhcp31-server rcNG script has syntax errors
Date: Wed,  2 Sep 2009 11:56:53 +0100 (BST)

 Production patch for files/isc-dhcpd.in:
 
 --- files/isc-dhcpd.in.orig	2009-07-30 08:32:44.000000000 +0100
 +++ files/isc-dhcpd.in	2009-09-02 07:56:59.000000000 +0100
 @@ -706,9 +706,8 @@
          setup_flags
  	rc_flags_mod="$rc_flags"
          # Eliminate '-q' flag if it is present
 -	echo $rc_flags
  	case "$rc_flags" in
 -	*-q*)	rc_flags_mod=`echo "$(rc_flags)" | sed -Ee 's/(^-q | -q | -q$)'//` ;;
 +	*-q*)	rc_flags_mod=`echo "${rc_flags}" | sed -Ee 's/(^-q | -q | -q$)//'` ;;
  	esac
          if ! ${command} -t -q ${rc_flags_mod}; then
                  err 1 "`${command} -t ${rc_flags_mod}` Configuration file sanity check failed"
State-Changed-From-To: open->closed 
State-Changed-By: jpaetzel 
State-Changed-When: Wed Sep 2 13:47:25 UTC 2009 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138461 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/138461: commit references a PR
Date: Wed,  2 Sep 2009 13:47:14 +0000 (UTC)

 jpaetzel    2009-09-02 13:47:05 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/isc-dhcp31-server Makefile 
     net/isc-dhcp31-server/files isc-dhcpd.in 
   Log:
   Fix syntax errors in rcNG script
   
   PR:     ports/138461
   Submitted by:   Neil Darlow <neil@darlow.co.uk>
   Approved by:    itetcu@ (mentor)
   
   Revision  Changes    Path
   1.129     +1 -1      ports/net/isc-dhcp31-server/Makefile
   1.8       +2 -3      ports/net/isc-dhcp31-server/files/isc-dhcpd.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
