From nobody@FreeBSD.org  Sun Aug 23 13:39:13 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BB86F106568C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Aug 2009 13:39:13 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id AA2AC8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Aug 2009 13:39:13 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7NDdDBI075971
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Aug 2009 13:39:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n7NDdDMJ075970;
	Sun, 23 Aug 2009 13:39:13 GMT
	(envelope-from nobody)
Message-Id: <200908231339.n7NDdDMJ075970@www.freebsd.org>
Date: Sun, 23 Aug 2009 13:39:13 GMT
From: Wen Heping <wenheping@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [Update]databases/ruby-dbi:update to 0.4.2
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         138100
>Category:       ports
>Synopsis:       [Update]databases/ruby-dbi:update to 0.4.2
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ruby
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 23 13:40:05 UTC 2009
>Closed-Date:    Thu Aug 27 11:42:15 UTC 2009
>Last-Modified:  Tue Sep  8 18:20:05 UTC 2009
>Originator:     Wen Heping
>Release:        FreeBSD 8.0-Current
>Organization:
ChangAn Middle School
>Environment:
FreeBSD fb8.wenjing.com 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sun Mar 22 22:12:06 CST 2009     root@fb8.wenjing.com:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
1 update to 0.4.2 from 0.1.1
2 use USE_RUBYGEMS=yes to build and install the port
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -urN ruby-dbi/Makefile ruby-dbi.new/Makefile
--- ruby-dbi/Makefile	2009-08-04 06:06:31.000000000 +0800
+++ ruby-dbi.new/Makefile	2009-08-23 21:35:15.000000000 +0800
@@ -5,45 +5,23 @@
 # $FreeBSD: ports/databases/ruby-dbi/Makefile,v 1.19 2009/08/03 22:06:31 pgollucci Exp $
 #
 
-PORTNAME=	${RUBY_DBI_PORTNAME}
-PORTVERSION=	${RUBY_DBI_PORTVERSION}
-CATEGORIES=	databases ruby
-MASTER_SITES=	${RUBY_DBI_MASTER_SITES}
-MASTER_SITE_SUBDIR=	${RUBY_DBI_MASTER_SITE_SUBDIR}
-PKGNAMEPREFIX=	${RUBY_PKGNAMEPREFIX}
-DISTNAME=	${RUBY_DBI_DISTNAME}
-DIST_SUBDIR=	ruby
+PORTNAME=		dbi
+PORTVERSION=		0.4.2
+PORTEPOCH=		1
+CATEGORIES=		databases rubygems
+MASTER_SITES=		RF
+MASTER_SITE_SUBDIR=	ruby-dbi
 
 MAINTAINER=	ruby@FreeBSD.org
 COMMENT=	DBI-for-Ruby - a common interface for SQL-based databases
 
-RUN_DEPENDS=	${RUBY_SITELIBDIR}/aspectr.rb:${PORTSDIR}/devel/ruby-aspectr
+BUILD_DEPENDS=	rubygem-deprecated>=2.0.0:${PORTSDIR}/devel/rubygem-deprecated
+RUN_DEPENDS=	${BUILD_DEPENDS}
 
-USE_RUBY=	yes
-USE_RUBY_SETUP=	yes
+PLIST_FILES=	bin/dbi
 
-WRKSRC=		${RUBY_DBI_WRKSRC}
-CONFIGURE_ARGS=	--with=bin/commandline,${PORTNAME}
-
-DOCS_EN=	README.1st doc/*
-
-.include "${.CURDIR}/Makefile.common"
-
-post-extract:
-	${MV} ${WRKSRC}/README ${WRKSRC}/README.1st
-
-post-install:
-	${MKDIR} ${RUBY_SITEARCHLIBDIR}/${PORTNAME}
-	${MKDIR} ${RUBY_SITELIBDIR}/DBD
-	${MKDIR} ${RUBY_SITEARCHLIBDIR}/DBD
-.if !defined(NOPORTDOCS)
-	${MKDIR} ${RUBY_MODEXAMPLESDIR}
-	${INSTALL_DATA} ${WRKSRC}/examples/* ${RUBY_MODEXAMPLESDIR}/
-	${MKDIR} ${RUBY_MODDOCDIR}
-.for f in ${DOCS_EN}
-	${CP} -R ${WRKSRC}/${f} ${RUBY_MODDOCDIR}/
-.endfor
-.endif
-	@${CAT} ${PKGMESSAGE}
+USE_RUBY=		yes
+USE_RUBYGEMS=		yes
+RUBYGEM_AUTOPLIST=	yes
 
 .include <bsd.port.mk>
diff -urN ruby-dbi/Makefile.common ruby-dbi.new/Makefile.common
--- ruby-dbi/Makefile.common	2007-01-08 18:03:32.000000000 +0800
+++ ruby-dbi.new/Makefile.common	1970-01-01 08:00:00.000000000 +0800
@@ -1,21 +0,0 @@
-# $FreeBSD: ports/databases/ruby-dbi/Makefile.common,v 1.25 2007/01/08 10:03:32 clsung Exp $
-
-RUBY_DBI_PORTNAME=	dbi
-# Don't forget to clear PORTREVISION's on update
-RUBY_DBI_VERSION=	0.1.1
-RUBY_DBI_PORTVERSION=	${RUBY_DBI_VERSION}
-RUBY_DBI_MASTER_SITES=	${MASTER_SITE_RUBYFORGE}
-RUBY_DBI_MASTER_SITE_SUBDIR=	ruby-${RUBY_DBI_PORTNAME}
-RUBY_DBI_DISTNAME=	${RUBY_DBI_PORTNAME}-${PORTVERSION}
-
-RUBY_DBI_PORTDIR=	${PORTSDIR}/databases/ruby-${RUBY_DBI_PORTNAME}
-
-RUBY_DBI_WRKSRC?=	${WRKDIR}/ruby-dbi
-
-MD5_FILE?=		${RUBY_DBI_PORTDIR}/distinfo
-
-.if ${PORTNAME} == dbi
-RUBY_MODNAME?=		${RUBY_DBI_PORTNAME}
-.else
-RUBY_MODNAME?=		${RUBY_DBI_PORTNAME}/${PORTNAME}
-.endif
diff -urN ruby-dbi/distinfo ruby-dbi.new/distinfo
--- ruby-dbi/distinfo	2007-01-08 18:03:32.000000000 +0800
+++ ruby-dbi.new/distinfo	2009-08-23 12:10:47.000000000 +0800
@@ -1,3 +1,3 @@
-MD5 (ruby/dbi-0.1.1.tar.gz) = 1077f898080bb0af1098ee4b5b54f8d1
-SHA256 (ruby/dbi-0.1.1.tar.gz) = f45a301a81dbc86aa3202f0f0b6eb63e4a3fdd0b622605135575a2000d581b0f
-SIZE (ruby/dbi-0.1.1.tar.gz) = 155533
+MD5 (rubygem/dbi-0.4.2.gem) = ca7a58f2823ab4392c9ec8fab943e5ef
+SHA256 (rubygem/dbi-0.4.2.gem) = 1dbb0d82e17f96d3c23beca5b8cbf04050e3ccfbfcf04d6ed783557d8c76b958
+SIZE (rubygem/dbi-0.4.2.gem) = 73216
diff -urN ruby-dbi/pkg-plist ruby-dbi.new/pkg-plist
--- ruby-dbi/pkg-plist	2006-05-22 06:38:06.000000000 +0800
+++ ruby-dbi.new/pkg-plist	1970-01-01 08:00:00.000000000 +0800
@@ -1,42 +0,0 @@
-@exec mkdir -p %D/%%RUBY_SITEARCHLIBDIR%%/DBD
-@exec mkdir -p %D/%%RUBY_SITEARCHLIBDIR%%/dbi
-@exec mkdir -p %D/%%RUBY_SITELIBDIR%%/DBD
-bin/sqlsh.rb
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/dbd/frontbase/README
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/dbd/mysql/HISTORY
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/dbd/mysql/README
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/dbd/postgresql/README
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/html/ChangeLog.html
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/html/DBD_SPEC.html
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/html/DBI_SPEC.html
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/html/index.html
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/html/rubyStyle.css
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/DBD_SPEC
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/DBI_SPEC
-%%PORTDOCS%%%%RUBY_MODDOCDIR%%/README.1st
-%%PORTDOCS%%@dirrm %%RUBY_MODDOCDIR%%/dbd/frontbase
-%%PORTDOCS%%@dirrm %%RUBY_MODDOCDIR%%/dbd/mysql
-%%PORTDOCS%%@dirrm %%RUBY_MODDOCDIR%%/dbd/postgresql
-%%PORTDOCS%%@dirrm %%RUBY_MODDOCDIR%%/dbd
-%%PORTDOCS%%@dirrm %%RUBY_MODDOCDIR%%/html
-%%PORTDOCS%%@dirrm %%RUBY_MODDOCDIR%%
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/persistence.rb
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/sqlsh.rb.new
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/test1.pl
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/test1.rb
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/test_blob.rb
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/trace_test.rb
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/xmlgen.rb
-%%PORTDOCS%%%%RUBY_MODEXAMPLESDIR%%/xmltest.rb
-%%PORTDOCS%%@dirrm %%RUBY_MODEXAMPLESDIR%%
-@dirrm %%RUBY_SITEARCHLIBDIR%%/DBD
-@dirrm %%RUBY_SITEARCHLIBDIR%%/dbi
-%%RUBY_SITELIBDIR%%/dbi/columninfo.rb
-%%RUBY_SITELIBDIR%%/dbi/row.rb
-%%RUBY_SITELIBDIR%%/dbi/sql.rb
-%%RUBY_SITELIBDIR%%/dbi/trace.rb
-%%RUBY_SITELIBDIR%%/dbi/utils.rb
-%%RUBY_SITELIBDIR%%/dbi/version.rb
-%%RUBY_SITELIBDIR%%/dbi.rb
-@dirrm %%RUBY_SITELIBDIR%%/DBD
-@dirrm %%RUBY_SITELIBDIR%%/dbi


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->ruby 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Aug 23 13:40:14 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138100 

From: Stanislav Sedov <stas@FreeBSD.org>
To: Wen Heping <wenheping@gmail.com>
Cc: ruby@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: ports/138100: [Update]databases/ruby-dbi:update to 0.4.2
Date: Mon, 24 Aug 2009 01:40:05 +0400

 Hi Wen!
 
 Thanks for your patch!  Personally, I'd prefer to stay back
 from switching to gem version as I don't see much benefit
 for this step.  Why have you decided to switch to gem?
 Besides introducing new dependency on the old gem version,
 this will also possible break application that people use
 as this will require changes to this application sorce code
 to function properly with gems (require gems).
 
 Can you please, submit the patch against the current version
 without changing it to using gems?
 
 Thanks!
 
 -- 
 Stanislav Sedov
 ST4096-RIPE

From: wen heping <wenheping@gmail.com>
To: bug-followup@FreeBSD.org, wenheping@gmail.com
Cc:  
Subject: Re: ports/138100: [Update]databases/ruby-dbi:update to 0.4.2
Date: Mon, 24 Aug 2009 07:16:35 +0800

 --0016e646b592e355740471d74a14
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 Hi, stas@ :
 
    With its previous Makefile and Makefile.common, ruby-dbi and
 other ruby-dbd_*  is some dificult to update. And in my plan, I shall update
 all the ruby-dbd_* ports which require ruby-dbi to the newest version
 and use gem and modify the depends.
 
    I do not know which one is welcomed more for ruby port: gem
  or not gem. If not gem, I will try to update it without gem and then
 submit the new patch and close this PR.
 
 Cheers,
 wen
 
 --0016e646b592e355740471d74a14
 Content-Type: text/html; charset=ISO-8859-1
 Content-Transfer-Encoding: quoted-printable
 
 Hi, stas@ :<br>
 <br>
 =A0=A0 With its previous Makefile and Makefile.common, ruby-dbi and <br>
 other ruby-dbd_*=A0 is some dificult to update. And in my plan, I shall upd=
 ate<br>
 all the ruby-dbd_* ports which require ruby-dbi to the newest version<br>
 and use gem and modify the depends.<br>
 <br>
 =A0=A0 I do not know which one is welcomed more for ruby port: gem<br>
 =A0or not gem. If not gem, I will try to update it without gem and then<br>
 submit the new patch and close this PR.<br>
 <br>
 Cheers,<br>
 wen=20
 
 --0016e646b592e355740471d74a14--

From: Stanislav Sedov <stas@FreeBSD.org>
To: wen heping <wenheping@gmail.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/138100: [Update]databases/ruby-dbi:update to 0.4.2
Date: Thu, 27 Aug 2009 12:51:00 +0400

 On Mon, 24 Aug 2009 07:14:02 +0800
 wen heping <wenheping@gmail.com> mentioned:
 
 > Hi, stas@ :
 > 
 >    With its previous Makefile and Makefile.common, ruby-dbi and
 > other ruby-dbd_*  is some dificult to update. And in my plan, I shall update
 > all the ruby-dbd_* ports which require ruby-dbi to the newest version
 > and use gem and modify the depends.
 > 
 >    I do not know which one is welcomed more for ruby port: gem
 >  or not gem. If not gem, I will try to update it without gem and then
 > submit the new patch and close this PR.
 > 
 > Cheers,
 > wen
 > 
 > On Mon, Aug 24, 2009 at 5:40 AM, Stanislav Sedov <stas@freebsd.org> wrote:
 > 
 > > Hi Wen!
 > >
 > > Thanks for your patch!  Personally, I'd prefer to stay back
 > > from switching to gem version as I don't see much benefit
 > > for this step.  Why have you decided to switch to gem?
 > > Besides introducing new dependency on the old gem version,
 > > this will also possible break application that people use
 > > as this will require changes to this application sorce code
 > > to function properly with gems (require gems).
 > >
 > > Can you please, submit the patch against the current version
 > > without changing it to using gems?
 > >
 
 Yeah, I think that staying away from gems for this module is the
 preferrable way to go.  You may submit the new patch to update
 ruby-dbd* ports as followup to this PR.
 
 Thanks!
 
 -- 
 Stanislav Sedov
 ST4096-RIPE
State-Changed-From-To: open->closed 
State-Changed-By: stas 
State-Changed-When: Thu Aug 27 11:42:14 UTC 2009 
State-Changed-Why:  
Close per submitter request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138100 

From: dirk.meyer@dinoex.sub.org (Dirk Meyer)
To: freebsd-ruby@freebsd.org, FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: ports/138100: [Update]databases/ruby-dbi:update to
	0.4.2
Date: Tue, 08 Sep 2009 19:40:58 +0200

 Stanislav Sedov schrieb:,
 
 > Thanks for your patch!  Personally, I'd prefer to stay back
 > from switching to gem version as I don't see much benefit
 > for this step.  Why have you decided to switch to gem?
 > Besides introducing new dependency on the old gem version,
 > this will also possible break application that people use
 > as this will require changes to this application sorce code
 > to function properly with gems (require gems).
 > 
 > Can you please, submit the patch against the current version
 > without changing it to using gems?
 
 I have already a patch set for dbi and dbd.
 
 I wait for the expiration of modules that are no longer supported
 by the new version.
 
 modules set for expire:
 ruby-dbd_interbase
 ruby-dbd_msql
 ruby-dbd_proxy
 
 modules updated:
 ruby-dbd_mysql
 ruby-dbd_odbc
 ruby-dbd_pg
 ruby-dbd_sqlite
 ruby-dbi
 
 new modules.
 ruby-dbd_sqlite3
 
 Preview:
 http://people.freebsd.org/~dinoex/ports/ruby-dbd_mysql.tar.gz
 http://people.freebsd.org/~dinoex/ports/ruby-dbd_odbc.tar.gz
 http://people.freebsd.org/~dinoex/ports/ruby-dbd_pg.tar.gz
 http://people.freebsd.org/~dinoex/ports/ruby-dbd_sqlite.tar.gz
 http://people.freebsd.org/~dinoex/ports/ruby-dbi.tar.gz
 
 
 kind regards Dirk
 
 - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
 - [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]
>Unformatted:
