From nobody@FreeBSD.org  Fri Aug 21 22:34:26 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4CF64106568E
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 Aug 2009 22:34:26 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 3CBF38FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 Aug 2009 22:34:26 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7LMYPDx035073
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 21 Aug 2009 22:34:25 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n7LMYPXL035072;
	Fri, 21 Aug 2009 22:34:25 GMT
	(envelope-from nobody)
Message-Id: <200908212234.n7LMYPXL035072@www.freebsd.org>
Date: Fri, 21 Aug 2009 22:34:25 GMT
From: Kalten <kalten@gmx.at>
To: freebsd-gnats-submit@FreeBSD.org
Subject: multimedia/ogle: buggy pre-configure
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         138056
>Category:       ports
>Synopsis:       multimedia/ogle: buggy pre-configure
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    freebsd-multimedia
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 21 22:40:02 UTC 2009
>Closed-Date:    Sun Nov 08 09:39:25 UTC 2009
>Last-Modified:  Sun Nov 08 09:39:25 UTC 2009
>Originator:     Kalten
>Release:        7.2-STABLE (702105)
>Organization:
>Environment:
FreeBSD freeHugin.Walhalla.Leben 7.2-STABLE FreeBSD 7.2-STABLE #0: Thu Aug 20 02:54:05 UTC 2009     root@freeHugin.Walhalla.Leben:/usr/obj/usr/src/sys/HUGIN  i386
>Description:
csup of system at 20.Aug 2009,
csup of ports  at 20.Aug 2009 (no ports build before that)
# $FreeBSD: ports/multimedia/ogle/Makefile,v 1.46 2009/08/02 19:34:51 mezz Exp $

when compiling (not in a TB?) the pre-configure generates faulty entries in the "configure" file.  It inserts a little bit too much from ${LOCALBASE}/lib/liba52.la as it insert a part of a comment. The comments must be greped away (see patch)!!! or configure will fale with what was generated at "hack to make ogle work with liba52 + djbfft".

---SCHNIPP--- part from my ${LOCALBASE}/lib/liba52.la
# Linker flags that can not go in dependency_libs.
inherited_linker_flags=''

# Libraries that this one depends upon.
dependency_libs=' -L/usr/local/lib -ldjbfft -lm'
---schnapp---

it greps out
---SCHNIPP--- grep dependency_libs ${LOCALBASE}/lib/liba52.la | cut -d \' -f 2
# Linker flags that can not go in dependency_libs.
 -L/usr/local/lib -ldjbfft -lm
---schnapp---
instead of just the last line. Because of that, configure tries to compile a file called "#" and so on.
>How-To-Repeat:
make
>Fix:
Error in /usr/ports/multimedia/ogle/Makfile
Appended patch-file helps.

Patch attached with submission follows:

--- Makefile.orig	2009-08-20 02:43:53.000000000 +0200
+++ Makefile	2009-08-22 00:01:10.000000000 +0200
@@ -65,7 +65,7 @@
 
 # hack to make ogle work with liba52 + djbfft
 .if exists(${LOCALBASE}/lib/liba52.la)
-LIBA52_DEP_LIBS!=	${GREP} dependency_libs ${LOCALBASE}/lib/liba52.la | ${CUT} -d \' -f 2
+LIBA52_DEP_LIBS!=	${GREP} dependency_libs ${LOCALBASE}/lib/liba52.la | ${GREP} -v ^"[ \t]*#" | ${CUT} -d \' -f 2
 .else
 LIBA52_DEP_LIBS=
 .endif


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-multimedia 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 21 22:40:12 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138056 

From: P Szmytka <p.szmytka@gmail.com>
To: P Szmytka <p.szmytka@gmail.com>
Cc: bug-followup@FreeBSD.org, kalten@gmx.at
Subject: Re: ports/138056: multimedia/ogle: buggy pre-configure
Date: Tue, 25 Aug 2009 16:39:10 +0100

 I meant thanks Kalten!
 
 Sorry for that.
 
 On Tue, 2009-08-25 at 16:31 +0100, P Szmytka wrote:
 > I needed to escape the hash for the patch to work for me.
 > I've attached the amended patch.
 > 
 > Anyway thanks edwin, great job!
 > 
 > Cheers,
 > Szmytson
 

From: P Szmytka <p.szmytka@gmail.com>
To: bug-followup@FreeBSD.org, kalten@gmx.at
Cc:  
Subject: Re: ports/138056: multimedia/ogle: buggy pre-configure
Date: Tue, 25 Aug 2009 16:31:05 +0100

 --=-XcmrWyjS+4A1M6+/geFU
 Content-Type: text/plain
 Content-Transfer-Encoding: 7bit
 
 I needed to escape the hash for the patch to work for me.
 I've attached the amended patch.
 
 Anyway thanks edwin, great job!
 
 Cheers,
 Szmytson
 
 --=-XcmrWyjS+4A1M6+/geFU
 Content-Disposition: attachment; filename="ogle.patch"
 Content-Type: text/x-patch; name="ogle.patch"; charset="UTF-8"
 Content-Transfer-Encoding: 7bit
 
 --- Makefile	2009-08-25 16:27:54.000000000 +0100
 +++ Makefile.szmytkap	2009-08-25 15:55:10.000000000 +0100
 @@ -65,7 +65,7 @@
  
  # hack to make ogle work with liba52 + djbfft
  .if exists(${LOCALBASE}/lib/liba52.la)
 -LIBA52_DEP_LIBS!=	${GREP} dependency_libs ${LOCALBASE}/lib/liba52.la | ${CUT} -d \' -f 2
 +LIBA52_DEP_LIBS!=	${GREP} dependency_libs ${LOCALBASE}/lib/liba52.la | ${GREP} -v ^"[ \t]*\#" | ${CUT} -d \' -f 2
  .else
  LIBA52_DEP_LIBS=
  .endif
 
 --=-XcmrWyjS+4A1M6+/geFU--
 
State-Changed-From-To: open->closed 
State-Changed-By: arved 
State-Changed-When: Sun Nov 8 09:38:53 UTC 2009 
State-Changed-Why:  
Fix was committed by deischen on Sep 27. Thanks for reporting 

http://www.freebsd.org/cgi/query-pr.cgi?pr=138056 
>Unformatted:
