From nobody@FreeBSD.org  Fri Aug  7 09:03:08 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D451F1065679
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  7 Aug 2009 09:03:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id C42BC8FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  7 Aug 2009 09:03:08 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n77938uX056499
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 7 Aug 2009 09:03:08 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n77938KB056498;
	Fri, 7 Aug 2009 09:03:08 GMT
	(envelope-from nobody)
Message-Id: <200908070903.n77938KB056498@www.freebsd.org>
Date: Fri, 7 Aug 2009 09:03:08 GMT
From: dikshie <dikshie@sfc.wide.ad.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: patch for quagga
X-Send-Pr-Version: www-3.1
X-GNATS-Notify: boris@tagnet.ru

>Number:         137510
>Category:       ports
>Synopsis:       patch for net/quagga
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 07 09:10:04 UTC 2009
>Closed-Date:    Tue Aug 18 12:50:58 UTC 2009
>Last-Modified:  Tue Aug 18 13:00:12 UTC 2009
>Originator:     dikshie
>Release:        FreeBSD-7.2
>Organization:
Keio University
>Environment:
FreeBSD ipv6.ppk.itb.ac.id 7.2-STABLE FreeBSD 7.2-STABLE #56: Mon Jul 13 17:35:47 WIT 2009     dikshie@ipv6.ppk.itb.ac.id:/usr/obj/usr/src/sys/PPK  i386

>Description:
ospf6d bug on quagga-0.99.14.
read bug #541 on quagga's bugzilla for detail.

>How-To-Repeat:

>Fix:
patch is made by tomh at tomh dot org

Patch attached with submission follows:

Index: ospf6d/ospf6_lsa.c
===================================================================
--- ospf6d/ospf6_lsa.c	(revision 21)
+++ ospf6d/ospf6_lsa.c	(working copy)
@@ -207,9 +207,11 @@
     zlog_warn ("LSA: quagga_gettime failed, may fail LSA AGEs: %s",
                safe_strerror (errno));
 
-  if (lsa->header->age >= htons (MAXAGE))
+  if (ntohs (lsa->header->age) >= MAXAGE)
     {
-      /* LSA may have been prematurely aged */
+      /* ospf6_lsa_premature_aging () sets age to MAXAGE; when using
+         relative time, we cannot compare against lsa birth time, so
+         we catch this special case here. */
       lsa->header->age = htons (MAXAGE);
       return MAXAGE;
     }
@@ -245,11 +247,6 @@
   THREAD_OFF (lsa->expire);
   THREAD_OFF (lsa->refresh);
 
-  /* 
-   * The below technique to age out LSA does not work when using relative time 
-   *
-  memset (&lsa->birth, 0, sizeof (struct timeval));
-   */
   lsa->header->age = htons (MAXAGE);
   thread_execute (master, ospf6_lsa_expire, lsa, 0);
 }


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Sun Aug 9 11:03:50 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137510 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: boris@tagnet.ru
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/137510: patch for net/quagga
Date: Sun, 9 Aug 2009 11:03:48 UT

 Maintainer of net/quagga,
 
 Please note that PR ports/137510 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/137510
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Boris Kovalenko <boris@tagnet.ru>
To: bug-followup@FreeBSD.org, dikshie@sfc.wide.ad.jp
Cc:  
Subject: Re: ports/137510: patch for net/quagga
Date: Mon, 10 Aug 2009 12:19:42 +0600

 Hello!
 
 Agree
 
 With regards,
 	Boris
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Mon Aug 10 11:55:14 UTC 2009 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137510 
State-Changed-From-To: open->closed 
State-Changed-By: bsam 
State-Changed-When: Tue Aug 18 12:49:35 UTC 2009 
State-Changed-Why:  
Committed, thanks! 
PORTREVISION was bumped as well. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137510 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/137510: commit references a PR
Date: Tue, 18 Aug 2009 12:49:16 +0000 (UTC)

 bsam        2009-08-18 12:49:04 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net/quagga           Makefile 
   Added files:
     net/quagga/files     patch-ospf6d-ospf6_lsa.c 
   Log:
   . fix an ospf6d bug on quagga-0.99.14 (bug #541 on quagga's bugzilla);  [1]
   . bump PORTREVISION.
   
   PR:             ports/137510  [1]
   Submitted by:   dikshie <dikshie at sfc.wide.ad.jp>  [1]
   Approved by:    Boris Kovalenko <boris at tagnet.ru> (maintainer)  [1]
   
   Revision  Changes    Path
   1.90      +1 -1      ports/net/quagga/Makefile
   1.1       +28 -0     ports/net/quagga/files/patch-ospf6d-ospf6_lsa.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
