From lapo@lapo.it  Wed Jul 22 16:46:24 2009
Return-Path: <lapo@lapo.it>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5404F106564A
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed, 22 Jul 2009 16:46:24 +0000 (UTC)
	(envelope-from lapo@lapo.it)
Received: from mail.lapo.it (motoko.lapo.it [88.198.0.105])
	by mx1.freebsd.org (Postfix) with ESMTP id B83D58FC13
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed, 22 Jul 2009 16:46:23 +0000 (UTC)
	(envelope-from lapo@lapo.it)
Received: (qmail 74095 invoked by uid 89); 22 Jul 2009 16:46:22 -0000
Received: from firewall.andxor.it (HELO lapo.andxor.it) (lapo@lapo.it@195.223.2.2)
  by 0 with ESMTPA; 22 Jul 2009 16:46:22 -0000
Message-Id: <4A674259.6020902@lapo.it>
Date: Wed, 22 Jul 2009 18:46:17 +0200
From: Lapo Luchini <lapo@lapo.it>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: [MAINTAINER] java/sqlitejdbc: activate existent feature

>Number:         137001
>Category:       ports
>Synopsis:       [MAINTAINER] java/sqlitejdbc: activate existent feature
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    miwi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jul 22 16:50:05 UTC 2009
>Closed-Date:    Mon Jul 27 22:29:31 UTC 2009
>Last-Modified:  Mon Jul 27 22:30:12 UTC 2009
>Originator:     Lapo Luchini
>Release:        FreeBSD 7.2-RELEASE-p2 amd64
>Organization:
>Environment:
System: FreeBSD lapo.andxor.it 7.2-RELEASE-p2 FreeBSD 7.2-RELEASE-p2 #0:
Wed Jun 24 00:14:35 UTC 2009
>Description:

Activat support for getGeneratedKeys() for prepared statements, which is
supported as well as the non-prepared statement case, but it was
currently returning a not implemented exception.

Added file(s):
- files/patch-src_org_sqlite_Conn.java

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:

conn.prepareStatement("INSERT INTO .........",
Statement.RETURN_GENERATED_KEYS );

>Fix:

--- sqlitejdbc-056.patch begins here ---
diff -ruN --exclude=CVS
/usr/ports/java/sqlitejdbc.orig/files/patch-src_org_sqlite_Conn.java
/usr/ports/java/sqlitejdbc/files/patch-src_org_sqlite_Conn.java
---
/usr/ports/java/sqlitejdbc.orig/files/patch-src_org_sqlite_Conn.java
1970-01-01 01:00:00.000000000 +0100
+++ /usr/ports/java/sqlitejdbc/files/patch-src_org_sqlite_Conn.java
2009-07-22 18:33:57.000000000 +0200
@@ -0,0 +1,14 @@
+--- src/org/sqlite/Conn.java.orig	2009-07-22 18:33:46.000000000 +0200
++++ src/org/sqlite/Conn.java	2009-07-22 18:33:53.000000000 +0200
+@@ -214,7 +214,10 @@ class Conn implements Connection
+                                      ResultSet.CONCUR_READ_ONLY);
+     }
+     public PreparedStatement prepareStatement(String sql, int autoC)
+-        throws SQLException { throw new SQLException("NYI"); }
++                                throws SQLException {
++        return prepareStatement(sql, ResultSet.TYPE_FORWARD_ONLY,
++                                     ResultSet.CONCUR_READ_ONLY);
++    }
+     public PreparedStatement prepareStatement(String sql, int[] colInds)
+         throws SQLException { throw new SQLException("NYI"); }
+     public PreparedStatement prepareStatement(String sql, String[]
colNames)
--- sqlitejdbc-056.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->miwi 
Responsible-Changed-By: miwi 
Responsible-Changed-When: Thu Jul 23 19:13:58 UTC 2009 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137001 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Mon Jul 27 22:29:30 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137001 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/137001: commit references a PR
Date: Mon, 27 Jul 2009 22:29:09 +0000 (UTC)

 miwi        2009-07-27 22:28:55 UTC
 
   FreeBSD ports repository
 
   Modified files:
     java/sqlitejdbc      Makefile 
   Added files:
     java/sqlitejdbc/files patch-src_org_sqlite_Conn.java 
   Log:
   - Activat support for getGeneratedKeys() for prepared statements, which is
     supported as well as the non-prepared statement case, but it was
     currently returning a not implemented exception.
   
   PR:             137001
   Submitted by:   Lapo Luchini <lapo@lapo.it> (maintainer)
   
   Revision  Changes    Path
   1.5       +1 -0      ports/java/sqlitejdbc/Makefile
   1.1       +14 -0     ports/java/sqlitejdbc/files/patch-src_org_sqlite_Conn.java (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
