From pgollucci@FreeBSD.org  Fri Jul 17 07:11:38 2009
Return-Path: <pgollucci@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7BA371065670
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 17 Jul 2009 07:11:38 +0000 (UTC)
	(envelope-from pgollucci@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6895F8FC17;
	Fri, 17 Jul 2009 07:11:38 +0000 (UTC)
	(envelope-from pgollucci@FreeBSD.org)
Received: from freefall.freebsd.org (pgollucci@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6H7Bc1P039477;
	Fri, 17 Jul 2009 07:11:38 GMT
	(envelope-from pgollucci@freefall.freebsd.org)
Received: (from pgollucci@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6H7Bbvj039476;
	Fri, 17 Jul 2009 07:11:37 GMT
	(envelope-from pgollucci)
Message-Id: <200907170711.n6H7Bbvj039476@freefall.freebsd.org>
Date: Fri, 17 Jul 2009 07:11:37 GMT
From: "Philip M. Gollucci" <pgollucci@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: freebsd@next-generation.org
Subject: [PATCH] japanese/ja-multiskkserv: USE_RC_SUBR != yes
X-Send-Pr-Version: 3.113
X-GNATS-Notify: freebsd@next-generation.org

>Number:         136840
>Category:       ports
>Synopsis:       [PATCH] japanese/ja-multiskkserv: USE_RC_SUBR != yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pgollucci
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 17 07:20:00 UTC 2009
>Closed-Date:    Thu Dec 17 23:19:43 UTC 2009
>Last-Modified:  Thu Dec 17 23:20:05 UTC 2009
>Originator:     Philip M. Gollucci
>Release:        FreeBSD 7.2-STABLE i386
>Organization:
RideCharge Inc.
>Environment:
System: FreeBSD freefall.freebsd.org 7.2-STABLE FreeBSD 7.2-STABLE #38 r194101: Sat Jun 13 11:12:24 UTC
>Description:

Added file(s):
- files/multiskkserv.in

Removed file(s):
- files/multiskkserv.sh

Port maintainer (freebsd@next-generation.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- ja-multiskkserv-0.20020201_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/japanese/multiskkserv/Makefile,v
retrieving revision 1.3
diff -u -u -r1.3 Makefile
--- Makefile	9 May 2006 00:18:00 -0000	1.3
+++ Makefile	17 Jul 2009 07:11:23 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	multiskkserv
 PORTVERSION=	0.20020201
+PORTREVISION=	1
 CATEGORIES=	japanese
 MASTER_SITES=	http://www3.big.or.jp/~sian/linux/products/
 DISTNAME=	${PORTNAME}-${PORTVERSION:S/0.//g}
@@ -23,25 +24,13 @@
 SKKJISYO_TYPE?=	L
 
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION:S/0.//g}
-USE_RC_SUBR=	yes
+USE_RC_SUBR=	${PORTNAME}
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS+=	--with-cdb=`cd ${PORTSDIR}/databases/cdb; ${MAKE} -V WRKSRC`
 
-post-extract:
-	${CP} ${FILESDIR}/multiskkserv.sh ${WRKDIR}/multiskkserv.sh
-
-post-patch:
-	@${REINPLACE_CMD} \
-		-e 's,%%PREFIX%%,${PREFIX},g' \
-		-e 's,%%RC_SUBR%%,${RC_SUBR},g' \
-		-e 's,%%SKKDIR%%,${SKKDIR},g' \
-		-e 's,%%SKKJISYO_TYPE%%,${SKKJISYO_TYPE},g' \
-		${WRKDIR}/multiskkserv.sh
-
 do-install:
 	@${INSTALL_PROGRAM} ${WRKSRC}/src/multiskkserv ${PREFIX}/sbin
 	@${INSTALL_PROGRAM} ${WRKSRC}/src/multiskkserv-ctl ${PREFIX}/sbin
 	@${INSTALL_PROGRAM} ${WRKSRC}/tools/skkdic-p2cdb ${PREFIX}/bin
-	@${INSTALL_SCRIPT} ${WRKDIR}/multiskkserv.sh ${PREFIX}/etc/rc.d/
 
 .include <bsd.port.mk>
Index: pkg-plist
===================================================================
RCS file: /home/pcvs/ports/japanese/multiskkserv/pkg-plist,v
retrieving revision 1.1
diff -u -u -r1.1 pkg-plist
--- pkg-plist	8 Jan 2004 02:17:33 -0000	1.1
+++ pkg-plist	17 Jul 2009 07:11:23 -0000
@@ -1,4 +1,3 @@
 sbin/multiskkserv
 sbin/multiskkserv-ctl
 bin/skkdic-p2cdb
-etc/rc.d/multiskkserv.sh
Index: files/multiskkserv.in
===================================================================
RCS file: files/multiskkserv.in
diff -N files/multiskkserv.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/multiskkserv.in	17 Jul 2009 07:11:23 -0000
@@ -0,0 +1,30 @@
+#!/bin/sh
+#
+# $FreeBSD: ports/japanese/multiskkserv/files/multiskkserv.sh,v 1.3 2006/02/20 20:47:05 dougb Exp $
+#
+
+# PROVIDE: multiskkserv
+# REQUIRE: LOGIN
+
+#
+# Add the following lines to /etc/rc.conf to enable multiskkserv:
+#
+#multiskkserv_enable="YES"
+#
+# See `%%PREFIX%%/sbin/multiskkserv -h` for flags
+#
+
+. %%RC_SUBR%%
+
+name=multiskkserv
+rcvar=`set_rcvar`
+
+command=%%PREFIX%%/sbin/multiskkserv
+
+# set defaults
+
+multiskkserv_enable=${multiskkserv_enable:-"NO"}
+multiskkserv_flags=${multiskkserv_flags:-"%%PREFIX%%/%%SKKDIR%%/SKK-JISYO.%%SKKJISYO_TYPE%%.cdb &"}
+
+load_rc_config ${name}
+run_rc_command "$1"
Index: files/multiskkserv.sh
===================================================================
RCS file: files/multiskkserv.sh
diff -N files/multiskkserv.sh
--- files/multiskkserv.sh	20 Feb 2006 20:47:05 -0000	1.3
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,30 +0,0 @@
-#!/bin/sh
-#
-# $FreeBSD: ports/japanese/multiskkserv/files/multiskkserv.sh,v 1.3 2006/02/20 20:47:05 dougb Exp $
-#
-
-# PROVIDE: multiskkserv
-# REQUIRE: LOGIN
-
-#
-# Add the following lines to /etc/rc.conf to enable multiskkserv:
-#
-#multiskkserv_enable="YES"
-#
-# See `%%PREFIX%%/sbin/multiskkserv -h` for flags
-#
-
-. %%RC_SUBR%%
-
-name=multiskkserv
-rcvar=`set_rcvar`
-
-command=%%PREFIX%%/sbin/multiskkserv
-
-# set defaults
-
-multiskkserv_enable=${multiskkserv_enable:-"NO"}
-multiskkserv_flags=${multiskkserv_flags:-"%%PREFIX%%/%%SKKDIR%%/SKK-JISYO.%%SKKJISYO_TYPE%%.cdb &"}
-
-load_rc_config ${name}
-run_rc_command "$1"
--- ja-multiskkserv-0.20020201_1.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->pgollucci 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Jul 17 07:20:32 UTC 2009 
Responsible-Changed-Why:  
Submitter has GNATS access (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136840 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Fri Jul 17 07:20:37 UTC 2009 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136840 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: freebsd@next-generation.org
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/136840: [PATCH] japanese/ja-multiskkserv: USE_RC_SUBR != yes
Date: Fri, 17 Jul 2009 07:20:35 UT

 Maintainer of japanese/multiskkserv,
 
 Please note that PR ports/136840 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136840
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org
State-Changed-From-To: feedback->closed 
State-Changed-By: pgollucci 
State-Changed-When: Thu Dec 17 23:19:42 UTC 2009 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136840 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/136840: commit references a PR
Date: Thu, 17 Dec 2009 23:19:42 +0000 (UTC)

 pgollucci    2009-12-17 23:19:32 UTC
 
   FreeBSD ports repository
 
   Modified files:
     japanese/multiskkserv Makefile pkg-plist 
     japanese/multiskkserv/files multiskkserv.sh 
   Log:
   - USE_RC_SUBR != yes
   
   PR:             ports/136840
   Approved by:    maintainer timeout (freebsd@next-generation.org; > 5 months)
   Submitted by:   myself (pgollucci@)
   
   Revision  Changes    Path
   1.4       +2 -13     ports/japanese/multiskkserv/Makefile
   1.4       +0 -30     ports/japanese/multiskkserv/files/multiskkserv.sh
   1.2       +0 -1      ports/japanese/multiskkserv/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
