From nobody@FreeBSD.org  Thu Jul  9 00:21:12 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8A7BC106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  9 Jul 2009 00:21:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 777208FC1E
	for <freebsd-gnats-submit@FreeBSD.org>; Thu,  9 Jul 2009 00:21:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n690LCvp038646
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 9 Jul 2009 00:21:12 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n690LC9X038645;
	Thu, 9 Jul 2009 00:21:12 GMT
	(envelope-from nobody)
Message-Id: <200907090021.n690LC9X038645@www.freebsd.org>
Date: Thu, 9 Jul 2009 00:21:12 GMT
From: Dereckson <dereckson@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [misc/ctorrent] [patch] option to install ctcs
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         136483
>Category:       ports
>Synopsis:       net-p2p/ctorrent: [patch] option to install ctcs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    flz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 09 00:30:03 UTC 2009
>Closed-Date:    Fri Jul 17 12:19:20 UTC 2009
>Last-Modified:  Fri Jul 17 12:20:01 UTC 2009
>Originator:     Dereckson
>Release:        7.2-RELEASE
>Organization:
>Environment:
FreeBSD scherzo.dereckson.be 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 08:49:13 UTC 2009     root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Enhanced CTorrent have a CTorrent Control Server  (CTCS) I maintain under net-p2p/ctcs port.

It would be more convenient if at ctorrent install, we've an option to also install ctcs.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

--- Makefile.orig	2008-08-21 06:18:04.000000000 +0000
+++ Makefile	2009-07-09 00:15:13.000000000 +0000
@@ -7,13 +7,21 @@
 
 PORTNAME=	ctorrent
 PORTVERSION=	3.3.2
+PORTREVISION=	1
 CATEGORIES=	net-p2p
-MASTER_SITES=	http://www.rahul.net/dholmes/ctorrent/
+MASTER_SITES=	SF/dtorrent http://www.rahul.net/dholmes/ctorrent/
 DISTNAME=	${PORTNAME}-dnh${PORTVERSION}
 
 MAINTAINER=	flz@FreeBSD.org
 COMMENT=	BitTorrent Client written in C for FreeBSD and Linux
 
+OPTIONS=	CTCS	"CTorrent Control Server (CTCS)" Off
+.include <bsd.port.options.mk>
+
+.if defined(WITH_CTCS)
+RUN_DEPENDS=	${LOCALBASE}/bin/ctcs:${PORTSDIR}/net-p2p/ctcs
+.endif
+
 GNU_CONFIGURE=	yes
 #WRKSRC=		${WRKDIR}/${PORTNAME}-dnh${PATCHLEVEL}
 


>Release-Note:
>Audit-Trail:

From: =?ISO-8859-1?Q?S=E9bastien_Santoro?= <dereckson@gmail.com>
To: bug-followup@FreeBSD.org, dereckson@gmail.com
Cc:  
Subject: Re: ports/136483: [misc/ctorrent] [patch] option to install ctcs
Date: Thu, 9 Jul 2009 16:32:41 +0200

 Please assign the ticket to flz@FreeBSD.org, the port maintainer.
Responsible-Changed-From-To: freebsd-ports-bugs->flz 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Jul 9 18:27:22 UTC 2009 
Responsible-Changed-Why:  
Fix synopsis and assign. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136483 
State-Changed-From-To: open->feedback 
State-Changed-By: flz 
State-Changed-When: Wed Jul 15 13:12:49 UTC 2009 
State-Changed-Why:  
Feedback requested. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136483 

From: Florent Thoumie <flz@xbsd.org>
To: bug-followup@freebsd.org, dereckson@gmail.com
Cc:  
Subject: Re: ports/136483: net-p2p/ctorrent: [patch] option to install ctcs
Date: Wed, 15 Jul 2009 14:12:11 +0100

 I don't think this is correct. CTCS should RUN_DEPENDS on ctorrent.
 
 I understand that people might be interested in installing
 net-p2p/ctcs when they're installing net-p2p/ctorrent, but the ports
 framework has no facility to suggest additional ports/packages at the
 moment. What I can do is adding a pkg-install file that will mention
 CTCS.
 
 -- 
 Florent Thoumie
 flz@FreeBSD.org
 FreeBSD Committer

From: =?ISO-8859-1?Q?S=E9bastien_Santoro?= <dereckson@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/136483: net-p2p/ctorrent: [patch] option to install ctcs
Date: Wed, 15 Jul 2009 20:36:19 +0200

 Mention CTCS in the ctorrent install is indeed a good solution. When I
 submitted the patch, I thought about the php port allowing PHP
 extensions installation.
 
 I didn't add a dependency to ctorrent in ctcs port, to allow users to
 install only the server, for scenario you want to centralize desktop
 computers downloads on a server.
State-Changed-From-To: feedback->closed 
State-Changed-By: flz 
State-Changed-When: Fri Jul 17 12:19:19 UTC 2009 
State-Changed-Why:  
I've added net-p2p/ctcs to pkg-message. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136483 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/136483: commit references a PR
Date: Fri, 17 Jul 2009 12:19:01 +0000 (UTC)

 flz         2009-07-17 12:18:51 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-p2p/ctorrent     Makefile 
   Added files:
     net-p2p/ctorrent     pkg-message 
   Log:
   Add pkg-message mentioning net-p2p/ctcs.
   
   PR:             ports/136483
   Submitted by:   Sébastien Santoro
   
   Revision  Changes    Path
   1.22      +3 -1      ports/net-p2p/ctorrent/Makefile
   1.1       +8 -0      ports/net-p2p/ctorrent/pkg-message (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
